Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685828 - sys-libs/libblockdev USE=kbd has a different meaning than media-video/vdr USE=kbd
Summary: sys-libs/libblockdev USE=kbd has a different meaning than media-video/vdr USE...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-13 13:24 UTC by Martin Mokrejš
Modified: 2019-12-15 12:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Mokrejš 2019-05-13 13:24:43 UTC
I came across this package and wondered about its USE flags (being unclear from their brief names). Not only, the "kbd" stands from "kernel block device" instead of "keyboard" which one would assume, and indeed media-video/vdr assumes as well.

Please rename "kbd" to "kernel-block-device" (or else) in IUSE of sys-libs/libblockdev.

https://packages.gentoo.org/useflags/kbd

Nit: maybe the metadata.xml could be clearer and explain if kernel block device is needed for bcache?
Comment 1 Jeroen Roovers gentoo-dev 2019-05-13 13:30:24 UTC
$ euses -s kbd
media-video/vdr:kbd - enable keyboard support as remote device
sys-libs/libblockdev:kbd - Enable kernel block device support.

So what you want is to cause these *two* definitions to change a USE flag for one of them? Even if I widen the search it merely resolves into a single extra USE flag that includes the "kbd" string:

app-admin/passwordsafe:xvkbd - Install x11-misc/xvkbd on-screen keyboard
Comment 2 Jeroen Roovers gentoo-dev 2019-05-13 13:32:21 UTC
Also this:

$ euses keyboard
dev-qt/qt-docs:virtualkeyboard - Install documentation for dev-qt/qtvirtualkeyboard
kde-apps/kmag:keyboardfocus - Enable keyboard focus tracking
media-sound/csound:keyboard - Build Virtual MIDI keyboard
wl-weekeyboard - Wayland virtual keyboard
keyboard - INPUT_DEVICES setting to build driver for keyboard input devices
Comment 3 Martin Mokrejš 2019-05-13 13:43:20 UTC
> So what you want is to cause these *two* definitions to change a USE flag for
> one of them?

Yes, the reason is that "kbd" is so well known abbreviation for keyboard IMO that sys-libs/libblockdev is just misusing it. Personally I would not be happy if we (as a result of this discussion) invented distinction between USE=kbd and USE=keyboard. They would be confusing. I just think sys-libs/libblockdev should invent its own USE variable name. Whichever.

Probably configure will discover anyway if my kernel supports kernel block device, large block device, bcache, zswap or whatever the package eventually supports.

http://storaged.org/libblockdev/libblockdev-KernelBlockDevices.html
http://storaged.org/libblockdev
Comment 4 Arfrever Frehtes Taifersar Arahesis 2019-05-13 18:35:30 UTC
I do not think that "kbd" is useful abbreviation.
Since at least 1 other package has "keyboard" USE flag which sounds much clearer, I suggest that "kbd" USE flag of media-video/vdr be renamed to "keyboard".


Renaming "kbd" USE flag of sys-libs/libblockdev to "kernel-block-device" or "kernel_block_device" might be a good idea.
Another possibility is to unconditionally pass --with-kbd in sys-libs/libblockdev ebuilds since this option does not require any dependencies.
Comment 5 Martin Mokrejš 2019-05-14 08:38:09 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4)
> I suggest that "kbd" USE flag of media-video/vdr be renamed to
> "keyboard".

Fine.

> Renaming "kbd" USE flag of sys-libs/libblockdev to "kernel-block-device" or
> "kernel_block_device" might be a good idea.
> Another possibility is to unconditionally pass --with-kbd in
> sys-libs/libblockdev ebuilds since this option does not require any
> dependencies.

Either would be fine for me.
Comment 6 Larry the Git Cow gentoo-dev 2019-12-15 12:59:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=942e52300c8e525ae888c320524771517c3f585e

commit 942e52300c8e525ae888c320524771517c3f585e
Author:     Joerg Bornkessel <hd_brummy@gentoo.org>
AuthorDate: 2019-12-15 12:58:41 +0000
Commit:     Joerg Bornkessel <hd_brummy@gentoo.org>
CommitDate: 2019-12-15 12:59:33 +0000

    media-video/vdr: moved use flag
    
    moved use flag kbd to keyboard
    requested by wrt bug 685828
    
    Bug: https://bugs.gentoo.org/685828
    Package-Manager: Portage-2.3.81, Repoman-2.3.18
    Signed-off-by: Joerg Bornkessel <hd_brummy@gentoo.org>

 media-video/vdr/metadata.xml        |   1 +
 media-video/vdr/vdr-2.2.0-r5.ebuild | 301 ++++++++++++++++++++++++++++++++++++
 2 files changed, 302 insertions(+)