Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685718 - games-strategy/freeorion-0.4.8: fix boost support
Summary: games-strategy/freeorion-0.4.8: fix boost support
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal with 1 vote (vote)
Assignee: Adam Feldman
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-05-12 11:53 UTC by Oleg
Modified: 2020-02-12 19:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
https://github.com/freeorion/freeorion/pull/2443 (freeorion-0.4.8-boost-compat.patch,27.15 KB, patch)
2019-05-12 11:53 UTC, Oleg
Details | Diff
Fix for boost_python (2469.patch,1.85 KB, patch)
2019-06-09 16:21 UTC, Oleg
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg 2019-05-12 11:53:20 UTC
Created attachment 576168 [details, diff]
https://github.com/freeorion/freeorion/pull/2443

There packported into 0.4.8 release fix for newer boost version.

Upstream PR: https://github.com/freeorion/freeorion/pull/2443
Comment 1 Andreas Sturmlechner gentoo-dev 2019-05-12 12:03:53 UTC
Boost is fixed by 0.4.8_p20190501, what do you need this for?
Comment 2 Oleg 2019-05-12 12:18:40 UTC
Maybe uptsream's versioning scheme is misleading but 0.4.8+ is not 0.4.8. This patch is for freeorio-0.4.8.tar.gz
Comment 3 Andreas Sturmlechner gentoo-dev 2019-05-12 15:06:32 UTC
(In reply to Oleg from comment #2)
> Maybe uptsream's versioning scheme is misleading but 0.4.8+ is not 0.4.8.
> This patch is for freeorio-0.4.8.tar.gz

So the question is then what do you need 0.4.8 for.
Comment 4 Oleg 2019-05-12 15:25:31 UTC
(In reply to Andreas Sturmlechner from comment #3)
> (In reply to Oleg from comment #2)
> > Maybe uptsream's versioning scheme is misleading but 0.4.8+ is not 0.4.8.
> > This patch is for freeorio-0.4.8.tar.gz
> 
> So the question is then what do you need 0.4.8 for.

0.4.8 is the latest stable release: https://github.com/freeorion/freeorion/releases

It was accepted in most other distros: https://pkgs.org/download/freeorion

So I need 0.4.8 for multiplayer games which possible only between equals or bug-fix versions.
Comment 5 Oleg 2019-06-09 16:21:24 UTC
Created attachment 579328 [details, diff]
Fix for boost_python

Second patch for 0.4.8 https://github.com/freeorion/freeorion/pull/2469
Comment 6 corax 2019-09-02 13:04:04 UTC
Package freeorion-0.4.8_p20190501 failed today at the cmake stage because it could not find some boost_python dependency (sorry if vague, don't have log available)
I had successfully emerged it months ago (probably around 2019-05-01 if I were to guess) but since unmerged it again in the meantime.

Patching with attachment 579328 [details, diff] allowed cmake to succeed and build.
Comment 7 Michal Plichta 2019-09-02 17:14:13 UTC
(In reply to corax from comment #6)
> Package freeorion-0.4.8_p20190501 failed today at the cmake stage because it
> could not find some boost_python dependency (sorry if vague, don't have log
> available)
> I had successfully emerged it months ago (probably around 2019-05-01 if I
> were to guess) but since unmerged it again in the meantime.
> 
> Patching with attachment 579328 [details, diff] [details, diff] allowed cmake to succeed and
> build.

IMHO it could be caused by new cmake, I still have 3.9.6 and it works well.
Comment 8 Cyp 2020-01-15 13:50:36 UTC
Not sure whether this is the same bug, but with dev-libs/boost-1.72.0 and games-strategy/freeorion-0.4.8_p20190501 I get a few errors mentioning boost::gil::, such as this:

/var/tmp/portage/games-strategy/freeorion-0.4.8_p20190501/work/freeorion-2a49c05796f1c92b96ce9b2aeaf0124fc8be7a77/GG/src/Texture.cpp:290:22: error: ‘interleaved_view_get_raw_data’ was not declared in this scope; did you mean ‘boost::gil::interleaved_view_get_raw_data’?
Comment 9 Oleg 2020-01-16 17:50:26 UTC
(In reply to Cyp from comment #8)
> Not sure whether this is the same bug, but with dev-libs/boost-1.72.0 and
> games-strategy/freeorion-0.4.8_p20190501 I get a few errors mentioning
> boost::gil::, such as this:
> 
> /var/tmp/portage/games-strategy/freeorion-0.4.8_p20190501/work/freeorion-
> 2a49c05796f1c92b96ce9b2aeaf0124fc8be7a77/GG/src/Texture.cpp:290:22: error:
> ‘interleaved_view_get_raw_data’ was not declared in this scope; did you mean
> ‘boost::gil::interleaved_view_get_raw_data’?

It was fixed in https://github.com/freeorion/freeorion/pull/2644 and soon will be released as 0.4.9 stable.
Comment 10 Oleg 2020-02-12 19:42:58 UTC
Boost support was fixed in the latest stable release.