Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685138 - media-gfx/ufraw-0.22-r1 : dcraw_api.cc:692:13: error: ‘pixels’ not specified in enclosing ‘parallel’
Summary: media-gfx/ufraw-0.22-r1 : dcraw_api.cc:692:13: error: ‘pixels’ not specified ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard: openmp
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-05 21:17 UTC by Kobboi
Modified: 2019-10-27 10:09 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,24.97 KB, text/x-log)
2019-05-06 09:05 UTC, Kobboi
Details
ufraw-0.22-fix_omp_definitions.patch (ufraw-0.22-fix_omp_definitions.patch,1.17 KB, patch)
2019-06-30 16:31 UTC, Bob Wya
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2019-05-05 21:17:50 UTC
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I.  -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/uuid -I/usr/include/freetype2 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -I/usr/include/lensfun -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -I/usr/include/libpng16  -DDCRAW_NOMAIN -DUFRAW_LOCALEDIR=\"/usr/share/locale\"   -O2 -march=x86-64 -pipe -fomit-frame-pointer -g -ggdb -fopenmp -c -o dcraw_api.o dcraw_api.cc
dcraw_api.cc: In function ‘void dcraw_finalize_raw(dcraw_data*, dcraw_data*, int*)’:
dcraw_api.cc:692:13: error: ‘pixels’ not specified in enclosing ‘parallel’
  692 |             for (int i = 0; i < pixels; i++) {
      |             ^~~
dcraw_api.cc:689:21: error: enclosing ‘parallel’
  689 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
dcraw_api.cc:695:77: error: ‘black’ not specified in enclosing ‘parallel’
  695 |                     gint32 p = (gint64)(get_pixel(h, dark, i, cc, pixels) - black) *
      |                                                                             ^~~~~
dcraw_api.cc:689:21: error: enclosing ‘parallel’
  689 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
dcraw_api.cc:705:13: error: ‘pixels’ not specified in enclosing ‘parallel’
  705 |             for (int i = 0; i < pixels; i++) {
      |             ^~~
dcraw_api.cc:702:21: error: enclosing ‘parallel’
  702 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from uf_glib.h:20,
                 from dcraw_api.cc:27:
dcraw_api.cc:709:82: error: ‘black’ not specified in enclosing ‘parallel’
  709 |                                                   ((gint64)h->raw.image[i][cc] - black) *
      |                                                                                  ^~~~~
/usr/include/glib-2.0/glib/gmacros.h:336:23: note: in definition of macro ‘MIN’
  336 | #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
      |                       ^
dcraw_api.cc:708:47: note: in expansion of macro ‘MAX’
  708 |                     h->raw.image[i][cc] = MIN(MAX(
      |                                               ^~~
dcraw_api.cc:702:21: error: enclosing ‘parallel’
  702 |             #pragma omp parallel for schedule(static) default(none) \
      |                     ^~~
make[2]: *** [Makefile:924: dcraw_api.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/var/tmp/portage/media-gfx/ufraw-0.22-r2/work/ufraw-0.22'
make[1]: *** [Makefile:1060: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-gfx/ufraw-0.22-r2/work/ufraw-0.22'
make: *** [Makefile:610: all] Error 2
Comment 1 Kobboi 2019-05-05 21:18:41 UTC
Compiled fine on January 16, now using GCC 9.1
Comment 2 Kobboi 2019-05-05 21:29:15 UTC
See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925844
Comment 3 Kobboi 2019-05-06 09:05:56 UTC
Created attachment 575394 [details]
build.log
Comment 4 Fred Krogh 2019-05-07 15:15:59 UTC
Same problem here with gcc-9.1.0.
Comment 5 Bob Wya 2019-06-30 16:31:02 UTC
Created attachment 581558 [details, diff]
ufraw-0.22-fix_omp_definitions.patch

This patch fixes the OPENMP pragma omp definitions for: =media-gfx/ufraw-0.22-r1

Variables/constants defined outside the parallel blocks are copied into a private local variable, on the first entry to the parallel block.
Comment 6 Attila Tóth 2019-07-23 19:35:41 UTC
Patch works for me, thanks!
Comment 7 Larry the Git Cow gentoo-dev 2019-09-15 23:47:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12faa1f3969c1f632a6f939f46e4377c08c37fab

commit 12faa1f3969c1f632a6f939f46e4377c08c37fab
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-09-15 23:26:33 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-09-15 23:46:17 +0000

    media-gfx/ufraw: Fix build with gcc-9, EAPI-7 bump
    
    Thanks to openSUSE for the patch.
    
    Closes: https://bugs.gentoo.org/685138
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/ufraw/files/ufraw-0.22-gcc9.patch | 97 +++++++++++++++++++++++++++++
 media-gfx/ufraw/ufraw-0.22-r3.ebuild        | 96 ++++++++++++++++++++++++++++
 2 files changed, 193 insertions(+)