Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681734 - dev-util/electron: add LibreSSL support
Summary: dev-util/electron: add LibreSSL support
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: libressl-support
  Show dependency tree
 
Reported: 2019-03-25 13:51 UTC by Stefan Strogin
Modified: 2019-08-04 08:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Strogin gentoo-dev 2019-03-25 13:51:52 UTC
Since dev-util/electron-2.0.17 dependency on dev-libs/openssl was added to the ebuild.
electron builds successfully with LibreSSL-2.8.3 for me. Let us add USE=libressl.
Comment 1 Stefan Strogin gentoo-dev 2019-03-25 14:23:40 UTC
Oops. Disregard the last message. That was a mistake.

On my system with LibreSSL-2.8.3 it fails to build with:

../../vendor/node/src/node_crypto.cc:498:37: error: invalid conversion from ‘SSL_SESSION* (*)(SSL*, unsigned char*, int, int*)’ {aka ‘ssl_session_st* (*)(ssl_st*, unsigned char*, int, int*)’} to ‘SSL_SESSION* (*)(ssl_st*, const unsigned char*, int, int*)’ {aka ‘ssl_session_st* (*)(ssl_st*, const unsigned char*, int, int*)’} [-fpermissive]
   SSL_CTX_sess_set_get_cb(sc->ctx_, SSLWrap<Connection>::GetSessionCallback);
In file included from ../../vendor/node/src/node_crypto.h:39,
                 from ../../vendor/node/src/node_crypto.cc:25:
/usr/include/openssl/ssl.h:730:20: note:   initializing argument 2 of ‘void SSL_CTX_sess_set_get_cb(SSL_CTX*, SSL_SESSION* (*)(ssl_st*, const unsigned char*, int, int*))’
     SSL_SESSION *(*get_session_cb)(struct ssl_st *ssl,
     ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     const unsigned char *data, int len, int *copy));
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../vendor/node/src/node_crypto.cc: In function ‘int node::crypto::SSL_CTX_use_certificate_chain(SSL_CTX*, X509*, stack_st_X509*, X509**, X509**)’:
../../vendor/node/src/node_crypto.cc:615:11: error: ‘SSL_CTX_add1_chain_cert’ was not declared in this scope
       r = SSL_CTX_add1_chain_cert(ctx, ca);
           ^~~~~~~~~~~~~~~~~~~~~~~
../../vendor/node/src/node_crypto.cc:615:11: note: suggested alternative: ‘SSL_CTX_add_extra_chain_cert’
       r = SSL_CTX_add1_chain_cert(ctx, ca);
           ^~~~~~~~~~~~~~~~~~~~~~~
           SSL_CTX_add_extra_chain_cert
Comment 2 Stefan Strogin gentoo-dev 2019-03-25 14:32:25 UTC
So a patch is needed. Or a flag "(+)system-ssl".
Comment 3 Larry the Git Cow gentoo-dev 2019-04-06 18:50:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15d7dda048dd9cb11efd127fe4e2fbfce4812dd8

commit 15d7dda048dd9cb11efd127fe4e2fbfce4812dd8
Author:     Stefan Strogin <stefan.strogin@gmail.com>
AuthorDate: 2019-03-25 15:12:56 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-04-06 18:49:53 +0000

    dev-util/electron: add USE=+system-ssl
    
    For now disabling this is needed to build on systems with LibreSSL or
    OpenSSL 1.1.x.
    
    Bug: https://bugs.gentoo.org/681734
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/11494
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 .../{electron-2.0.17.ebuild => electron-2.0.17-r1.ebuild}         | 8 ++++----
 dev-util/electron/metadata.xml                                    | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)