Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681232 - mail-mta/sendmail: ignores build failures in compile phase, and other QA issues
Summary: mail-mta/sendmail: ignores build failures in compile phase, and other QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: forbidden-variable-use
  Show dependency tree
 
Reported: 2019-03-22 07:12 UTC by Michał Górny
Modified: 2021-06-01 09:44 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mail-mta:sendmail-8.14.9-r1:20190322-061803.log (mail-mta:sendmail-8.14.9-r1:20190322-061803.log,95.95 KB, text/plain)
2019-03-22 07:12 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-03-22 07:12:02 UTC
Created attachment 570290 [details]
mail-mta:sendmail-8.14.9-r1:20190322-061803.log

As seen in the attached log, sendmail ignores all build errors in src_compile(), and doesn't fail until src_install().

Also, the ebuild lacks a lot of '||die', and uses 'make' instead of 'emake'.
Comment 1 Larry the Git Cow gentoo-dev 2020-08-17 03:06:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c97bd0e2aa41d659ac1a5f39c241c2093c7f4241

commit c97bd0e2aa41d659ac1a5f39c241c2093c7f4241
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2020-08-17 02:52:02 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2020-08-17 03:06:40 +0000

    mail-mta/sendmail: bump to 8.16.1
    
    * Bump due to security issue
    * Add -D_FFR_TLS_EC to compile options which supports ECDHE and PFS
    * Stop building libmilter separately and introduce dep on
      mail-filter/libmilter
    * By depending on mail-filter/libmilter sendmail no longer installs
      static-libs.
    * Add -DMAXDAEMONS=64 to fix IPV6 environments
    * Fix various QA issues with lack of dies. More to be fixed.
    
    Bug: https://bugs.gentoo.org/730890
    Bug: https://bugs.gentoo.org/681232
    Closes: https://bugs.gentoo.org/542370
    Closes: https://bugs.gentoo.org/681224
    Closes: https://bugs.gentoo.org/724548
    Closes: https://bugs.gentoo.org/606490
    
    Acked-by: Sam James <sam@gentoo.org>
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 mail-mta/sendmail/Manifest                         |   1 +
 .../files/sendmail-8.14.6-build-system.patch       |  73 +-------
 mail-mta/sendmail/sendmail-8.16.1.ebuild           | 208 +++++++++++++++++++++
 3 files changed, 219 insertions(+), 63 deletions(-)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-10 01:12:37 UTC
We will resolve the rest as part of bug 730890.
Comment 3 Larry the Git Cow gentoo-dev 2021-06-01 09:44:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2bc8fa7f3b24750c97641e3e3301d9d7f4bd4df7

commit 2bc8fa7f3b24750c97641e3e3301d9d7f4bd4df7
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-01 09:35:01 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-01 09:43:55 +0000

    mail-mta/sendmail: tidy, use pkg-config, extra error checking
    
    || die was missing in several places (notably all here-documents),
    and direct "make" was likely used because emake needs -j1 like
    libmilter.
    
    Use pkg-config where possible, single-string -> sed -> m4 layout
    should ideally be replaced to handle potential use of spaces or
    other characters that this or *FLAGS may generate.
    
    Simplified most constructs for easier maintenance, sorted, and
    removed the unused multilib inherit. Avoided changes that may
    alter build or configuration files.
    
    Also added a note to bump together with libmilter.
    
    Closes: https://bugs.gentoo.org/681232
    Closes: https://github.com/gentoo/gentoo/pull/21069
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 mail-mta/sendmail/sendmail-8.16.1-r1.ebuild | 178 ++++++++++++++--------------
 1 file changed, 88 insertions(+), 90 deletions(-)