Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 68078 - portage ebuild: /var/tmp/ccache and ${PORTDIR}/distfiles hardcoded
Summary: portage ebuild: /var/tmp/ccache and ${PORTDIR}/distfiles hardcoded
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-18 16:21 UTC by Torsten Veller (RETIRED)
Modified: 2005-07-31 00:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Veller (RETIRED) gentoo-dev 2004-10-18 16:21:25 UTC
1)
portage-2.0.51_rc9.ebuild (l. 298-300):

    if has ccache $FEATURES && has userpriv $FEATURES; then
        chown -R portage:portage /var/tmp/ccache &>/dev/null
        chmod -R g+rws /var/tmp/ccache &>/dev/null

it doesn't work with userpriv in FEATURES and CCACHE_DIR set to a different directory, so
s|/var/tmp/ccache|${CCACHE_DIR:-/var/tmp/ccache}|

In the latest version CCACHE_DIR is set at this point. The expansion should not be needed.


2)
Then there is the check for the possible distfiles directories:
${ROOT}usr/portage/distfiles and ${ROOT}/${PORTDIR}/distfiles

I think it should be:
${ROOT}usr/portage/distfiles and ${ROOT}/${DISTDIR}

If DISTDIR is set in make.conf it can be different from the first two dirs. But ${ROOT}/${PORTDIR}/distfiles should never be needed, because if nothing is changed then DISTDIR=${ROOT}usr/porage/distfiles, if PORTDIR is changed in /etc/make.conf then DISTDIR is still ${ROOT}usr/portage/distfiles.
Comment 1 Jason Stubbs (RETIRED) gentoo-dev 2005-07-31 00:40:57 UTC
The portage ebuild no longer does this bad stuff.