Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678218 - sys-apps/portage-2.3.60: infinite lockfile recursion on sshfs
Summary: sys-apps/portage-2.3.60: infinite lockfile recursion on sshfs
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, REGRESSION
Depends on:
Blocks: 671498
  Show dependency tree
 
Reported: 2019-02-17 10:02 UTC by Zac Medico
Modified: 2019-02-28 23:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2019-02-17 10:02:37 UTC 
The hardlink code for bug 636798 fails on sshfs:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=16d3d31dbc971ce95d80d6ec0645d6ee92b6baa2
Comment 2 Larry the Git Cow gentoo-dev 2019-02-18 00:54:22 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=efd6e6de1e19117224e20690cf11c16105ce817b

commit efd6e6de1e19117224e20690cf11c16105ce817b
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-02-18 00:48:55 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-02-18 00:49:53 +0000

    sys-apps/portage: version bump to 2.3.61
    
     #677776 gnome2_icon_cache_update -> xdg_icon_cache_update
     #677800 Don't define a default for ACCEPT_LICENSE
     #678218 locks: handle sshfs hardlink inode numbers
     FL-6227 cpuinfo: use better available CPU calculation
    
    Bug: https://bugs.gentoo.org/671498
    Bug: https://bugs.gentoo.org/677776
    Bug: https://bugs.gentoo.org/677800
    Bug: https://bugs.gentoo.org/678218
    Package-Manager: Portage-2.3.61, Repoman-2.3.12
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-2.3.61.ebuild | 271 +++++++++++++++++++++++++++++++++
 2 files changed, 272 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2019-02-18 01:01:35 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=34532af167cff457c3cccda4ea4249a0bc26481a

commit 34532af167cff457c3cccda4ea4249a0bc26481a
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-02-17 22:44:29 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-02-17 23:02:48 +0000

    locks: handle sshfs hardlink inode numbers (bug 678218)
    
    Since hardlinks on sshfs do not have matching inode numbers, detect
    this behavior and use a simple stat call to detect if lock_path has
    been removed.
    
    Bug: https://bugs.gentoo.org/678218
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/locks.py | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
Comment 4 jannis 2019-02-19 21:52:44 UTC 
Fixed in sys-apps/portage-2.3.61 (I'm confirming that 2.3.61 works fine with DISTFILES over SSHFS). Thanks, that was fast!
Comment 5 Zac Medico gentoo-dev 2019-02-28 23:16:45 UTC 
(In reply to jannis from comment #4)
> Fixed in sys-apps/portage-2.3.61 (I'm confirming that 2.3.61 works fine with
> DISTFILES over SSHFS). Thanks, that was fast!

Thanks for confirmation!