Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676158 - [Tracker] Unify non-free/nonfree USE flag
Summary: [Tracker] Unify non-free/nonfree USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Licenses team
URL:
Whiteboard:
Keywords: Tracker
Depends on: 706634
Blocks:
  Show dependency tree
 
Reported: 2019-01-24 11:24 UTC by Hanno Böck
Modified: 2020-02-29 08:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2019-01-24 11:24:40 UTC
We have a few packages using the use flags non-free and nonfree to enable proprietary features:
media-tv/kodi nonfree
dev-embedded/sdcc non-free
games-misc/ponysay non-free

We should try to unify local use flags if they have the same meaning. I have no strong feeling which one to use, but given there are 2 uses of non-free and one of nonfree I propose going with the first.

CCing the maintainer of media-tv/kodi: Any objections if we change nonfree to non-free?
Comment 1 Craig Andrews gentoo-dev 2019-01-24 14:41:25 UTC
No objection from me.

Kodi 18 doesn't even have such a flag, so its days are numbered anyways.
Comment 2 Larry the Git Cow gentoo-dev 2020-01-07 23:15:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f0e7a72bdd75897993248ccd8bf8480148b7062

commit 1f0e7a72bdd75897993248ccd8bf8480148b7062
Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
AuthorDate: 2020-01-06 18:24:49 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-01-07 23:05:54 +0000

    games-fps/gzdoom: Version bump to 4.3.1
    
    The "nonfree" USE flag is renamed to "non-free". The "alsa",
    "fluidsynth", "mpg123", and "sndfile" USE flags are added to control
    support of their respective packages.
    
    Closes: https://bugs.gentoo.org/704880
    Bug: https://bugs.gentoo.org/676158
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/14272
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-fps/gzdoom/Manifest                          |  2 +-
 .../{gzdoom-4.2.4.ebuild => gzdoom-4.3.1.ebuild}   | 29 +++++++++++++---------
 games-fps/gzdoom/metadata.xml                      |  4 ++-
 3 files changed, 21 insertions(+), 14 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2020-01-25 12:04:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fbfab64bbbb23d9cf67ecd2f4094015e9b56a5aa

commit fbfab64bbbb23d9cf67ecd2f4094015e9b56a5aa
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2020-01-25 12:03:02 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-01-25 12:03:59 +0000

    games-fps/prboom-plus: Rename "nonfree" flag to "non-free".
    
    Bug: https://bugs.gentoo.org/676158
    Package-Manager: Portage-2.3.85, Repoman-2.3.20
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 games-fps/prboom-plus/metadata.xml               |  2 +-
 games-fps/prboom-plus/prboom-plus-2.5.1.4.ebuild | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 4 Ulrich Müller gentoo-dev 2020-02-29 08:23:35 UTC
All done. Closing.