Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675836 - net-libs/libhubbub-0.3.5-r1 : [TEST] test/tokeniser2.c:51:10: error: implicit declaration of function is_error
Summary: net-libs/libhubbub-0.3.5-r1 : [TEST] test/tokeniser2.c:51:10: error: implicit...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virgil Dupras (RETIRED)
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: werror 674736
  Show dependency tree
 
Reported: 2019-01-19 10:19 UTC by Toralf Förster
Modified: 2019-01-25 20:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.62 KB, text/plain)
2019-01-19 10:19 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,175.60 KB, text/plain)
2019-01-19 10:19 UTC, Toralf Förster
Details
environment (environment,50.62 KB, text/plain)
2019-01-19 10:19 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,21.29 KB, application/x-bzip)
2019-01-19 10:19 UTC, Toralf Förster
Details
net-libs:libhubbub-0.3.5-r1:20190119-002336.log (net-libs:libhubbub-0.3.5-r1:20190119-002336.log,30.51 KB, text/plain)
2019-01-19 10:19 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,15.64 KB, application/x-bzip)
2019-01-19 10:19 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-01-19 10:19:40 UTC
In file included from test/tokeniser2.c:15:
test/tokeniser2.c: In function ‘main’:
test/tokeniser2.c:51:10: error: implicit declaration of function ‘is_error’; did you mean ‘mc_error’? [-Werror=implicit-function-declaration]
  assert(!is_error(json));
          ^~~~~~~~
test/testutils.h:31:13: note: in definition of macro ‘assert’

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0_test_20190113-225948

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-8.2.0 *

Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.6
  [3]   python2.7 (fallback)
  [4]   pypy (fallback)

Available Rust versions:
  [1]   rust-1.31.1 *
  [2]   rust-bin-1.32.0



emerge -qpvO net-libs/libhubbub
[ebuild  N    ] net-libs/libhubbub-0.3.5-r1  USE="test -doc"
Comment 1 Toralf Förster gentoo-dev 2019-01-19 10:19:43 UTC
Created attachment 562128 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2019-01-19 10:19:45 UTC
Created attachment 562130 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2019-01-19 10:19:48 UTC
Created attachment 562132 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2019-01-19 10:19:51 UTC
Created attachment 562134 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2019-01-19 10:19:54 UTC
Created attachment 562136 [details]
net-libs:libhubbub-0.3.5-r1:20190119-002336.log
Comment 6 Toralf Förster gentoo-dev 2019-01-19 10:19:56 UTC
Created attachment 562138 [details]
temp.tbz2
Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-24 22:21:12 UTC
While this error at least hinting at real problem -Werror causes other failures on ppc64:

test/tokeniser3.c: In function 'main':                                                                                                                         
test/tokeniser3.c:49:10: error: implicit declaration of function 'is_error'; did you mean 'mc_error'? [-Werror=implicit-function-declaration]
  assert(!is_error(json));  
          ^~~~~~~~                                  
test/testutils.h:31:13: note: in definition of macro 'assert'                                                                                                  
   ((void) ((expr) || (__assert2 (#expr, __func__, __FILE__, __LINE__), 0)))
             ^~~~       
test/tokeniser3.c:49:10: error: nested extern declaration of 'is_error' [-Werror=nested-externs]
  assert(!is_error(json));                                                                        
          ^~~~~~~~
Comment 8 Virgil Dupras (RETIRED) gentoo-dev 2019-01-25 20:46:51 UTC
There are two problems here. First, the -Werror flag, but also, the undeclared is_error() macro, which is a regression from json-c's 0.13 release[1]

Fixing both.

[1]: https://github.com/json-c/json-c/issues/304
Comment 9 Larry the Git Cow gentoo-dev 2019-01-25 20:55:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09c796445b6028ac922090727d4eba85fca06e1e

commit 09c796445b6028ac922090727d4eba85fca06e1e
Author:     Virgil Dupras <vdupras@gentoo.org>
AuthorDate: 2019-01-25 20:53:46 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2019-01-25 20:55:05 +0000

    net-libs/libhubbub: fix test failure
    
    Closes: https://bugs.gentoo.org/675836
    Signed-off-by: Virgil Dupras <vdupras@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 net-libs/libhubbub/libhubbub-0.3.5-r1.ebuild | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)