Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673410 - media-video/motion-4.3.1 version bump
Summary: media-video/motion-4.3.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 665930
Blocks:
  Show dependency tree
 
Reported: 2018-12-19 06:23 UTC by William Breathitt Gray
Modified: 2020-06-04 07:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for motion-4.3.0 (motion-4.3.0.ebuild,2.30 KB, text/plain)
2020-04-18 16:16 UTC, Johannes Willem (Hans) Fernhout
Details
ebuild for motion-4.3.1 (motion-4.3.1.ebuild,2.30 KB, text/plain)
2020-04-18 16:17 UTC, Johannes Willem (Hans) Fernhout
Details
files/montion.confd-r4 (motion.confd-r4,455 bytes, text/plain)
2020-04-18 16:19 UTC, Johannes Willem (Hans) Fernhout
Details
files/init.d-r4 (motion.initd-r4,351 bytes, text/plain)
2020-04-18 16:20 UTC, Johannes Willem (Hans) Fernhout
Details
ebuild for motion 4.3.1 - updated for mysql/mariadb support (motion-4.3.1.ebuild,2.54 KB, text/plain)
2020-04-19 08:26 UTC, Johannes Willem (Hans) Fernhout
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William Breathitt Gray 2018-12-19 06:23:17 UTC
Version 4.2.1 of motion has been released: https://github.com/Motion-Project/motion/releases/tag/release-4.2.1
Comment 1 Thomas Albers 2019-05-28 15:57:43 UTC
The most recent release version is now 4.2.2: https://github.com/Motion-Project/motion/releases/tag/release-4.2.2
Comment 2 Johannes Willem (Hans) Fernhout 2020-04-13 18:47:08 UTC
The current version of motion contains important security improvements like
- webcontrol_auth_method and stream_auth_method for digest authentication
- webcontrol_tls and stream_tls to start SSL/TLS sessions
It'd be great to have the version 4.2 available in Gentoo
Comment 3 Johannes Willem (Hans) Fernhout 2020-04-18 16:16:02 UTC
Created attachment 633604 [details]
ebuild for motion-4.3.0

requires also files/motion.confd-r4 and files/motion.initd-r4
Comment 4 Johannes Willem (Hans) Fernhout 2020-04-18 16:17:50 UTC
Created attachment 633606 [details]
ebuild for motion-4.3.1

requires also files/motion.confd-r4 and files/motion.initd-r4
Comment 5 Johannes Willem (Hans) Fernhout 2020-04-18 16:19:28 UTC
Created attachment 633608 [details]
files/montion.confd-r4

conf.d file for ebuilds for motion-4.3.0 and motion-4.3.1
Comment 6 Johannes Willem (Hans) Fernhout 2020-04-18 16:20:31 UTC
Created attachment 633610 [details]
files/init.d-r4

init.d file for ebuilds for motion-4.3.0 and motion-4.3.1
Comment 7 Johannes Willem (Hans) Fernhout 2020-04-18 16:31:15 UTC
I have create ebuilds for motion version 4.3.0 and 4.3.1, also because version 4.2.2 did not compile with the mysql use flag.

I have implemented a few changes in these ebuilds:
1) marked as unstable with ~amd64 and ~x86 keywords
2) removed the patch for ffmpeg-4.0
3) disabled the creation of the motion user from the ebuild because there is no reserved userid for motion
4) remove use depends init file on mysql and postgres when the use flags are not enabled.
5) simplified the conf.d and init.d files

Please review and hopefully we can get these merged soon. Thanks.
Comment 8 William Breathitt Gray 2020-04-18 16:46:28 UTC
(In reply to hfern from comment #4)
> Created attachment 633606 [details]
> ebuild for motion-4.3.1
> 
> requires also files/motion.confd-r4 and files/motion.initd-r4

Hi hfern,

I noticed this ebuild still depends on virtual/mysql which is deprecated as mentioned in the Gentoo bugzilla issue #665930.

In addition, I think the Motion configure script might still be broken regarding proper detection of MariaDB: https://github.com/Motion-Project/motion/issues/875

I originally tried organizing a revamp of the configure.ac file: https://github.com/Motion-Project/motion/issues/955

But I've lost interest in the project since I no longer use it daily. Perhaps you can ping them and see if the MariaDB detection bug is still occurring; if not then you can replace the mysql dependency with mariadb instead.
Comment 9 Johannes Willem (Hans) Fernhout 2020-04-19 08:26:10 UTC
Created attachment 633662 [details]
ebuild for motion 4.3.1 - updated for mysql/mariadb support

Hi William, thanks for pointing this out.
It turns out that motion now supports building with mysql and/or mariadb support. This ebuild is updated to set the dependencies to the specific client packages. 

Note that the database_type in /etc/motion.conf has to match with the USE flag, either mysql or mariadb. The motion documentation at https://motion-project.github.io/motion_config.html#database_type does not list database_type mariadb yet though.
If the use flag and the database do not match then motion crashes with signal 6/SIGABRT.
Comment 10 William Breathitt Gray 2020-04-22 13:21:10 UTC
(In reply to hfern from comment #9)
> Created attachment 633662 [details]
> ebuild for motion 4.3.1 - updated for mysql/mariadb support
> 
> Hi William, thanks for pointing this out.
> It turns out that motion now supports building with mysql and/or mariadb
> support. This ebuild is updated to set the dependencies to the specific
> client packages. 
> 
> Note that the database_type in /etc/motion.conf has to match with the USE
> flag, either mysql or mariadb. The motion documentation at
> https://motion-project.github.io/motion_config.html#database_type does not
> list database_type mariadb yet though.
> If the use flag and the database do not match then motion crashes with
> signal 6/SIGABRT.

Thank you for taking the time to fix this. Submit your ebuild to the Gentoo Github repo as a Pull Request: https://github.com/gentoo/gentoo/

This will allow it to undergo some basic sanity checks by the bots. Make sure to add a Signed-off-by line in your commit message to indicate that you accept the Gentoo license agreement; also add a link to this bugzilla issue in that same commit message so the bot knows to automatically link to this page.
Comment 11 Johannes Willem (Hans) Fernhout 2020-04-25 11:55:08 UTC
I think I have created the pull request, but it's the first time I have done that, so please check if everything is in order. Thanks.
Comment 12 Larry the Git Cow gentoo-dev 2020-06-04 07:14:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58c1002e91e59ca9edba1a4781f3024b0dbdf99e

commit 58c1002e91e59ca9edba1a4781f3024b0dbdf99e
Author:     Hans Fernhout <hfern@fernhout.info>
AuthorDate: 2020-06-04 07:09:24 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-06-04 07:14:12 +0000

    media-video/motion: version bump to 4.3.1
    
    Summary of changes:
    - support new version 4.3.1
    - EAPI6 to EAPI7
    - GLEP81 support: user and group management via dedicated packages
    - untangled support for mariadb and mysql
    - remove libav
    - confd support for commandline options, umask and work dir
    - initd checkpre function to check existence of work dir and log dir
    - support for OpenRC's supervise-daemon via a local use flag
    - added myself as proxy-maintainer
    
    Closes: https://bugs.gentoo.org/665930
    Closes: https://bugs.gentoo.org/673410
    Closes: https://bugs.gentoo.org/717312
    Signed-off-by: Johannes Willem Fernhout <hfern@fernhout.info>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-video/motion/Manifest                |   1 +
 media-video/motion/files/motion.confd-r4   |  28 ++++++++
 media-video/motion/files/motion.initd-r4   |  30 +++++++++
 media-video/motion/files/motion.service    |   4 +-
 media-video/motion/files/motion.service-r4 |  26 ++++++++
 media-video/motion/metadata.xml            |  10 +++
 media-video/motion/motion-4.3.1.ebuild     | 104 +++++++++++++++++++++++++++++
 7 files changed, 201 insertions(+), 2 deletions(-)