Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671106 - media-libs/freeimage-3.18.0 version bump
Summary: media-libs/freeimage-3.18.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 2 votes (vote)
Assignee: Gentoo Games
URL: http://freeimage.sourceforge.net/news...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 671402
  Show dependency tree
 
Reported: 2018-11-13 21:22 UTC by Patrick Nicolas
Modified: 2019-11-25 22:35 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pr-10411-build.log (pr-10411-build.log,26.86 KB, text/plain)
2018-11-23 22:53 UTC, Jeff Kowalczyk
Details
pr-10411-emerge-info.txt (emerge-info.txt,6.63 KB, text/plain)
2018-11-23 22:55 UTC, Jeff Kowalczyk
Details
Raw patch for freeimage-3.18 (freeimage-3.18.0-raw.patch,432 bytes, patch)
2018-12-21 15:04 UTC, Bernd Feige
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Nicolas 2018-11-13 21:22:58 UTC
portage has version media-libs/freeimage-3.15.4-r1
Comment 1 Arnaud Vallette d'Osia 2018-11-18 07:37:35 UTC
Confirmed: portage version dates back to 2012. Could be great to bump it.
http://freeimage.sourceforge.net/changeslog.html
Comment 2 Arnaud Vallette d'Osia 2018-11-18 07:39:19 UTC
...as a side note, with gcc version 7.3.0 (Gentoo 7.3.0-r3 p1.4), it does not even build.
Comment 3 Arnaud Vallette d'Osia 2018-11-18 07:39:46 UTC
I mean version in portage does not build. Updated should.
Comment 4 Jeff Kowalczyk 2018-11-23 22:52:22 UTC
I attempted to build freeimage-3.18.0 on ~amd64 in my local overlay using the files from https://github.com/gentoo/gentoo/pull/10411 .

Errors included type delarations prefixed with OPJ_, where upstream may be using unprefixed.

Build log attached.
Comment 5 Jeff Kowalczyk 2018-11-23 22:53:49 UTC
Created attachment 556080 [details]
pr-10411-build.log

Build errors when manually adding files from PR 10411 to local overlay on ~amd64
Comment 6 Jeff Kowalczyk 2018-11-23 22:55:06 UTC
Created attachment 556082 [details]
pr-10411-emerge-info.txt

emerge --info for ~amd64 build errors on PR 10411.
Comment 7 Patrick Nicolas 2018-11-24 12:27:49 UTC
Updated the pull request with 2 fixes: use openjp2 in pkg-config instead of openjpeg, and fix cflags for libwebp
Comment 8 Jeff Kowalczyk 2018-11-25 23:03:03 UTC
Thanks, I was able to emerge media-libs/freeimage-3.18.0 with the updated PR.
Comment 9 Bernd Feige 2018-12-21 15:04:22 UTC
Created attachment 558314 [details, diff]
Raw patch for freeimage-3.18

Thanks, this also fixes compilation against media-libs/openexr-2.3.0!

One issue remains: With +raw we need the "raw" patch again, which I attach in the correct form for 3.18.
Comment 10 Arnaud Vallette d'Osia 2019-01-13 08:17:27 UTC
Thanks guys! ...So we're all cleared now?
Comment 11 Patrick Nicolas 2019-01-13 09:41:03 UTC
I have updated the merge request with the patch for raw.
Comment 12 Arnaud Vallette d'Osia 2019-03-21 18:04:12 UTC
any news on this ?
Comment 13 Kobboi 2019-03-24 21:27:07 UTC
Might help us get rid of https://bugs.gentoo.org/show_bug.cgi?id=663614
Comment 14 Bernardo Meurer 2019-04-14 06:04:19 UTC
Updates on this?
Comment 15 Larry the Git Cow gentoo-dev 2019-04-14 12:44:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b0e97797339cd968083a5da4829db5d6c81e619

commit 3b0e97797339cd968083a5da4829db5d6c81e619
Author:     Patrick Nicolas <patricknicolas@laposte.net>
AuthorDate: 2018-11-13 21:11:07 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-04-14 12:44:08 +0000

    media-libs/freeimage: version bump to 3.18.0
    
    Bug: https://bugs.gentoo.org/671106
    Signed-off-by: Patrick Nicolas <patricknicolas@laposte.net>
    
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Closes: https://github.com/gentoo/gentoo/pull/10411
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 media-libs/freeimage/Manifest                      |   2 +
 .../files/freeimage-3.18.0-disable-plugin-G3.patch |  56 ++
 .../freeimage/files/freeimage-3.18.0-raw.patch     |  15 +
 .../freeimage-3.18.0-remove-jpeg-transform.patch   |  82 +++
 ...image-3.18.0-rename-jpeg_read_icc_profile.patch |  34 +
 .../files/freeimage-3.18.0-unbundling.patch        | 724 +++++++++++++++++++++
 media-libs/freeimage/freeimage-3.18.0.ebuild       | 116 ++++
 7 files changed, 1029 insertions(+)
Comment 16 James Le Cuirot gentoo-dev 2019-04-22 22:09:15 UTC
I've been told the unbundling patch from this bump is incomplete. If you link against freeimage then you get undefined references unless it was built with USE=-webp. I have verified this much for myself but haven't had a chance to look further. Would any of you be kind enough to provide a new patch?