>=media-video/mpv-0.28.2 unmask now
monsieurp@gentoo.org added the mask, here it is: --- # Patrice Clement <monsieurp@gentoo.org> (18 Jan 2018) # mpv >= 0.28.0 requires currently masked ffmpeg >= 4.0. >=media-video/mpv-0.28.0 ---
I spoke with monsieurp recently on IRC and he's ok to remove the mask. But there is come trickiness involved. Currently testing it with github CI here https://github.com/gentoo/gentoo/pull/10398 as repoman screams at me ['>=media-video/ffmpeg-4.0:0=[encode?,threads,vaapi?,vdpau?]'] I guess it's something with [encode] deps, as I ruled out vaapi and vdpau.
I was a bit sleepy. mpv>=0.28 needs dropping alpha, ppc and ppc64 keywords to be unmasked as ffmpeg is not keyworded on those arches yet. see https://bugs.gentoo.org/653676
(In reply to Georgy Yakovlev from comment #3) > I was a bit sleepy. > mpv>=0.28 needs dropping alpha, ppc and ppc64 keywords to be unmasked as > ffmpeg is not keyworded on those arches yet. see > https://bugs.gentoo.org/653676 I suggest we do that. A keyword request bug can be created for those archs once the mask is removed.
(In reply to Craig Andrews from comment #4) > (In reply to Georgy Yakovlev from comment #3) > > I was a bit sleepy. > > mpv>=0.28 needs dropping alpha, ppc and ppc64 keywords to be unmasked as > > ffmpeg is not keyworded on those arches yet. see > > https://bugs.gentoo.org/653676 > > I suggest we do that. A keyword request bug can be created for those archs > once the mask is removed. Please don't do that. Rekeywording on minor arches is slow. Instead we can unmask recent mpv on amd64 and x86. Will do it on weekend.
(In reply to Coacher from comment #5) d request bug can be created for those archs > > once the mask is removed. > Please don't do that. Rekeywording on minor arches is slow. > Instead we can unmask recent mpv on amd64 and x86. Will do it on weekend. That's not how this is handled. Dropping keywords and rekeywording bugs is precisely how this is handled. In this case probably added to the same bug as ffmpeg-4 re-keywording itself. You can't unmask a profiles/package.mask entry per-arch, only profiles/base/package.mask or similar entries.
Additionally doing only amd64/x86 would mean the problem (that this bug is about) remains for arm, ia64, ppc, ppc64 and more.
Sorry for further spam; I realized right after the previous one, that this isn't much of a big problem, as old mpv works fine with ffmpeg-4 too, just newer (with new mpv features) requires it. Either way, this should be properly handled with dropped keywords and just arranging the re-keywording of mpv to be together with ffmpeg-4 on the same bug, as stated above.
While I understand keywording pain on less popular arches I'm also for dropping keywords for now. PR https://github.com/gentoo/gentoo/pull/10398 is here, I can commit it anytime. Let me know. We still have stable-keyworded mpv-0.27 that works and it'll take some time to drop it.
(In reply to Georgy Yakovlev from comment #9) > While I understand keywording pain on less popular arches I'm also for > dropping keywords for now. > > PR https://github.com/gentoo/gentoo/pull/10398 is here, I can commit it > anytime. Let me know. > > We still have stable-keyworded mpv-0.27 that works and it'll take some time > to drop it. Well, if you can commit it, just do it. mpv 2.28 is ~1 year old and 2.29 is out since months. ffmpeg-4.0 being unmasked since more than a month, it's more than time. For minor arches, since the package is masked anyway, unkewording it will not be an issue, and for amd64 (vast majority of users) this will be a great thing.
since ppc and ppc64 were added to ffmpeg I'm going to push it now. we are losing alpha and arm64 was lost before that already.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2375f598a724cb60969938ced5097cfd2356085 commit e2375f598a724cb60969938ced5097cfd2356085 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2018-11-07 08:47:15 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2018-12-16 00:53:26 +0000 profiles/package.mask: unmask mpv >=0.28 Since ffmpeg-4 is unmasked. Closes: https://bugs.gentoo.org/670618 Acked-by: Patrice Clement <monsieurp@gentoo.org> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> profiles/package.mask | 4 ---- 1 file changed, 4 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c3a4586d6a98ce2ab37ebb4291c9d14475cc835 commit 4c3a4586d6a98ce2ab37ebb4291c9d14475cc835 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2018-11-12 06:20:32 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2018-12-16 00:53:26 +0000 arch/x86/package.use.mask: remove vulkan unmask for mpv vulkan-loader is not x86 keyworded but should work feel free to file keywording request Bug: https://bugs.gentoo.org/670618 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> profiles/arch/x86/package.use.mask | 5 ----- 1 file changed, 5 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee132d13ba58db007538e2201581690de8819dbb commit ee132d13ba58db007538e2201581690de8819dbb Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2018-12-16 00:33:54 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2018-12-16 00:53:25 +0000 media-video/mpv: drop alpha keyword for 0.29.1 Bug: https://bugs.gentoo.org/670618 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> media-video/mpv/mpv-0.29.1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66efd8fa6adcf4bdea42b764e497c3a0c32cef8b commit 66efd8fa6adcf4bdea42b764e497c3a0c32cef8b Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2018-12-16 00:32:04 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2018-12-16 00:53:25 +0000 media-video/mpv: drop alpha keyword for 0.28.2 Bug: https://bugs.gentoo.org/670618 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> media-video/mpv/mpv-0.28.2.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Where is the rekeywording bug?
