Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 668522 - sys-apps/fwupd should support sys-auth/elogind (!systemd should not pull in consolekit)
Summary: sys-apps/fwupd should support sys-auth/elogind (!systemd should not pull in c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: https://github.com/hughsie/fwupd/issu...
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: elogind-support
  Show dependency tree
 
Reported: 2018-10-13 17:54 UTC by Andreas Sturmlechner
Modified: 2019-02-25 14:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2018-10-13 17:54:37 UTC 
It seems like all we would need is a patch to the build system to alternatively accept elogind. HAVE_SYSTEMD should probably be renamed to HAVE_LOGIND in case the future brings further systemd support.
Comment 1 vltg0903 2018-11-09 17:38:58 UTC 
Alternatively, one could just add a consolekit USE flag, no matter whether logind is supported or not (not everyone is breaking out in hives at the thought of logging in as root).
Comment 2 Andreas Sturmlechner gentoo-dev 2018-11-10 12:45:37 UTC 
That's not how this works.
Comment 3 Andreas Sturmlechner gentoo-dev 2019-02-25 10:16:30 UTC 
Done upstream: https://github.com/hughsie/fwupd/pull/1040
Comment 4 Larry the Git Cow gentoo-dev 2019-02-25 12:01:33 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf627d629f87b6bb450c3d435b10176f3a653126

commit bf627d629f87b6bb450c3d435b10176f3a653126
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-02-25 10:57:21 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-02-25 12:01:18 +0000

    sys-apps/fwupd: Add USE elogind
    
    Closes: https://bugs.gentoo.org/668522
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 sys-apps/fwupd/files/fwupd-1.2.4-elogind.patch | 105 ++++++++++++++++++++
 sys-apps/fwupd/fwupd-1.2.4-r2.ebuild           | 132 +++++++++++++++++++++++++
 sys-apps/fwupd/metadata.xml                    |   3 +-
 3 files changed, 239 insertions(+), 1 deletion(-)
Comment 5 Joakim Tjernlund 2019-02-25 12:48:12 UTC 
This should have been added to fwupd-1.2.5 which was released just before adding
elogind support.
Comment 6 Andreas Sturmlechner gentoo-dev 2019-02-25 12:58:55 UTC 
Please open a separate bug regarding a version bump, it is not in the scope of this bug.
Comment 7 Joakim Tjernlund 2019-02-25 14:03:29 UTC 
Done, see
https://bugs.gentoo.org/678748