Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667164 - media-sound/denemo-2.2.0 Request to re-add
Summary: media-sound/denemo-2.2.0 Request to re-add
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2018-09-27 15:52 UTC by Bernd
Modified: 2018-10-11 20:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd 2018-09-27 15:52:56 UTC
I'd like to ask, to re-add media-sound/denemo-2.2.0 into the official tree.

I prepared a PR (https://github.com/gentoo/gentoo/pull/9908) and reworked the ebuild to remove old guile-1* dependencies and also fixed the portaudio related bug.
Comment 1 Andreas Sturmlechner gentoo-dev 2018-09-29 09:32:09 UTC
Might make sense to lookup for what reason it was removed(?) from tree in the first place and if that is valid anymore.

Would you be prepared to proxy-maintain this package?
Comment 2 Bernd 2018-09-29 12:15:39 UTC
According to https://github.com/gentoo/gentoo/pull/6241#issuecomment-376341031 the reason was it's dependency on old guile-1*. This dependency has been removed from the ebuild. It now only supports guile-2*.

Yes, I'm prepared to proxy-maintain the package.
Comment 3 Larry the Git Cow gentoo-dev 2018-10-11 20:49:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aeb045d44b3343ffcd5105982256983e6f14cc5a

commit aeb045d44b3343ffcd5105982256983e6f14cc5a
Author:     Bernd Waibel <waebbl@gmail.com>
AuthorDate: 2018-09-18 22:37:58 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-10-11 20:49:17 +0000

    media-sound/denemo: re-add package
    
    * remove optional usage of guile-1, package now only supports guile-2
    * fix problem with portaudio if use flag is not set
    see https://bugs.gentoo.org/515888#c23
    and https://savannah.gnu.org/bugs/?52741 with
    https://savannah.gnu.org/bugs/?53804
    * add REQUIRED_USE dependency for evince on gtk+:3
    
    Suggested-by: Nikita Zlobin <nick87720z@gmail.com>
    Closes: https://bugs.gentoo.org/667164
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    Signed-off-by: Bernd Waibel <waebbl@gmail.com>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/9908

 media-sound/denemo/Manifest                        |   1 +
 media-sound/denemo/denemo-2.2.0.ebuild             | 127 +++++++++++++++++++++
 .../denemo/files/denemo-2.2.0-find-guile-2.2.patch |  60 ++++++++++
 .../files/denemo-2.2.0-no-portaudio-fix.patch      |  29 +++++
 media-sound/denemo/metadata.xml                    |  53 +++++++++
 5 files changed, 270 insertions(+)