Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667008 - portage-2.3.50: ecompress creates useless empty files when PORTAGE_COMPRESS=""
Summary: portage-2.3.50: ecompress creates useless empty files when PORTAGE_COMPRESS=""
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: REGRESSION
Depends on:
Blocks: 666956
  Show dependency tree
 
Reported: 2018-09-24 19:33 UTC by Mira Ressel
Modified: 2018-09-24 20:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mira Ressel 2018-09-24 19:33:04 UTC
On my system, manpage compression is disabled via PORTAGE_COMPRESS="".

The new ecompress implementation in 2.3.50 creates empty files a la "/path/to/manpage.ecompress". Glancing at the code, there seems to be code which is supposed to delete those files, but it apparently doesn't work.

The uncompressed original files aren't deleted though, so this is mostly a cosmetic issue.
Comment 1 Larry the Git Cow gentoo-dev 2018-09-24 20:24:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=fbc100e6880291ea18cfcf8aa0a40c4d921dceaf

commit fbc100e6880291ea18cfcf8aa0a40c4d921dceaf
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-09-24 20:22:20 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-09-24 20:24:03 +0000

    ecompress: delete *.ecompress for empty PORTAGE_COMPRESS (bug 667008)
    
    Fixes: aa0a94198794 ("ecompress: Replace with implementation from portage[mgorny]")
    Bug: https://bugs.gentoo.org/667008
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/ecompress | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 2 Larry the Git Cow gentoo-dev 2018-09-24 20:35:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5aeb5785d20440e0ecd0e80e24209a2c4058ad29

commit 5aeb5785d20440e0ecd0e80e24209a2c4058ad29
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-09-24 20:33:57 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-09-24 20:35:33 +0000

    sys-apps/portage: 2.3.50-r1 revbump for bug 667008
    
    Closes: https://bugs.gentoo.org/667008
    Package-Manager: Portage-2.3.50, Repoman-2.3.10
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/{portage-2.3.50.ebuild => portage-2.3.50-r1.ebuild} | 3 +++
 1 file changed, 3 insertions(+)