Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665748 - dev-util/drone-0.8.6: drone-server won't start because environment variables are not passed on
Summary: dev-util/drone-0.8.6: drone-server won't start because environment variables ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-12 02:09 UTC by tastytea
Modified: 2023-08-09 17:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tastytea 2018-09-12 02:09:28 UTC
The variables from /etc/conf.d/drone-server are not passed on to the drone-server.

Reproducible: Always

Steps to Reproduce:
1. Configure drone-server in /etc/conf.d/drone-server
2. Run /etc/init.d/drone-server start
3. Read /var/log/drone-server/drone-server.log
Actual Results:  
drone-server didn't start, logfile reads:
[…] level=fatal msg="DRONE_HOST is not properly configured"

Expected Results:  
drone-server starts, configured with the variables in /etc/conf.d/drone-server.
Comment 1 David Roman 2018-12-31 17:56:42 UTC
(In reply to tastytea from comment #0)
> The variables from /etc/conf.d/drone-server are not passed on to the
> drone-server.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Configure drone-server in /etc/conf.d/drone-server
> 2. Run /etc/init.d/drone-server start
> 3. Read /var/log/drone-server/drone-server.log
> Actual Results:  
> drone-server didn't start, logfile reads:
> […] level=fatal msg="DRONE_HOST is not properly configured"
> 
> Expected Results:  
> drone-server starts, configured with the variables in
> /etc/conf.d/drone-server.

I have the same bug. Is there a patch available?
Comment 2 tastytea 2018-12-31 23:07:12 UTC
(In reply to David from comment #1)
> I have the same bug. Is there a patch available?

The only solution I have found is to pass each and every variable to start-stop-daemon, with -e DRONE_HOST="${DRONE_HOST}" -e DRONE_SECRET="${DRONE_SECRET}" and so on.
Comment 3 Larry the Git Cow gentoo-dev 2023-08-09 17:47:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5b240ddba057505444ea9c5de375a5f5c232335

commit f5b240ddba057505444ea9c5de375a5f5c232335
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2023-08-09 17:41:58 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2023-08-09 17:45:37 +0000

    dev-util/drone: add 2.18.0
    
    Closes: https://bugs.gentoo.org/665748
    Closes: https://bugs.gentoo.org/842030
    Closes: https://github.com/gentoo/gentoo/pull/29817
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 dev-util/drone/Manifest                   |  2 +
 dev-util/drone/drone-2.18.0.ebuild        | 36 ++++++++++++++
 dev-util/drone/files/drone-server.conf    | 81 +++++++++++++++++++++++++++++++
 dev-util/drone/files/drone-server.confd   | 47 ------------------
 dev-util/drone/files/drone-server.initd   | 19 ++++++--
 dev-util/drone/files/drone-server.service | 25 ++++++++++
 6 files changed, 159 insertions(+), 51 deletions(-)