Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662788 - media-video/mkvtoolnix fails to compile with clang due to gcc only check in ebuild
Summary: media-video/mkvtoolnix fails to compile with clang due to gcc only check in e...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: media-video herd
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-08-04 17:43 UTC by David Carlos Manuelda
Modified: 2019-09-15 11:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Carlos Manuelda 2018-08-04 17:43:23 UTC
I am testing clang for system compiler and found out that mkvtoolnix dies src_prepare because it is expecting a equal or greater version of gcc to support c++11 features which clang also have.

This can be fixed with a simple line replace in the gcc version checking:

-	if ! version_is_at_least ${ver} $(gcc-version); then
+	if tc-is-gcc && [ ! version_is_at_least ${ver} $(gcc-version) ]; then
Comment 1 Pacho Ramos gentoo-dev 2019-06-30 12:17:24 UTC
why not simply:
if ! test-flag-CXX -std=c++11 ; then
?
Comment 2 Larry the Git Cow gentoo-dev 2019-09-15 11:36:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1d52f4db6dc9837c834ac676b602142e83a3ced

commit a1d52f4db6dc9837c834ac676b602142e83a3ced
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2019-09-15 11:36:06 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-09-15 11:36:06 +0000

    media-video/mkvtoolnix: Version bump to 37.0.0
    
    * Remove C++ compiler check for ancient versions of GCC
    
    Bug: https://bugs.gentoo.org/662788
    Bug: https://bugs.gentoo.org/692322
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: David Seifert <soap@gentoo.org>

 media-video/mkvtoolnix/Manifest                 |   1 +
 media-video/mkvtoolnix/mkvtoolnix-37.0.0.ebuild | 118 ++++++++++++++++++++++++
 2 files changed, 119 insertions(+)