Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 660726 - www-client/firefox-61.0-r1- extensions/spellcheck/hunspell/glue/mozHunspellFileMgr.h:42:3: error: 'nsCOMPtr' does not name a type
Summary: www-client/firefox-61.0-r1- extensions/spellcheck/hunspell/glue/mozHunspellF...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2018-07-08 18:04 UTC by Dudu Edri
Modified: 2018-07-08 22:08 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info output (emerge-info,5.78 KB, text/plain)
2018-07-08 18:08 UTC, Dudu Edri
Details
end of build.log (build-sample.log,11.02 KB, text/x-log)
2018-07-08 18:11 UTC, Dudu Edri
Details
full build log compressed (build.log.tar.gz,222.52 KB, application/gzip)
2018-07-08 18:31 UTC, Dudu Edri
Details
firefox-61.0-hunspell.patch (hunspell.patch,6.96 KB, patch)
2018-07-08 19:47 UTC, nvinson234
Details | Diff
firefox-61.0-hunspell.patch (nsCOMPtr.h.patch,527 bytes, patch)
2018-07-08 19:59 UTC, nvinson234
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dudu Edri 2018-07-08 18:04:35 UTC
www-client/firefox-61.0-r1::gentoo compilation fails with the following error:

 * ERROR: www-client/firefox-61.0-r1::gentoo failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 124:  Called src_compile
 *   environment, line 5096:  Called die
 * The specific snippet of code:
 *       MOZ_MAKE_FLAGS="${MAKEOPTS}" SHELL="${SHELL:-${EPREFIX}/bin/bash}" MOZ_NOSPAM=1 ./mach build --verbose || die

emerge --info and build.log with the full build info are attached.
Comment 1 Dudu Edri 2018-07-08 18:08:48 UTC
Created attachment 538832 [details]
emerge --info output
Comment 2 Dudu Edri 2018-07-08 18:11:49 UTC
Created attachment 538834 [details]
end of build.log

The entire build.log is big (5MB) so I couldn't attach it. The ending of build.log with the error message and some preceding info is attached.
Comment 3 Coacher 2018-07-08 18:21:32 UTC
(In reply to Dudu Edri from comment #2)
> Created attachment 538834 [details]
> end of build.log
> 
> The entire build.log is big (5MB) so I couldn't attach it. The ending of
> build.log with the error message and some preceding info is attached.

Compress, then attach.
Comment 4 Wendy 2018-07-08 18:29:26 UTC
33:59.70 /usr/bin/x86_64-pc-linux-gnu-g++ -o Unified_cpp_hunspell_src0.o -c -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/dist/stl_wrappers -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/dist/system_wrappers -include /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DHUNSPELL_STATIC -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/src -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/extensions/spellcheck/hunspell/src -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/glue -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/ipc/ipdl/_ipdlheaders -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ipc/chromium/src -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ipc/glue -I/var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/dist/include -I/usr/include/nspr -I/usr/include/nss -I/usr/include/pixman-1 -fPIC -DMOZILLA_CLIENT -include /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++1z-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-security -Wformat-overflow=2 -fno-sized-deallocation -march=native -pipe -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns -fno-schedule-insns2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -O2 -fomit-frame-pointer  -MD -MP -MF .deps/Unified_cpp_hunspell_src0.o.pp  -fdiagnostics-color  /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/extensions/spellcheck/hunspell/src/Unified_cpp_hunspell_src0.cpp
34:00.39 In file included from /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/src/filemgr.hxx:75:0,
34:00.39                  from /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/src/hashmgr.hxx:79,
34:00.39                  from /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/src/affixmgr.hxx:81,
34:00.39                  from /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/src/affentry.hxx:76,
34:00.39                  from /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/src/affentry.cxx:76,
34:00.39                  from /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/ff/extensions/spellcheck/hunspell/src/Unified_cpp_hunspell_src0.cpp:2:
34:00.39 /var/tmp/portage/www-client/firefox-61.0-r1/work/firefox-61.0/extensions/spellcheck/hunspell/glue/mozHunspellFileMgr.h:42:3: error: 'nsCOMPtr' does not name a type
34:00.39    nsCOMPtr<nsIInputStream> mStream;
Comment 5 Dudu Edri 2018-07-08 18:31:53 UTC
Created attachment 538850 [details]
full build log compressed
Comment 6 nvinson234 2018-07-08 19:47:36 UTC
Created attachment 538854 [details, diff]
firefox-61.0-hunspell.patch

Patch adds an include for nsCOMPtr.h to firefox-61.0/extensions/spellcheck/hunspell/glue/mozHunspellFileMgr.h.
Comment 7 tt_1 2018-07-08 19:56:27 UTC
Can you please reattach the patch as a patch file and not html?
Comment 8 nvinson234 2018-07-08 19:59:40 UTC
Created attachment 538858 [details, diff]
firefox-61.0-hunspell.patch

made an error in first upload.  This is the actual patch.
Comment 9 Georgy Yakovlev archtester gentoo-dev 2018-07-08 20:21:10 UTC
confirming build failure.
now testing the patch.
Comment 10 maxi_kroeg 2018-07-08 20:34:35 UTC
I can confirm this error.

And I can confirm that nvinson234's patch fixes it.
Comment 11 Georgy Yakovlev archtester gentoo-dev 2018-07-08 21:04:42 UTC
yup, patch worked.
and spellcheck works as well.
Comment 12 Mike Auty (RETIRED) gentoo-dev 2018-07-08 22:00:50 UTC
This issue also seems to be present in the firefox-61.0.1 release (see bug 660730), but the above patch doesn't apply cleanly.
Comment 13 Jory A. Pratt gentoo-dev 2018-07-08 22:05:49 UTC
(In reply to nvinson234 from comment #8)
> Created attachment 538858 [details, diff] [details, diff]
> firefox-61.0-hunspell.patch
> 
> made an error in first upload.  This is the actual patch.

I have pushed the patch, refer to how mozilla project creates patches. We must have a way to track author and need it signed off please.

(In reply to Mike Auty from comment #12)
> This issue also seems to be present in the firefox-61.0.1 release (see bug
> 660730), but the above patch doesn't apply cleanly.

We will not push 61.0.1.
Comment 14 Mike Auty (RETIRED) gentoo-dev 2018-07-08 22:08:37 UTC
My bad, the patch applies to 61.0.1 too (I didn't get a clean copy of the patch first time around).