Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659228 - 10ignored-flags QA check doesn't work with EAPI7
Summary: 10ignored-flags QA check doesn't work with EAPI7
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 659322
  Show dependency tree
 
Reported: 2018-06-26 10:59 UTC by Thomas Deutschmann (RETIRED)
Modified: 2018-10-12 19:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-26 10:59:05 UTC
It looks like "install-qa-check.d/10ignored-flags" isn't compatible with EAPI7:

See "app-arch/rar/rar-5.5.0_p20170811.ebuild" which is an EAPI6 ebuild. It has set "QA_FLAGS_IGNORED" to ignore shipped pre-compiled binaries which the ebuild installs in "/opt/rar/*" like "/opt/bin/rar". This works fine, you don't get a QA warning regarding installation of pre-stripped files or files which don't respect CFLAGS.

When you just bump EAPI to EAPI7, this won't work anymore. You will now get warnings like

> * QA Notice: Files built without respecting CFLAGS have been detected
> *  Please include the following list of files in your report:
> * //opt/rar/rar
> * //opt/rar/default.sfx
> * //opt/rar/unrar

(Notice the double slash in front of the path!)

I can make this work when I change

> --- a/rar-5.6.0_p20180624.ebuild  2018-06-26 12:56:02.029579808 +0200
> +++ b/rar-5.6.0_p20180624.ebuild  2018-06-26 12:56:16.420364509 +0200
> @@ -27,17 +27,17 @@
> 
>  S="${WORKDIR}/${PN}"
> 
> -QA_FLAGS_IGNORED="opt/rar/default.sfx
> -       opt/rar/default-elf32.sfx
> -       opt/rar/default-elf64.sfx
> -       opt/rar/default-win32.sfx
> -       opt/rar/default-win64.sfx
> -       opt/rar/WinCon.SFX
> -       opt/rar/WinCon64.SFX
> -       opt/rar/Zip.SFX
> -       opt/rar/Zip64.SFX
> -       opt/rar/unrar
> -       opt/rar/rar"
> +QA_FLAGS_IGNORED="//opt/rar/default.sfx
> +       //opt/rar/default-elf32.sfx
> +       //opt/rar/default-elf64.sfx
> +       //opt/rar/default-win32.sfx
> +       //opt/rar/default-win64.sfx
> +       //opt/rar/WinCon.SFX
> +       //opt/rar/WinCon64.SFX
> +       //opt/rar/Zip.SFX
> +       //opt/rar/Zip64.SFX
> +       //opt/rar/unrar
> +       //opt/rar/rar"
>  QA_PRESTRIPPED=${QA_FLAGS_IGNORED}
> 
>  src_unpack() {

...which looks wrong and will result in

> * QA Notice: Pre-stripped files found:
> * /opt/rar/rar
> * /opt/rar/default.sfx
> * /opt/rar/unrar
Comment 1 Zac Medico gentoo-dev 2018-06-27 02:53:07 UTC
This patch will fix all cases where the scanelf %p format string is used:

https://github.com/gentoo/portage/pull/330
https://archives.gentoo.org/gentoo-portage-dev/message/d399194bf8b779cc5b4d6056b028a850
Comment 2 Larry the Git Cow gentoo-dev 2018-06-27 04:30:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=b7852258f4366d1da16859bbfe3ca78ceabb53c7

commit b7852258f4366d1da16859bbfe3ca78ceabb53c7
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-06-27 02:37:43 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-06-27 04:26:28 +0000

    scanelf: fix %p format string for EAPI 7 (bug 659228)
    
    For all scanelf path arguments that are used in processing of
    the %p format string, normalize the argument to have a trailing
    slash, so that the leading slash is consistently stripped in
    the expansion of the %p format string.
    
    Bug: https://bugs.gentoo.org/659228

 bin/install-qa-check.d/10executable-issues | 4 ++--
 bin/install-qa-check.d/10ignored-flags     | 6 +++---
 bin/misc-functions.sh                      | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)