Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658902 - net-voip/telepathy-gabble-0.18.4 fails to build with >=dev-libs/openssl-1.1.0
Summary: net-voip/telepathy-gabble-0.18.4 fails to build with >=dev-libs/openssl-1.1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: openssl-1.1
  Show dependency tree
 
Reported: 2018-06-24 08:30 UTC by Andreas Sturmlechner
Modified: 2018-12-02 20:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,127.99 KB, text/x-log)
2018-06-24 08:30 UTC, Andreas Sturmlechner
Details
drop-openssl-dep.patch (file_658902.txt,1.26 KB, patch)
2018-06-24 10:00 UTC, Andreas Sturmlechner
Details | Diff
build with openssl >= 1.1.0 (telepathy-gabble-0.18.4-openssl-1.1.patch,7.06 KB, patch)
2018-10-26 12:48 UTC, Roel Aaij
Details | Diff
patch to build with openssl 1.1.1, better libressl support (telepathy-gabble-0.18.4-openssl-1.1.patch,7.37 KB, patch)
2018-10-26 13:06 UTC, Roel Aaij
Details | Diff
patch to build with openssl 1.1.1, better libressl support (telepathy-gabble-0.18.4-openssl-1.1.patch,7.32 KB, patch)
2018-11-04 08:03 UTC, Roel Aaij
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2018-06-24 08:30:35 UTC
Created attachment 536996 [details]
build.log

Same story as everywhere else.

wocky-openssl-dh512.c: In function ‘get_dh512’:
wocky-openssl-dh512.c:25:4: error: dereferencing pointer to incomplete type ‘DH {aka struct dh_st}’
  dh->p=BN_bin2bn(dh512_p,sizeof(dh512_p),NULL);
    ^~
make[8]: *** [Makefile:780: wocky-openssl-dh512.lo] Error 1
make[8]: *** Waiting for unfinished jobs....
wocky-openssl.c: In function ‘check_peer_name’:
wocky-openssl.c:888:23: error: dereferencing pointer to incomplete type ‘X509 {aka struct x509_st}’
   X509_CINF *ci = cert->cert_info;
                       ^~
wocky-openssl.c:909:19: error: dereferencing pointer to incomplete type ‘X509_CINF {aka struct x509_cinf_st}’
   if (!rval && (ci->extensions != NULL))
                   ^~
wocky-openssl.c:918:22: error: dereferencing pointer to incomplete type ‘X509_EXTENSION {aka struct X509_extension_st}’
         int len = ext->value->length;
                      ^~
wocky-openssl.c: In function ‘_cert_status’:
wocky-openssl.c:1122:33: error: dereferencing pointer to incomplete type ‘X509_STORE {aka struct x509_store_st}’
           long old_flags = store->param->flags;
                                 ^~
Comment 1 Pacho Ramos gentoo-dev 2018-06-24 09:25:22 UTC
I couldn't find any patch for this... but I see that other distributions are simply forcing gnutls usage to overcome this... that could be an option I guess
Comment 2 Andreas Sturmlechner gentoo-dev 2018-06-24 10:00:16 UTC
Created attachment 537020 [details, diff]
drop-openssl-dep.patch

Something like this?
Comment 3 Pacho Ramos gentoo-dev 2018-06-24 10:24:07 UTC
Ah... I added the NeedPatch for the case someone was able to find a patch to port it to openssl-1.1... if not, we can simply move it to gnutls in the future
Comment 4 Roel Aaij 2018-10-26 12:48:47 UTC
Created attachment 553076 [details, diff]
build with openssl >= 1.1.0
Comment 5 Roel Aaij 2018-10-26 12:50:44 UTC
With patch attached it builds with openssl 1.1.1
Comment 6 Roel Aaij 2018-10-26 13:06:44 UTC
Created attachment 553080 [details, diff]
patch to build with openssl 1.1.1, better libressl support

libressl should now keep working. Apologies for the spam
Comment 7 Craig Andrews gentoo-dev 2018-11-02 20:00:44 UTC
(In reply to Roel Aaij from comment #6)
> Created attachment 553080 [details, diff] [details, diff]
> patch to build with openssl 1.1.1, better libressl support
> 
> libressl should now keep working. Apologies for the spam

Is this patch what you submitted at https://github.com/TelepathyIM/wocky/pull/1 ?
Comment 8 Roel Aaij 2018-11-04 08:03:49 UTC
Created attachment 554010 [details, diff]
patch to build with openssl 1.1.1, better libressl support

Yes, this is what I submitted to the upstream wocky repository.

Previous patch had a left-over issue, fixed in this version.
Comment 9 Dennis Schridde 2018-11-30 09:43:57 UTC
The Wocky PR was just merged.  Keywords+=PATCH here?
Comment 10 Larry the Git Cow gentoo-dev 2018-12-02 20:41:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef1871cc2442b12c4b41ad04ff1635786e24e724

commit ef1871cc2442b12c4b41ad04ff1635786e24e724
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-12-02 20:34:20 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-02 20:40:50 +0000

    net-voip/telepathy-gabble: Fix build with openssl-1.1
    
    Closes: https://bugs.gentoo.org/658902
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../telepathy-gabble-0.18.4-openssl-1.1.patch      | 223 +++++++++++++++++++++
 .../telepathy-gabble-0.18.4-r1.ebuild              |  91 +++++++++
 2 files changed, 314 insertions(+)