Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658636 - media-sound/guayadeque - questionable media-libs/gnonlin dependency, review gstreamer deps
Summary: media-sound/guayadeque - questionable media-libs/gnonlin dependency, review g...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-21 09:11 UTC by Mart Raudsepp
Modified: 2018-06-21 09:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2018-06-21 09:11:39 UTC
I don't see any references to gnonlin or libgnl in guayadeque current versions, yet there's still a dep. I think other than this possibly wrong dep, gnonlin would otherwise be last-ritable. Please review.
Comment 1 Mart Raudsepp gentoo-dev 2018-06-21 09:38:32 UTC
The following gstreamer elements are created explicitly in guayadeque source code (some of these could easily be runtime optional, I'm not checking into details of any):

audioconvert
audioresample
chromaprint
decodebin
equalizer-10bands
faac
fakesink
ffenc_wmav2
ffmux_asf
ffmux_mp4
filesink
filesrc
flacenc
giosrc
lamemp3enc
level
oggmux
playbin
queue
rglimiter
rgvolume
tee
volume
vorbisenc
xingmux

The following command should tell what package ships a given element, provided the element plugin is installed on the system:

gst-inspect-1.0 audioconvert |grep Filename |awk '{print $2}' |xargs qfile -eq

Running that in a loop for all of these, sorting and getting unique ones gives this list of potentially used by guayadeque gstreamer packages (version changed to SLOT):

No such element or plugin 'chromaprint'
No such element or plugin 'ffenc_wmav2'
No such element or plugin 'ffmux_asf'
No such element or plugin 'ffmux_mp4'
media-libs/gst-plugins-base:1.0
media-libs/gst-plugins-good:1.0
media-libs/gst-plugins-ugly:1.0
media-libs/gstreamer:1.0
media-plugins/gst-plugins-faac:1.0
media-plugins/gst-plugins-flac:1.0
media-plugins/gst-plugins-lame:1.0

As seen, I don't have packages for 4 elements, and I have all gstreamer packages installed.

chromaprint is a plugin with external deps from gst-plugins-bad that's not yet packaged. This will be packaged soon for other reasons as media-plugins/gst-plugins-chromaprint; probably today or tomorrow or so.

The ffenc_*/ffmux_* do not exist anymore. They were named as such with gstreamer-0.10 in gst-plugins-ffmpeg, but in 1.0 world they are in gst-plugins-libav as avenc_* and avmux_*, so this is upstream being broken for gstreamer 1.0 still in this respect.


Additionally there's a configurable or autoconfigured output audio sink, which is picked from the following list (element name, followed by the package that provides the element in Gentoo):

autoaudiosink - media-libs/gst-plugins-good:1.0
gconfaudiosink - does not exist for 1.0 (another 0.10 remnant in guayadeque)
alsasink - media-libs/gst-plugins-base:1.0[alsa]
pulsesink - media-plugins/gst-plugins-pulse:1.0
osssink - media-plugins/gst-plugins-oss:1.0

The code that handles this is in src/audio/FaderPlaybin.cpp - it looks like a prioritized list of things to try when autoconfigured, or manually settable somewhere by user. I think gst-plugins-meta should be good enough to cover it, instead of exposing own USE flags for this in guayadeque. Some of the other stuff above might be OK to leave to gst-plugins-meta too, though this is mainly meant for playbin/decodebin/uridecodebin usages - but guayadeque does use decodebin as well.

I think gnonlin used to provide some plugins, but at least nowadays it's just a libgnl.so, which I can't see guayadeque using. I think that dep can be removed, and the rest of gstreamer deps can be reviewed per the information above.