Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 657366 - =net-misc/openssh-7.7_p1-r5 stabilization
Summary: =net-misc/openssh-7.7_p1-r5 stabilization
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on: 658232
Blocks:
  Show dependency tree
 
Reported: 2018-06-04 21:17 UTC by Thomas Deutschmann (RETIRED)
Modified: 2018-07-15 21:55 UTC (History)
3 users (show)

See Also:
Package list:
net-misc/openssh-7.7_p1-r5
Runtime testing required: ---
stable-bot: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-04 21:17:31 UTC
Time to stabilize net-misc/openssh-7.7... we will CC ATs when ready.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-05 15:50:56 UTC
We decided to add some more upstream patches (see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65f8a6f69479f569df5eb024e1a652bdada7ce15). So =net-misc/openssh-7.7_p1-r4 is the new stable candidate, however, we now have to wait again some time...
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-11 10:14:26 UTC
@ Arches,

please test and mark stable: =net-misc/openssh-7.7_p1-r4
Comment 3 Rolf Eike Beer archtester 2018-06-11 16:28:15 UTC
Does it make sense to have the ldap USE-flag when it just prints "not supported yet"?
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-11 16:49:54 UTC
Stabilization hold, bug 605446 needs more investigation. Tests are passing when building manually from source.


(In reply to Rolf Eike Beer from comment #3)
> Does it make sense to have the ldap USE-flag when it just prints "not
> supported yet"?

No. If you depend on ldap feature you won't be able to login after net-misc/openssh was upgraded to a version with ldap patch. To prevent situations like that, we stop in this case.
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-11 22:50:00 UTC
Bug 605446 only happens when you run the test using portage, so let's call again for stabilization:

@ Arches,

please test and mark stable: =net-misc/openssh-7.7_p1-r4
Comment 6 Larry the Git Cow gentoo-dev 2018-06-12 09:32:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1f43e82ad8aaca9b199a54ede1325222eaa0712

commit f1f43e82ad8aaca9b199a54ede1325222eaa0712
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-06-12 09:31:54 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-06-12 09:31:59 +0000

    net-misc/openssh: stable 7.7_p1-r4 for ia64, bug #657366
    
    Bug: https://bugs.gentoo.org/657366
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    RepoMan-Options: --include-arches="ia64"

 net-misc/openssh/openssh-7.7_p1-r4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-12 11:38:21 UTC
x86 stable
Comment 8 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-12 15:06:56 UTC
amd64 stable
Comment 9 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-12 15:08:12 UTC
amd64 stable
Comment 10 Larry the Git Cow gentoo-dev 2018-06-12 20:48:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aeacb0583effdf7185695a064b1b9b09b399ebd2

commit aeacb0583effdf7185695a064b1b9b09b399ebd2
Author:     Rolf Eike Beer <eike@sf-mail.de>
AuthorDate: 2018-06-12 18:47:19 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-06-12 20:47:46 +0000

    net-misc/openssh: stable 7.7_p1-r4 for sparc
    
    Bug: https://bugs.gentoo.org/657366
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    RepoMan-Options: --include-arches="sparc"

 net-misc/openssh/openssh-7.7_p1-r4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 11 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-13 06:24:53 UTC
not installable on my system because I have the ldap use flag.  Why was this allowed to be stable?

 * Sorry, but this version does not yet support features
 * that you requested:	 ldap
 * Please mask openssh-7.7_p1-r4 for now and check back later:
 *  # echo '=net-misc/openssh-7.7_p1-r4' >> /etc/portage/package.mask
 * ERROR: net-misc/openssh-7.7_p1-r4::gentoo failed (pretend phase):
 *   booooo
 * 
 * Call stack:
 *                  ebuild.sh, line 124:  Called pkg_pretend
 *   openssh-7.7_p1-r4.ebuild, line  95:  Called die
 * The specific snippet of code:
 *   		die "booooo"
Comment 12 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-13 08:03:45 UTC
I'm not sure it's acceptable to have a stable package that fails to install on purpose.  readding the stable teams for their input
Comment 13 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-13 09:17:56 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #11)
> not installable on my system because I have the ldap use flag.  Why was this
> allowed to be stable?
> 
>  * Sorry, but this version does not yet support features
>  * that you requested:	 ldap
>  * Please mask openssh-7.7_p1-r4 for now and check back later:
>  *  # echo '=net-misc/openssh-7.7_p1-r4' >> /etc/portage/package.mask
>  * ERROR: net-misc/openssh-7.7_p1-r4::gentoo failed (pretend phase):
>  *   booooo
>  * 
>  * Call stack:
>  *                  ebuild.sh, line 124:  Called pkg_pretend
>  *   openssh-7.7_p1-r4.ebuild, line  95:  Called die
>  * The specific snippet of code:
>  *   		die "booooo"

ldap use flag is masked for ssh.
Comment 14 Laszlo Valko 2018-06-13 09:37:14 UTC
(In reply to Mikle Kolyada from comment #13)
> 
> ldap use flag is masked for ssh.

But it wasn't in the previous stable version.

Seriously, what's the point in letting this to stable? Any widespread issues solved by the new version?
Comment 15 Tomáš Mózes 2018-06-13 12:22:39 UTC
On the other hand, not everybody uses ldap with openssh so I'm grateful that we have the latest version stabilized. I believe those requiring ldap can block the new version and help Thomas with the ldap patch if they need it?
Comment 16 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-06-13 12:31:53 UTC
Just to clarify things a bit...

We already p.use.masked the ldap USE flag for desktop profiles:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d3708963703f049e5c99d6d655959a870af3330

So only non-desktop profile users who have USE="ldap" for openssh set run into the "boo" issue.
We will keep the last openssh package with working ldap patch in the tree for users who require ldap auth via ssh. And because we cannot let such users silently install an openssh version _without_ ldap support, we have to stick with the current "boo" situation.
Comment 17 spargeltarzan 2018-06-13 13:14:32 UTC
I am on a Desktop profile with completely standard set of USE flags and I face the "boo" issue. Please stop breaking stable users! We should not be asked to mask packages by hand during an update process.
Comment 18 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-06-13 13:20:31 UTC
(In reply to spargeltarzan from comment #17)
> I am on a Desktop profile with completely standard set of USE flags and I
> face the "boo" issue.

I sincerely doubt that. Either you are _not_ using a dektop profile or you are enabling the ldap USE flag through some file in /etc/portage/profile/

Yet, this bug is not the right place to discuss that.

> Please stop breaking stable users! We should not be
> asked to mask packages by hand during an update process.

This bug is not the right place to state such demands. If you can provide a sane solution without breaking openssh + ldap auth feel free to file a new bug report.
Comment 19 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-13 15:27:15 UTC
For LDAP users: Please see bug 658044! We need your help. Thank you.
Comment 20 zless 2018-06-13 19:29:05 UTC
This should've had a news entry before it even entered testing.
Comment 21 Larry the Git Cow gentoo-dev 2018-06-24 19:39:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0ac58d069f02c0ea1a95446397a08f1bdcd0bc9

commit e0ac58d069f02c0ea1a95446397a08f1bdcd0bc9
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-06-24 17:38:50 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-06-24 19:35:28 +0000

    net-misc/openssh: stable 7.7_p1-r5 for ppc, bug #657366
    
    Bug: https://bugs.gentoo.org/657366
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    RepoMan-Options: --include-arches="ppc"

 net-misc/openssh/openssh-7.7_p1-r5.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 22 Larry the Git Cow gentoo-dev 2018-06-24 20:24:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bfa26d087848e8ebb71faad1df8b158cf69176f4

commit bfa26d087848e8ebb71faad1df8b158cf69176f4
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-06-24 19:52:34 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-06-24 20:20:34 +0000

    net-misc/openssh: stable 7.7_p1-r5 for ppc64, bug #657366
    
    Bug: https://bugs.gentoo.org/657366
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    RepoMan-Options: --include-arches="ppc64"

 net-misc/openssh/openssh-7.7_p1-r5.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 23 Tobias Klausmann (RETIRED) gentoo-dev 2018-06-25 20:44:41 UTC
Stable on alpha.
Comment 24 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-26 15:55:44 UTC
arm stable
Comment 25 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-30 20:59:28 UTC
s390 stable
Comment 26 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-07-15 21:52:03 UTC
m68k/sh stable