Created attachment 534332 [details, diff] libinput-cleanups.patch Subject: [PATCH] dev-libs/libinput: cleanups 1. package installs hwdb files, must refresh udev using udevadm hwdb --update. 2. use ltprune eclass --- I can push if you ACK
Thanks. From #gentoo-dev, it seems that find ... is the suggested way to remove .la files. The ltprune eclass says # Discouraged. Whenever possible, please use much simpler: # @CODE # find "${D}" -name '*.la' -delete || die # @CODE Also, the find was removing static archives as well. Not sure if there were actually any to remove though. I've been confused about virtual/udev vs virtual/libudev, but I think you're right to depend on virtual/udev. Since libinput links directly to libudev do we still need to keep that dependency (and actually add a slot operator, like I did in commit 7ad9a1b9c986031828510c1c86b40666b3ad5adc)? The change to update the hwdb seems good.
(In reply to Matt Turner from comment #1) > Thanks. > > From #gentoo-dev, it seems that find ... is the suggested way to remove .la > files. The ltprune eclass says OK, ignore this. I like this eclass, doing exactly what I need. > I've been confused about virtual/udev vs virtual/libudev, but I think you're > right to depend on virtual/udev. Since libinput links directly to libudev do > we still need to keep that dependency (and actually add a slot operator, > like I did in commit 7ad9a1b9c986031828510c1c86b40666b3ad5adc)? It is required to make sure that udevadm is available. > The change to update the hwdb seems good. Great. Please cherry-pick whatever is acceptable. Thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a30e002942b56d509b58b13ba4066256b6f3f09 commit 5a30e002942b56d509b58b13ba4066256b6f3f09 Author: Alon Bar-Lev <alonbl@gentoo.org> AuthorDate: 2018-05-31 19:53:52 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2018-06-07 00:36:25 +0000 dev-libs/libinput: Refresh udev after installing libinput installs hwdb files, so we must refresh udev with udevadm hwdb --update Closes: https://bugs.gentoo.org/657000 dev-libs/libinput/libinput-1.11.0.ebuild | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
