Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656166 - net-libs/grpc-1.12.0 doesn't compile with gcc-8
Summary: net-libs/grpc-1.12.0 doesn't compile with gcc-8
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason Zaman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-20 15:25 UTC by Helmut Jarausch
Modified: 2019-02-23 17:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patches to make it compile with gcc-8 (0005-grpc-1.11.0-cpp-fixes.patch,2.36 KB, patch)
2018-05-20 15:25 UTC, Helmut Jarausch
Details | Diff
ebuild to apply this additional patch (grpc-1.11.0.ebuild,1.46 KB, text/plain)
2018-05-20 15:26 UTC, Helmut Jarausch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2018-05-20 15:25:54 UTC
Created attachment 532304 [details, diff]
patches to make it compile with gcc-8

gcc-8 is pickier about violations of the C++ standard.
I needed to apply the attached patches to make it compile under gcc-8.1.0-r3
Comment 1 Helmut Jarausch 2018-05-20 15:26:28 UTC
Created attachment 532306 [details]
ebuild to apply this additional patch
Comment 2 Mark Wright gentoo-dev 2018-06-12 05:53:06 UTC
(In reply to Helmut Jarausch from comment #0)
> Created attachment 532304 [details, diff] [details, diff]
> patches to make it compile with gcc-8
> 
> gcc-8 is pickier about violations of the C++ standard.
> I needed to apply the attached patches to make it compile under gcc-8.1.0-r3

Thanks, this patch also fixes the same problem with grpc 1.12.0.
Comment 3 Larry the Git Cow gentoo-dev 2018-06-12 06:53:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a42fbdae17de388d96fed660e15686b19473362

commit 3a42fbdae17de388d96fed660e15686b19473362
Author:     Jason Zaman <perfinion@gentoo.org>
AuthorDate: 2018-06-12 06:52:14 +0000
Commit:     Jason Zaman <perfinion@gentoo.org>
CommitDate: 2018-06-12 06:52:14 +0000

    net-libs/grpc: fix building with gcc8
    
    Closes: https://bugs.gentoo.org/656166
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 .../grpc/files/0009-grpc-1.12.1-gcc8-fixes.patch   | 53 ++++++++++++++++++++++
 net-libs/grpc/grpc-1.12.1.ebuild                   |  1 +
 2 files changed, 54 insertions(+)