Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655682 - app-text/calibre-3.15.0 - make RAR support optional
Summary: app-text/calibre-3.15.0 - make RAR support optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Stakenvicius (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-13 20:38 UTC by Francesco Turco
Modified: 2018-08-28 21:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
calibre-3.15.0.ebuild (calibre-3.15.0.ebuild,9.21 KB, text/plain)
2018-05-13 20:40 UTC, Francesco Turco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Turco 2018-05-13 20:38:34 UTC
At the following URL there are several patches for removing RAR support from Calibre: https://gitlab.com/libreforks/calibre/tags

The goal is to make Calibre 100% free software, since RAR is a proprietary format.

I modified the latest available Gentoo ebuild in order to apply the 3.15.0 libre patch.

I had to modify the libre patch by adding a newline at line 257, otherwise patch complains it is malformed.

I placed the patch in ${FILESDIR}, but Repoman complains it is too large for that.

I also had to remove the other already existing patches, because it seems they conflict with the libre patch.

Since this is Gentoo we may add instead a "rar" USE flag to calibre, so people may decide themselves if they need it or not.
Comment 1 Francesco Turco 2018-05-13 20:40:10 UTC
Created attachment 531278 [details]
calibre-3.15.0.ebuild
Comment 2 Dennis Schridde 2018-07-04 17:26:01 UTC
According to bug #622856, app-text/calibre currently does not even build RAR support in Gentoo.  Can you please have a look at this?
Comment 3 Francesco Turco 2018-08-28 21:15:37 UTC
Today I noticed unrar code in Calibre has been removed a long ago:
https://github.com/kovidgoyal/calibre/commit/d305656bb4923c3737b3f143416c0e3ab682b9a5

At https://gitlab.com/libreforks/calibre there are no patches for recent versions of Calibre. The last one is for 3.20.0 and was released 5 months ago.

Calibre 3.30.0 has been released a few days ago.
Comment 4 Zac Medico gentoo-dev 2018-08-28 21:30:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd844f0e299db13582160aa5a84b3f9720d7ba5c

commit cd844f0e299db13582160aa5a84b3f9720d7ba5c
Author:     Francesco Turco <fturco@fastmail.fm>
AuthorDate: 2018-08-28 18:28:55 +0200
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-08-28 09:46:45 -0700

    app-text/calibre: remove unRAR license
    
    Calibre developers removed unrar code with the following commit:
    https://github.com/kovidgoyal/calibre/commit/d305656bb4923c3737b3f143416c0e3ab682b9a5
    
    Closes: https://github.com/gentoo/gentoo/pull/9721