Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655142 - media-video/smplayer-18.4.0 with Qt 5.11: error: invalid use of incomplete type 'class QAction'
Summary: media-video/smplayer-18.4.0 with Qt 5.11: error: invalid use of incomplete ty...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard: fixed in 18.5.0
Keywords: PATCH
: 659426 662312 (view as bug list)
Depends on:
Blocks: qt-5.11
  Show dependency tree
 
Reported: 2018-05-07 08:46 UTC by Duncan
Modified: 2018-08-07 21:15 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
smplayer-qt-5.11-qaction.patch (qt-5.11.patch,364 bytes, patch)
2018-05-07 08:46 UTC, Duncan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2018-05-07 08:46:03 UTC
Created attachment 530304 [details, diff]
smplayer-qt-5.11-qaction.patch

Missing header QAction in src/videopreview/videopreview.cpp.

There's a bunch of errors similar to the following, but the fix (attached, needs review from a dev and filed upstream) is simple.

make[1]: Leaving directory '/tmp/portage/media-video/smplayer-18.4.0/work/smplayer-18.4.0/webserver'
videopreview/videopreview.cpp: In constructor 'VideoPreview::VideoPreview(QString, QWidget*)':
videopreview/videopreview.cpp:154:34: error: invalid use of incomplete type 'class QAction'
  toggleInfoAct = new QAction(this);
                                  ^
In file included from /include/qt5/QtWidgets/QWidget:1:0,
                 from videopreview/videopreview.h:22,
                 from videopreview/videopreview.cpp:19:
/include/qt5/QtWidgets/qwidget.h:68:7: note: forward declaration of 'class QAction'
 class QAction;
       ^~~~~~~
videopreview/videopreview.cpp:155:15: error: invalid use of incomplete type 'class QAction'
  toggleInfoAct->setCheckable(true);
               ^~
In file included from /include/qt5/QtWidgets/QWidget:1:0,
                 from videopreview/videopreview.h:22,
                 from videopreview/videopreview.cpp:19:
/include/qt5/QtWidgets/qwidget.h:68:7: note: forward declaration of 'class QAction'
Comment 1 jospezial 2018-05-20 22:06:48 UTC
upstream patch:
https://app.assembla.com/spaces/smplayer/subversion/commits/9014

Does the include later.
Comment 2 Fabio Coatti 2018-05-29 10:56:48 UTC
The patch fixes the issue on my side, thanks for the hint.
Comment 3 Igor Poboiko 2018-06-03 08:41:46 UTC
Recently released 18.5.0 version fixed this for me.
Comment 4 Andreas Sturmlechner gentoo-dev 2018-06-03 21:35:45 UTC
Indeed, this is fixed now. Thanks for your report!
Comment 5 Andreas Sturmlechner gentoo-dev 2018-06-27 19:35:21 UTC
*** Bug 659426 has been marked as a duplicate of this bug. ***
Comment 6 Andreas Sturmlechner gentoo-dev 2018-08-07 21:15:50 UTC
*** Bug 662312 has been marked as a duplicate of this bug. ***