Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654714 - net-analyzer/wireshark-2.6.0-r1 fails to configure if both git and rpmbuild are available
Summary: net-analyzer/wireshark-2.6.0-r1 fails to configure if both git and rpmbuild a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-03 10:32 UTC by Bernd Feige
Modified: 2018-05-04 18:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2018-05-03 10:32:51 UTC 
I have both app-arch/rpm and dev-vcs/git installed. In wireshark's CMakeLists.txt file, the logic for assuming the build is from a git checkout and targeting RPM package is flawed:

CMakeLists.txt Line 3024:

# This will fail if we're not building from a git checkout.
if(RPMBUILD_EXECUTABLE AND GIT_EXECUTABLE)
...

Here, RPMBUILD_EXECUTABLE and GIT_EXECUTABLE just check for the availability of the rpmbuild and git commands.
Just as the comment predicts, this fails for the ebuild.

Disabling that code path by changing the IF line to

if(RPMBUILD_EXECUTABLE AND GIT_EXECUTABLE and FALSE)

makes wireshark compile again. Of course a proper test, or a user-supplied flag, should better be used.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-05-04 18:02:03 UTC 
Fixed without revision bump.