Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 653788 - app-cdr/dvdisaster ebuilds need some cleanup
Summary: app-cdr/dvdisaster ebuilds need some cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Kenzelmann
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 653772
  Show dependency tree
 
Reported: 2018-04-22 14:58 UTC by Jonas Stein
Modified: 2018-09-30 10:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2018-04-22 14:58:52 UTC
I had a short look at the ebuild we want to stabilize. There are a few things which should be improved before stabilization. You find us on IRC #gentoo-dev-help and #gentoo-proxy-maint, if you got stuck.


* please bump to EAPI=6
* remove eutils
* read https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI
* add || die where missing (rm line for example)
* LICENSE="GPL-3+" OR LICENSE="GPL-2" ?
* test with repoman -x full
Comment 1 Daniel Kenzelmann 2018-05-03 17:23:33 UTC
Adding arches as per comment in
https://github.com/gentoo/gentoo/pull/8174

New rebased commit (without stable keywords) available at
https://github.com/github-k8n/gentoo/commit/997a2423423abfd5101696d7d8c6190a9056bdfa

should I open a new pull request?
Comment 2 Pacho Ramos gentoo-dev 2018-09-30 10:30:44 UTC
[master 7825bb59cdfc] app-cdr/dvdisaster: Cleanup ebuild (#653788 by Daniel Kenzelmann)
 1 file changed, 12 insertions(+), 11 deletions(-)