Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 653628 - dev-lang/ruby: rework patch tarballs to all be -p1 applicable.
Summary: dev-lang/ruby: rework patch tarballs to all be -p1 applicable.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-20 18:17 UTC by hanetzer
Modified: 2018-07-16 16:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ruby-patches-2.4.3-r0.1.tar.bz2 (ruby-patches-2.4.3-r0.1.tar.bz2,2.79 KB, application/octet-stream)
2018-04-21 11:40 UTC, hanetzer
Details
ruby-patches-2.4.4-r0.1.tar.bz2 (ruby-patches-2.4.4-r0.1.tar.bz2,2.79 KB, application/x-bzip)
2018-04-21 11:40 UTC, hanetzer
Details
ruby-patches-2.5.0-r1.1.tar.bz2 (ruby-patches-2.5.0-r1.1.tar.bz2,1.82 KB, application/x-bzip)
2018-04-21 11:41 UTC, hanetzer
Details
ruby-patches-2.5.0-r2.1.tar.bz2 (ruby-patches-2.5.0-r2.1.tar.bz2,2.88 KB, application/x-bzip)
2018-04-21 11:41 UTC, hanetzer
Details
ruby-patches-2.5.1-r0.1.tar.bz2 (ruby-patches-2.5.1-r0.1.tar.bz2,2.88 KB, application/x-bzip)
2018-04-21 11:42 UTC, hanetzer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hanetzer 2018-04-20 18:17:48 UTC
dev-lang/ruby versions 2.4.3, 2.4.4, 2.5.0-r1, 2.5.0-r2 and 2.5.1
all use a tarball of patches with mixed levels (-p1 and -p0) of
patches.

I'm requesting they be reworked to all be -p1 applicable, so we
can drop epatch in favor of eapply in the EAPI=6 ebuilds.

Normally I would just pr this myself, or provide a patch, but due
to the use of files outside the gentoo repository itself I can't
do that easily.

Offenders include:
ruby-2.4.3:    009_no-gems.patch
ruby-2.4.4:    009_no-gems.patch
ruby-2.5.0-r1: 005_no-undefined-ext.patch
ruby-2.5.0-r1: 009_no-gems.patch
ruby-2.5.0-r2: 005_no-undefined-ext.patch
ruby-2.5.0-r2: 009_no-gems.patch
ruby-2.5.1:    005_no-undefined-ext.patch
ruby-2.5.1:    009_no-gems.patch

I could have missed some, but at least these ones need to be reworked.
Comment 1 hanetzer 2018-04-21 11:40:18 UTC
Created attachment 528138 [details]
ruby-patches-2.4.3-r0.1.tar.bz2

reworked patch tarball
Comment 2 hanetzer 2018-04-21 11:40:42 UTC
Created attachment 528140 [details]
ruby-patches-2.4.4-r0.1.tar.bz2

reworked patch tarball
Comment 3 hanetzer 2018-04-21 11:41:23 UTC
Created attachment 528142 [details]
ruby-patches-2.5.0-r1.1.tar.bz2

reworked patch tarball
Comment 4 hanetzer 2018-04-21 11:41:45 UTC
Created attachment 528144 [details]
ruby-patches-2.5.0-r2.1.tar.bz2
Comment 5 hanetzer 2018-04-21 11:42:02 UTC
Created attachment 528146 [details]
ruby-patches-2.5.1-r0.1.tar.bz2
Comment 6 Hans de Graaff gentoo-dev Security 2018-07-16 07:38:33 UTC
The patchsets for ruby 2.4.4-r1 and 2.5.1-r1 have been moved to the FILESDIR and updates to work with eapply.
Comment 7 hanetzer 2018-07-16 16:57:31 UTC
(In reply to Hans de Graaff from comment #6)
> The patchsets for ruby 2.4.4-r1 and 2.5.1-r1 have been moved to the FILESDIR
> and updates to work with eapply.

Thanks, I've killed the branch on the pr that got closed due to whoever
that annoyance was.