Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 653554 - dev-build/cmake - cmake_src_bootstrap is trying to be too clever with MAKEOPTS
Summary: dev-build/cmake - cmake_src_bootstrap is trying to be too clever with MAKEOPTS
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: makeopts-ignored
  Show dependency tree
 
Reported: 2018-04-19 17:41 UTC by Enne Eziarc
Modified: 2024-12-24 20:58 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cmake.ebuild.diff (cmake.ebuild.diff,853 bytes, patch)
2018-04-19 19:22 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enne Eziarc 2018-04-19 17:41:59 UTC
The code in that function tries to pull out the -j value and pass it to ./bootstrap --parallel, but this has dire results for something like MAKEOPTS="-j7 -l1".

Would be better for the first regex to be anchored at both ends so that it picks the safe but slow default if it can't account for the entire string. (would be better still if I didn't need to resort to FEATURES=-distcc to build it, but one thing at a time.)
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-04-19 19:22:11 UTC
Created attachment 528056 [details, diff]
cmake.ebuild.diff

Can you test the attached patch and give feedback please?
Comment 2 Enne Eziarc 2018-04-19 19:45:54 UTC
It works, after doing s/: then/; then/, followed by emerge -C cmake; emerge -1 cmake, but no change: I still get a "gmake -j 7" in my process tree.
Comment 3 Enne Eziarc 2024-12-23 23:20:55 UTC
Closing this as it looks like whatever code it was about is long gone.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-12-24 20:58:49 UTC
commit c75df64900c81f3445b2789d7337b81ccd41d076
Author: Michał Górny <mgorny@gentoo.org>
Date:   Fri Dec 20 22:55:46 2019 +0100

    dev-util/cmake: Reuse makeopts_jobs in bootstrap command

    Closes: https://github.com/gentoo/gentoo/pull/14068
    Signed-off-by: Michał Górny <mgorny@gentoo.org>