Created attachment 521544 [details, diff] Example of adding new USE flag Otter is supporting QtWebEngine as experimental feature. I tested this feature in my local environment, with my custom ebuild: https://github.com/knokmki612/gentoo-overlay/blob/master/www-client/otter/otter-0.9.91-r2.ebuild And it works ;) could you consider to add new USE flag "webengine"?
Comment on attachment 521544 [details, diff] Example of adding new USE flag >@@ -11,7 +11,7 @@ > LICENSE="GPL-3" > SLOT="0" > KEYWORDS="~amd64 ~ppc64 ~x86" >-IUSE="spell" >+IUSE="webengine spell" > > DEPEND=" > dev-qt/qtconcurrent:5 >@@ -28,6 +28,7 @@ > dev-qt/qtwebkit:5 > dev-qt/qtwidgets:5 > dev-qt/qtxmlpatterns:5 >+ webengine? ( dev-qt/qtwebengine:5[widgets] ) > spell? ( kde-frameworks/sonnet ) That's not enough. We need to explicitly disable qtwebkit and enable qtwebengine or it will pick the most likely candidate automagically.
This is currently held up by bug #649264.
Created attachment 521816 [details, diff] take 2(selectable from webkit or webengine)
Created attachment 521818 [details, diff] When only use qtwebengine, change default value from qtwebkit to qtwebengine
Hi Jeroen, thanks for your reply! I tried to improve my ebuild upon receiving your remarks I hope it will help your works!
otter-0.9.95 is currently specifies >=qtwebengine-5.9.0, so I did fallback my work to otter-0.9.94(it was still >=qtwebengine-5.6.0)
Please try with 0.9.96.
Created attachment 521832 [details] build.log (0.9.96) I still use =qtwebengine-5.7.1-r2, so I got error (cannot found Qt5WebEngineWidgets 5.9.0) as in build.log. I think it will same as =otter-0.9.95
Created attachment 521834 [details] otter-0.9.96(depend fixed) Jeroen, could you try this if you can test with qtwebengine-5.9.4?
I pushed these files to my overlay https://github.com/knokmki612/gentoo-overlay/tree/master/www-client/otter
(In reply to Kimiaki Kuno from comment #8) > Created attachment 521832 [details] > build.log(when I do emerge =otter-0.9.96) > > I still use =qtwebengine-5.7.1-r2, so I got error > (cannot found Qt5WebEngineWidgets 5.9.0) as in build.log. But how can that be? I set that build dependency already: webengine? ( >=dev-qt/qtwebengine-5.9:5[widgets] )
(In reply to Kimiaki Kuno from comment #9) > Jeroen, could you try this if you can test with qtwebengine-5.9.4? No, like I said before: (In reply to Jeroen Roovers from comment #2) > This is currently held up by bug #649264. I am still building qt*-5.9* with a workaround mentioned via that bug.
Comment on attachment 521832 [details] build.log (0.9.96) * Qt5WebEngineWidgets (required version >= 5.9.0), QtWebEngine based backend (widgets), <https://www.qt.io/> This is already set in the 0.9.96 ebuild.
(In reply to Jeroen Roovers from comment #12) > I am still building qt*-5.9* with a workaround mentioned via that bug. I understand, thanks
Comment on attachment 521818 [details, diff] When only use qtwebengine, change default value from qtwebkit to qtwebengine This suggests they are not mutually exclusive. I.e. we should have both IUSE="webengine webkit"?
(In reply to Jeroen Roovers from comment #15) > This suggests they are not mutually exclusive. I.e. we should have both > IUSE="webengine webkit"? Because Otter can switch qtwebkit and qtwebengine each others by setting at "about:config" after install.
(In reply to Kimiaki Kuno from comment #16) > (In reply to Jeroen Roovers from comment #15) > > This suggests they are not mutually exclusive. I.e. we should have both > > IUSE="webengine webkit"? > > Because Otter can switch qtwebkit and qtwebengine each others by setting at > "about:config" after install. What I mean is, I previously committed an ebuild that made both backends mutually exclusive. I am now testing an ebuild that requires at least one backend. When that turns out to work, I will commit the changes.
(In reply to Jeroen Roovers from comment #17) > What I mean is, I previously committed an ebuild that made both backends > mutually exclusive. > > I am now testing an ebuild that requires at least one backend. When that > turns out to work, I will commit the changes. nice, thank you for your quick response
Could you check again, please? commit 88c074ca3e58d416a23de2a6f9ef7e0dec357482 Author: Jeroen Roovers <jer@gentoo.org> Date: Sat Mar 3 04:56:45 2018 +0100 www-client/otter: Allow for both qtwebkit and qtwebengine to be enabled (bug #649170). Package-Manager: Portage-2.3.24, Repoman-2.3.6
Created attachment 523992 [details] simplescreenrecorder-2018-03-07_12.10.34.gif I checked www-client/otter-0.9.96 with dev-qt/*:5/5.9. Package installation(emerge) works fine. but in specificall flags(-webkit +webengine), wrongly value of config setted by default. this is why I wrote the patch. See this gif animation.
dev-qt/qtwebkit should not be used for a webbrowser at all these days. If you insist on keeping IUSE=webkit, it should be default off, with webengine being the default.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0887cc03be7e334a3f542c8074dca4d0c4fbfea7 commit 0887cc03be7e334a3f542c8074dca4d0c4fbfea7 Author: Jeroen Roovers <jer@gentoo.org> AuthorDate: 2020-08-10 17:05:51 +0000 Commit: Jeroen Roovers <jer@gentoo.org> CommitDate: 2020-08-10 17:09:30 +0000 www-client/otter: Drop support for dev-qt/qtwebkit - Add upstream patch for qtgui 5.15.0 - Drop USE="webengine webkit" and use only dev-qt/qtwebengine - EAPI=7 - cmake-utils.eclass => cmake.eclass Package-Manager: Portage-3.0.2, Repoman-2.3.23 Closes: https://bugs.gentoo.org/649170 Closes: https://bugs.gentoo.org/show_bug.cgi?id=712172 Signed-off-by: Jeroen Roovers <jer@gentoo.org> .../otter/files/otter-1.0.01-qtgui-5.15.0.patch | 10 +++ .../otter/files/otter-1.0.01-webengine.patch | 11 +++ www-client/otter/otter-1.0.01-r1.ebuild | 85 ++++++++++++++++++++++ www-client/otter/otter-9999.ebuild | 24 ++++-- 4 files changed, 124 insertions(+), 6 deletions(-)
(In reply to Andreas Sturmlechner from comment #21) > dev-qt/qtwebkit should not be used for a webbrowser at all these days. Still true for 1.0.01-r0, how about cleanup?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a2e5c48dc8634156add7e3fae9d2ac40eead369 commit 0a2e5c48dc8634156add7e3fae9d2ac40eead369 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2020-11-05 12:03:25 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2020-11-05 17:57:26 +0000 www-client/otter: Finally drop 10.0.01 (r0) Bug: https://bugs.gentoo.org/712172 Bug: https://bugs.gentoo.org/649170 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> www-client/otter/metadata.xml | 11 ++--- www-client/otter/otter-1.0.01.ebuild | 85 ------------------------------------ 2 files changed, 4 insertions(+), 92 deletions(-)
