Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 647896 - app-office/libreoffice-5.4.5.1 - .../work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx:1401:51: error: invalid static_cast from type 'SalMenu*' to type 'GtkSalMenu*'
Summary: app-office/libreoffice-5.4.5.1 - .../work/libreoffice-5.4.5.1/vcl/unx/gtk3/gt...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-16 19:11 UTC by Olof Kindgren
Modified: 2018-02-17 00:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build_log.tar.gz (build_log.tar.gz,292.06 KB, application/gzip-compressed-tar)
2018-02-16 19:16 UTC, Olof Kindgren 		Details
emerge --info (emerge_info,16.24 KB, text/plain)
2018-02-16 19:17 UTC, Olof Kindgren 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olof Kindgren 2018-02-16 19:11:57 UTC 
Several issues with casting between GtkSalMenu* and SalMenu*. Seems to be Gtk3-related

/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx: In member function 'virtual void GtkSalFrame::SetMenu(SalMenu*)':
/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx:1401:51: error: invalid static_cast from type 'SalMenu*' to type 'GtkSalMenu*'
     m_pSalMenu = static_cast<GtkSalMenu*>(pSalMenu);
                                                   ^
/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx: In member function 'SalMenu* GtkSalFrame::GetMenu()':
/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx:1406:12: error: cannot convert 'GtkSalMenu*' to 'SalMenu*' in return
     return m_pSalMenu;
            ^~~~~~~~~~
In file included from /var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx:20:0:
/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/inc/unx/gtk/gtkframe.hxx:71:7: note: class type 'GtkSalMenu' is incomplete
 class GtkSalMenu;
       ^~~~~~~~~~
/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx: In member function 'void GtkSalFrame::SetScreen(unsigned int, GtkSalFrame::SetType, tools::Rectangle*)':
/var/tmp/portage/app-office/libreoffice-5.4.5.1/work/libreoffice-5.4.5.1/vcl/unx/gtk3/gtk3gtkframe.cxx:1928:65: error: invalid use of incomplete type 'class GtkSalMenu'
     GtkWidget* pMenuBarContainerWidget = m_pSalMenu ? m_pSalMenu->GetMenuBarContainerWidget() : nullptr;
                                                                 ^~
Comment 1 Olof Kindgren 2018-02-16 19:16:17 UTC 
Created attachment 519844 [details]
build_log.tar.gz
Comment 2 Olof Kindgren 2018-02-16 19:17:45 UTC 
Created attachment 519846 [details]
emerge --info
Comment 3 Olof Kindgren 2018-02-16 19:18:49 UTC 
emerge -pqv

[ebuild     U ] app-office/libreoffice-5.4.5.1 [5.4.4.2] USE="branding cups gtk3 pdfimport -bluetooth (-coinmp) -collada -dbus -debug -eds (-firebird) -gltf -googledrive -gstreamer -gtk -java -jemalloc -kde -libressl -mysql -odk -postgres -quickstarter {-test} -vlc" LIBREOFFICE_EXTENSIONS="-nlpsolver -scripting-beanshell -scripting-javascript -wiki-publisher" PYTHON_SINGLE_TARGET="python3_5 -python2_7 -python3_4 -python3_6" PYTHON_TARGETS="python3_5 python3_6 -python2_7 -python3_4"
Comment 4 Olof Kindgren 2018-02-16 19:31:41 UTC 
Digging a bit deeper, this seems to be the same issue as https://bugs.gentoo.org/641812
Comment 5 François Valenduc 2018-02-16 21:52:49 UTC 
I encounter the same problem/ The patch for libreoffice 5.4.4.2 mentionned in #641812 still apply, so I guess it is also needed with version 5.4.5.1.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2018-02-16 23:58:42 UTC 
Comment on attachment 519844 [details]
build_log.tar.gz

Look, we know about the size restriction.
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2018-02-16 23:59:48 UTC 
Comment on attachment 519844 [details]
build_log.tar.gz

Why would you store a single file in a tar archive? You could just compress the file without any tar involvement.
Comment 8 Andreas Sturmlechner gentoo-dev 2018-02-17 00:14:36 UTC 
Yes, we need to re-add the 5.4.4.2 fix, thanks for reporting.

*** This bug has been marked as a duplicate of bug 641812 ***
Comment 9 Larry the Git Cow gentoo-dev 2018-02-17 00:18:01 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5a9628d853c69c81093af08c28c88e8acc583f7

commit e5a9628d853c69c81093af08c28c88e8acc583f7
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-02-17 00:13:47 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-02-17 00:17:13 +0000

    app-office/libreoffice: Re-add gtk3-no-gtk-build.patch for 5.4.5.1
    
    Closes: https://bugs.gentoo.org/647896
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 app-office/libreoffice/libreoffice-5.4.5.1.ebuild | 1 +
 1 file changed, 1 insertion(+)