Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 647870 - app-crypt/gpgme: please add elibtoolize to src_prepare
Summary: app-crypt/gpgme: please add elibtoolize to src_prepare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Crypto team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-16 17:17 UTC by Fabian Groffen
Modified: 2018-03-02 19:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2018-02-16 17:17:32 UTC
On Solaris, we need to run elibtoolize in order to get shared libs build.  Without this, static libs are produced.

Please add elibtoolize to src_prepare to enable shared libs for gpgme on Solaris.

Thanks!
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2018-02-16 17:28:49 UTC
Hi,
Just a thought... if this is required all the time, why doesn't prefix add this as default hook into portage?
Alon
Comment 2 Fabian Groffen gentoo-dev 2018-02-16 17:34:13 UTC
Diego/Flameyes once had the plan to run elibtoolize for everything, but he never got to it because it hit some problems.  It indeed isn't always a good idea to run elibtoolize.  Hence, I believe we still do it on a per-package basis for any of the cases that elibtoolize covers (which is beyond Prefix).
Comment 3 Larry the Git Cow gentoo-dev 2018-02-16 17:42:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61c2231f862bdb6a5485fc5788c6143435941d2f

commit 61c2231f862bdb6a5485fc5788c6143435941d2f
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-02-16 13:46:11 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-02-16 17:42:06 +0000

    app-crypt/gpgme: add elibtoolize
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=647870
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-crypt/gpgme/gpgme-1.10.0.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 Fabian Groffen gentoo-dev 2018-02-16 20:21:15 UTC
I don't want to be picky or anything, but I noticed you added elibtoolize to src_compile instead.
Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev 2018-02-16 20:45:29 UTC
(In reply to Fabian Groffen from comment #4)
> I don't want to be picky or anything, but I noticed you added elibtoolize to
> src_compile instead.

you are not, I was dreaming... was sure I added it to prepare, thanks!
Comment 6 Larry the Git Cow gentoo-dev 2018-03-02 19:24:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6937862d7f8470dc859d8c873576512b166599a2

commit 6937862d7f8470dc859d8c873576512b166599a2
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-02-16 18:21:22 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-03-02 12:58:28 +0000

    app-crypt/gpgme: add elibtoolize
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=647870
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-crypt/gpgme/gpgme-1.10.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)