Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644484 - sys-apps/opentmpfiles installs files outside of $EPREFIX
Summary: sys-apps/opentmpfiles installs files outside of $EPREFIX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
: 645458 646214 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-13 19:31 UTC by Paul Preney
Modified: 2018-04-30 13:52 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch adding EPREFIX to opentmpfiles tarball files (opentmpfiles-0.1.3.patch,2.33 KB, patch)
2018-01-13 19:31 UTC, Paul Preney
Details | Diff
opentmpfiles.patch (opentmpfiles.patch,1.01 KB, patch)
2018-01-23 11:23 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Preney 2018-01-13 19:31:48 UTC
Created attachment 514700 [details, diff]
Patch adding EPREFIX to opentmpfiles tarball files

Within Gentoo Prefix the opentmpfiles v0.1.3 fails to install since it tries to install files outside of EROOT (i.e., into /bin* paths).

The attached patchfile modifies the source code so that EPREFIX is set in front of all absolute paths. With this opentmpfiles-0.1.3.ebuild builds and installs properly.

--

The opentmpfiles-0.1.3.ebuild file appears to have a /sbin path that should also be prefixed with ${EPREFIX} --but such doesn't affect the installation and use of eix (as this is within Gentoo Prefix) so that is not part of this patch.

--

This was discovered by trying to install app-portage/eix in Gentoo Prefix: opentmpfiles is a dependency of eix.
Comment 1 Benda Xu gentoo-dev 2018-01-23 11:23:17 UTC
Created attachment 516046 [details, diff]
opentmpfiles.patch

Thanks Paul for the report and patch.  It helped me come up with an improved version here.


Hi William, please review the patch with which I intend to revision bump opentmpfiles-0.1.3.

One remaining issues is that on Prefix, if EUID!=0, no users or groups can be specified.  Thus chown/chgrp in /bin/tmpfiles fails.  A feature similar to user.eclass (commit 4524dea9689c94b7b62) is desirable for /bin/tmpfiles.  Do you have plans to port it?
Comment 2 Mike Gilbert gentoo-dev 2018-01-23 22:17:25 UTC
*** Bug 645458 has been marked as a duplicate of this bug. ***
Comment 3 Benda Xu gentoo-dev 2018-01-31 20:35:20 UTC
*** Bug 646214 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2018-02-06 03:17:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68549620265e97d963ebf5d969699b7ebd4eaead

commit 68549620265e97d963ebf5d969699b7ebd4eaead
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2018-01-13 03:36:10 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2018-02-06 03:14:58 +0000

    sys-apps/opentmpfiles: support Prefix.
    
    Reported-By: Paul Preney, Horea Christian, Cyril de Vaucleroy
    Closes: https://bugs.gentoo.org/644484
    
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 sys-apps/opentmpfiles/opentmpfiles-0.1.3-r1.ebuild | 53 ++++++++++++++++++++++
 1 file changed, 53 insertions(+)
Comment 5 Askar Bektassov 2018-04-29 12:21:08 UTC
same issue in sys-apps/opentmpfiles-9999, attachment https://644484.bugs.gentoo.org/attachment.cgi?id=516046 works fine.

During installation, it still complaints about failure creating some symlinks (like in https://bugs.gentoo.org/649480), but I guess it should not have any effect on prefix at all.
Comment 6 Larry the Git Cow gentoo-dev 2018-04-30 13:52:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=744bd9bc87bda99a06e0e93513bef5cf0cf95b13

commit 744bd9bc87bda99a06e0e93513bef5cf0cf95b13
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2018-04-30 13:40:30 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2018-04-30 13:52:17 +0000

    sys-apps/opentmpfiles: apply 68549620 to -9999.
    
    Suggested-By: Askar Bektassov
    Bug: https://bugs.gentoo.org/644484
    
    Package-Manager: Portage-2.3.28, Repoman-2.3.9

 sys-apps/opentmpfiles/opentmpfiles-9999.ebuild | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)}