Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643896 - dev-db/redis-4.0.6 init script improvements
Summary: dev-db/redis-4.0.6 init script improvements
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ultrabug
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-08 13:24 UTC by Patrick Lauer
Modified: 2018-01-08 18:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2018-01-08 13:24:44 UTC
The init script currently sets

pidfile=${REDIS_PID:-/run/redis/redis.pid}

and then later does

start_pre() {
        checkpath -d -m 0775 -o ${REDIS_USER}:${REDIS_GROUP} $(dirname ${REDIS_PID})
}

if for some reason REDIS_PID is unset $pidfile has a value, but checkpath/dirname gets confused and the init script refuses to run.

It would be easier to set:

REDIS_PID=${REDIS_PID:-/run/redis/redis.pid}

and then replace $pidfile with $REDIS_PID everywhere