Bug 639232 – x11-drivers/nvidia-drivers-387.34 with CONFIG_GCC_PLUGIN_RANDSTRUCT - .../work/kernel/nvidia-modeset/nvidia-modeset-linux.c:346:5: error: positional initialization of field in ‘struct’ declared with ‘designated_init’ attribute [-Werror=designated-init]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Karl-Johan Karlsson 2017-11-29 22:04:24 UTC]

Created attachment 507224 [details, diff]
named-initializers-for-randstruct.patch

On kernels with CONFIG_GCC_PLUGIN_RANDSTRUCT enabled, x11-drivers/nvidia-drivers fails to build with these error messages (this is from x11-drivers/nvidia-drivers-387.34 on gentoo-sources-4.12.2, but according to https://devtalk.nvidia.com/default/topic/1020857/384-59-divers-linux-4-13-rc1-and-later-kernel-compile-error-with-config_gcc_plugin_randstruct-y/ it's been this way since at least driver 384.59 on mainline 4.13-rc1):


/var/tmp/portage/x11-drivers/nvidia-drivers-387.34/work/kernel/nvidia-modeset/nvidia-modeset-linux.c:346:5: error: positional initialization of field in ‘struct’ declared with ‘designated_init’ attribute [-Werror=designated-init]
     nvkms_suspend,
     ^~~~~~~~~~~~~
/var/tmp/portage/x11-drivers/nvidia-drivers-387.34/work/kernel/nvidia-modeset/nvidia-modeset-linux.c:346:5: note: (near initialization for ‘nvkms_rm_callbacks’)
/var/tmp/portage/x11-drivers/nvidia-drivers-387.34/work/kernel/nvidia-modeset/nvidia-modeset-linux.c:346:5: error: invalid initializer
/var/tmp/portage/x11-drivers/nvidia-drivers-387.34/work/kernel/nvidia-modeset/nvidia-modeset-linux.c:346:5: note: (near initialization for ‘nvkms_rm_callbacks.<anonymous>’)
/var/tmp/portage/x11-drivers/nvidia-drivers-387.34/work/kernel/nvidia-modeset/nvidia-modeset-linux.c:347:5: error: positional initialization of field in ‘struct’ declared with ‘designated_init’ attribute [-Werror=designated-init]
     nvkms_resume
     ^~~~~~~~~~~~
/var/tmp/portage/x11-drivers/nvidia-drivers-387.34/work/kernel/nvidia-modeset/nvidia-modeset-linux.c:347:5: note: (near initialization for ‘nvkms_rm_callbacks’)


Adding the patch suggested in the URL above as /etc/portage/patches/x11-drivers/nvidia-drivers-387.34/named-initializers-for-randstruct.patch makes the driver build, and running it I can suspend and resume my KDE 5 desktop and still play StarCraft 2, so the patch seems to work.

[Comment 1 Jeroen Roovers (RETIRED) 2017-12-02 21:38:06 UTC]

Please attach the entire build log to this bug report.
Please post your `emerge --info` output in a comment.

[Comment 2 Karl-Johan Karlsson 2017-12-02 22:02:46 UTC]

Created attachment 507794 [details]
build.log

[Comment 3 Karl-Johan Karlsson 2017-12-02 22:03:05 UTC]

Portage 2.3.16 (python 3.4.6-final-0, hardened/linux/amd64, gcc-7.2.0, glibc-2.26-r3, 4.14.2-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.14.2-gentoo-x86_64-Intel-R-_Core-TM-_i7-4770K_CPU_@_3.50GHz-with-gentoo-2.4.1
KiB Mem:    32880600 total,  21993656 free
KiB Swap:   33521660 total,  33521660 free
Timestamp of repository gentoo: Sat, 02 Dec 2017 09:30:01 +0000
Head commit of repository gentoo: 5e6af07a8dd3b95fabf2874995edbc85064d4a68
sh bash 4.4_p12
ld GNU ld (Gentoo 2.29 p1.0) 2.29
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.26.1-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.4.6-r1::gentoo, 3.5.4-r1::gentoo
dev-util/cmake:           3.10.0::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.9::gentoo
sys-apps/sandbox:         2.12::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.13.4-r1::gentoo, 1.15.1-r1::gentoo
sys-devel/binutils:       2.29::gentoo, 2.29.1-r1::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo, 6.4.0::gentoo, 7.2.0::gentoo
sys-devel/gcc-config:     1.9.0::gentoo
sys-devel/libtool:        2.4.6-r4::gentoo
sys-devel/make:           4.2.1-r1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r3::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: --timeout=10 --ipv6
                                                                                                              
creideiki                                                                                                     
    location: /usr/local/portage                                                                              
    masters: gentoo                                                                                           
    priority: 0                                                                                               
                                                                                                              
rion
    location: /var/lib/layman/rion
    sync-type: laymansync
    sync-uri: git://github.com/rion-overlay/rion-overlay.git
    masters: gentoo
    priority: 50

seden
    location: /var/lib/layman/seden
    sync-type: laymansync
    sync-uri: git://anongit.gentoo.org/user/seden.git
    masters: gentoo
    priority: 50

steam-overlay
    location: /var/lib/layman/steam-overlay
    sync-type: laymansync
    sync-uri: git://github.com/anyc/steam-overlay.git
    masters: gentoo
    priority: 50

torbrowser
    location: /var/lib/layman/torbrowser
    sync-type: laymansync
    sync-uri: git://github.com/MeisterP/torbrowser-overlay.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--alphabetical --keep-going --quiet-build=n --backtrack=30 --verbose-conflicts"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--enable-new-dtags"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--timeout=10 --ipv6"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X acl alsa amd64 berkdb bluray bzip2 cli cracklib crypt cuda cups cxx dri dvd emacs exif ffmpeg flac gdbm gif hackrf hardened iconv idn ipv6 jpeg jpeg2k justify kde mng modules multilib ncurses nls nptl ogg opengl openmp pam pcre pdf pie png postscript qt5 readline seccomp session ssl ssp svg tcpd tiff unicode urandom vaapi vdpau vorbis wmf xattr xpm xtpax zlib" ABI_X86="64 32" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="braindump flow karbon kexi krita sheets stage words" CAMERAS="canon" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev wacom" KERNEL="linux" L10N="en en-US en-GB sv" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_4 python3_5" QEMU_SOFTMMU_TARGETS="i386 x86_64" RUBY_TARGETS="ruby23 ruby24" SANE_BACKENDS="pixma hp" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS

=================================================================
                        Package Settings
=================================================================

x11-drivers/nvidia-drivers-387.34::gentoo was built with the following:
USE="X -acpi -compat driver -gtk3 kms multilib -pax_kernel -static-libs tools uvm -wayland" ABI_X86="32 (64) (-x32)"

[Comment 4 Ciprian Ciubotariu 2017-12-30 02:34:43 UTC]

I want to confirm the same build problem with 4.14.8-r1 with randomizer plugin enabled. My current workaround is to disable the GCC randomizer plugin, which fixes the build of nvidia-drivers.

[Comment 5 Jeroen Roovers (RETIRED) 2020-06-27 04:34:03 UTC]

Comment on attachment 507224 [details, diff]
named-initializers-for-randstruct.patch

AFAICT all recent nvidia-drivers releases have this patched already.