Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 638774 - dev-util/geany-plugins: match dev-util/geany version / convert remaining GTK+ 2 only plugins
Summary: dev-util/geany-plugins: match dev-util/geany version / convert remaining GTK+...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chris Mayo
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: pygtk-removal
  Show dependency tree
 
Reported: 2017-11-25 09:19 UTC by Klaus Kusche
Modified: 2020-04-14 19:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Klaus Kusche 2017-11-25 09:19:29 UTC
Geany 1.32 und geany-plugins-1.32 have been released upstream,
but only geany has been updated in gentoo, plugins are still 1.31.

Please also update geany-plugins, their versions must be kept in sync.

Moreover, some distributions offer pure gtk3 versions of geany-plugins,
including gtk3 versions of those plugins which are still gtk2 only 
in gentoo and upstream (debugger, ...). 
Most important, the vte2-based plugins have been updated to vte3.

https://aur.archlinux.org/packages/geany-plugins-gtk3/
https://launchpad.net/~bluesabre/+archive/ubuntu/geany-gtk3

Could you please 
* completely switch to the gtk3 fork of geany-plugins,
* or offer a geany-plugings-gtk3 ebuild in addition to geany-plugins,
* or apply the diff's between the upstream plugins and the gtk3 fork
  as a patch in the geany-plugins ebuild?
Comment 1 Chris Mayo 2017-11-25 20:18:55 UTC
(In reply to Klaus Kusche from comment #0)
> Geany 1.32 und geany-plugins-1.32 have been released upstream,
> but only geany has been updated in gentoo, plugins are still 1.31.
1.32 is in the queue:
https://github.com/gentoo/gentoo/pull/6262

> 
> Please also update geany-plugins, their versions must be kept in sync.
Which 1.31 plugins are not working with Geany 1.32?
Some 1.32 plugins will not work with 1.31 hence the dependency bump in the PR above.

> 
> Moreover, some distributions offer pure gtk3 versions of geany-plugins,
> including gtk3 versions of those plugins which are still gtk2 only 
> in gentoo and upstream (debugger, ...). 
> Most important, the vte2-based plugins have been updated to vte3.
> 
> https://aur.archlinux.org/packages/geany-plugins-gtk3/
> https://launchpad.net/~bluesabre/+archive/ubuntu/geany-gtk3
> 
> Could you please 
> * completely switch to the gtk3 fork of geany-plugins,
This ebuild is the geany.org version

> * or offer a geany-plugings-gtk3 ebuild in addition to geany-plugins,
By all means submit an ebuild if you wish. I have no idea if it would be accepted.

> * or apply the diff's between the upstream plugins and the gtk3 fork
>   as a patch in the geany-plugins ebuild?
Normal Gentoo convention is to apply patches only from upstream, which I completely support.

There are a number of GTK+3 fixes submitted as PRs:
https://github.com/geany/geany-plugins/pulls

Some of these were reviewed but the submitter never replied, an opportunity to get involved there with any you want and get them sorted for everyone (including Gentoo).
Comment 2 Klaus Kusche 2017-11-25 20:44:11 UTC
(In reply to Chris Mayo from comment #1)
> (In reply to Klaus Kusche from comment #0)
> > Geany 1.32 und geany-plugins-1.32 have been released upstream,
> > but only geany has been updated in gentoo, plugins are still 1.31.
> 1.32 is in the queue:
> https://github.com/gentoo/gentoo/pull/6262

Thanks.

> > Please also update geany-plugins, their versions must be kept in sync.
> Which 1.31 plugins are not working with Geany 1.32?
> Some 1.32 plugins will not work with 1.31 hence the dependency bump in the
> PR above.

I've not tested if any 1.31 plugins stopped working with geany 1.32,
but I had version incompatibilities in the past.
"Extra selection" broke quite often (and is still not completely fixed), 
the column shifter also had version problems in the past, ...

> There are a number of GTK+3 fixes submitted as PRs:
> https://github.com/geany/geany-plugins/pulls
> 
> Some of these were reviewed but the submitter never replied, an opportunity
> to get involved there with any you want and get them sorted for everyone
> (including Gentoo).

The one I need already seems to be actively worked on.
Comment 3 Kristoffer Bernssen 2017-11-28 09:10:01 UTC
https://bugs.gentoo.org/638160

it do exist here in a way as a snapshot version. i run it myself
Comment 4 Chris Mayo 2017-11-29 20:45:34 UTC
> "Extra selection" broke quite often (and is still not completely fixed), 
> the column shifter also had version problems in the past, ...
> 

Useful to know. A matching Geany version could be forced in the ebuild, but that will reduce the choice for users with plugins that are working - plus Geany is likely to be updated in the tree first (with 1.32 it had to be).

I think the most important thing is that they are stabilised together.
Comment 5 Chris Mayo 2018-12-17 20:19:43 UTC
markdown and scope plugins now available for GTK+ 3 in 1.34, PR here:
https://github.com/gentoo/gentoo/pull/10654
Comment 6 Chris Mayo 2019-10-03 18:23:58 UTC
debugger plugin now available for GTK 3 in 1.36, PR here:
https://github.com/gentoo/gentoo/pull/13135
Comment 7 Andreas Sturmlechner gentoo-dev 2020-03-22 21:51:04 UTC
What's the status here?
Comment 8 Chris Mayo 2020-03-23 20:09:16 UTC
The remaining enabled plugins that are GTK 2 only are multiterm and python which haven't seen any updates for 4 and 3 years respectively. I'm quite happy to disable them. I've only kept GTK 2 support at all to be in step with dev-util/geany.
Comment 9 Andreas Sturmlechner gentoo-dev 2020-04-10 14:17:14 UTC
Thanks for checking back. Waiting for your PR then, and afterwards let's make a stable run + cleanup. ;)
Comment 10 Chris Mayo 2020-04-10 18:32:37 UTC
Create PR for geany-plugins-1.36-r2:
https://github.com/gentoo/gentoo/pull/15293
Comment 11 Andreas Sturmlechner gentoo-dev 2020-04-10 19:27:01 UTC
Thanks for the PR! Btw arches were dropped in commit c77dc476 but meanwhile at least ~ppc64 was added to dev-libs/libgit2, so, a re-keywording bug is possible. I would not bother so much for ~alpha and ~ia64 though, which will be lost by cleanup.
Comment 12 Larry the Git Cow gentoo-dev 2020-04-10 20:25:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97cfb74fcd7df87b747bbe8c09c54cfddf3dc51b

commit 97cfb74fcd7df87b747bbe8c09c54cfddf3dc51b
Author:     Chris Mayo <aklhfex@gmail.com>
AuthorDate: 2020-04-10 18:29:27 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-10 20:24:38 +0000

    dev-util/geany-plugins: remove support for geanypy and multiterm
    
    Not updated for at least 3 years, GTK 2 only and blocking dev-python/pygtk
    removal.
    
    Closes: https://bugs.gentoo.org/638774
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Chris Mayo <aklhfex@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/15293
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../geany-plugins/geany-plugins-1.36-r2.ebuild     | 126 +++++++++++++++++++++
 1 file changed, 126 insertions(+)
Comment 13 Larry the Git Cow gentoo-dev 2020-04-14 19:17:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26c5af99918b59c0112ae4b0df08c2c8760ce081

commit 26c5af99918b59c0112ae4b0df08c2c8760ce081
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-04-13 19:02:29 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-14 19:02:33 +0000

    dev-util/geany: Drop 1.30.1, 1.34.1, 1.35
    
    Bug: https://bugs.gentoo.org/638774
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-util/geany/Manifest            |  3 --
 dev-util/geany/geany-1.30.1.ebuild | 67 -------------------------------
 dev-util/geany/geany-1.34.1.ebuild | 80 -------------------------------------
 dev-util/geany/geany-1.35.ebuild   | 82 --------------------------------------
 4 files changed, 232 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9af08db71c770a1183f1e2ba4f195a45dde2ee31

commit 9af08db71c770a1183f1e2ba4f195a45dde2ee31
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-04-13 18:59:43 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-14 19:02:33 +0000

    dev-util/geany-plugins: Drop 1.30, 1.34-r1, 1.35, 1.36-r1
    
    Bug: https://bugs.gentoo.org/638774
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-util/geany-plugins/Manifest                    |   3 -
 dev-util/geany-plugins/geany-plugins-1.30.ebuild   | 146 --------------------
 .../geany-plugins/geany-plugins-1.34-r1.ebuild     | 148 --------------------
 dev-util/geany-plugins/geany-plugins-1.35.ebuild   | 147 --------------------
 .../geany-plugins/geany-plugins-1.36-r1.ebuild     | 153 ---------------------
 dev-util/geany-plugins/metadata.xml                |   6 -
 6 files changed, 603 deletions(-)