Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 638412 - sys-fs/multipath-tools build error with =sys-libs/glibc-2.26-r3
Summary: sys-fs/multipath-tools build error with =sys-libs/glibc-2.26-r3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://bugzilla.redhat.com/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks: glibc-2.26 glibc-2.26-stable
  Show dependency tree
 
Reported: 2017-11-21 22:26 UTC by Thomas Bettler
Modified: 2018-05-01 14:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to include sysmacros where those are still needed (sysmacros.patch,1.20 KB, patch)
2017-11-21 22:26 UTC, Thomas Bettler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Bettler 2017-11-21 22:26:52 UTC
Created attachment 505586 [details, diff]
patch to include sysmacros where those are still needed

Build fails for sys-fs/multipath (0.5* trough 0.7*) with newer glibc with error message:

discovery.c: In function ‘path_discover’:
discovery.c:130:5: error: implicit declaration of function ‘major’ [-Werror=implicit-function-declaration]
     major(devnum), minor(devnum));
     ^~~~~
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-01-17 12:10:11 UTC
multipath-tools-0.7.4 builds fine on my system with sys-libs/glibc-2.26-r5

Can you please verify and report back?
Comment 2 Thomas Bettler 2018-02-11 17:57:33 UTC
works fine now, great, thanks.
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2018-04-28 19:59:20 UTC
Please either backport the fix or stabilize newer multipath-tools!
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2018-05-01 14:12:34 UTC
(In reply to Andreas K. Hüttel from comment #3)
> Please either backport the fix or stabilize newer multipath-tools!

This is already fixed in latest stable 0.6.4-r1. 

commit 464cae287dd74763239b33d48b871224a888cb50
Author:     Anthony Ryan <anthonyryan1@gmail.com>
AuthorDate: Wed Jan 4 16:51:16 2017 -0500
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: Sat Jan 7 13:49:28 2017 -0800

    sys-fs/multipath-tools: Version bump 0.6.4
    
    Gentoo-bug: 604228
    
    * Include patch for sysmacros
    * Remove patch for makefile (building still performs a few unnecessary
      operations, but the cost is negligible compared to the cost of
      carrying yet another patch.
    * Remove COMMIT_ID
    * Remove some unnecessary definitions
    * Include a way to disable ceph when building
    * Add linux-info to check for CONFIG_DM_MULTIPATH
    
    Package-Manager: Portage-2.3.3, Repoman-2.3.1
    (cherry picked from commit ef97e67d7cb4b009af471dd2fafdf463960a909d)
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

 sys-fs/multipath-tools/Manifest                                    |  1 +
 sys-fs/multipath-tools/files/multipath-tools-0.6.4-sysmacros.patch | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 sys-fs/multipath-tools/metadata.xml                                | 11 ++++++----
 sys-fs/multipath-tools/multipath-tools-0.6.4.ebuild                | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 160 insertions(+), 4 deletions(-)