Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636484 - app-emulation/virtualbox-modules-5.1.30: support to kernel 4.14-rcX
Summary: app-emulation/virtualbox-modules-5.1.30: support to kernel 4.14-rcX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 3 votes (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
: 638692 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-04 09:18 UTC by Fabio Rossi
Modified: 2017-11-29 17:27 UTC (History)
18 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with patches for virtualbox-modules-5.1.30 (virtualbox-modules-5.1.30.ebuild,1.75 KB, text/plain)
2017-11-25 16:00 UTC, Mattia Rossi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Rossi 2017-11-04 09:18:45 UTC
Building latest virtualbox-modules version in portage against kernel 4.14-rcX leads to a failure:

/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c: In function ‘vboxNetFltLinuxSkBufFromS
G’:
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c:726:24: error: ‘SKB_GSO_UDP’ undeclared
 (first use in this function)
             fGsoType = SKB_GSO_UDP;
                        ^
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c:726:24: note: each undeclared identifier is reported only once for each function it appears in
In file included from /var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/include/iprt/types.h:29:0,
                 from /var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/r0drv/linux/the-linux-kernel.h:34,
                 from /var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c:24:
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c: In function ‘vboxNetFltLinuxCanForwardAsGso’:
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c:1112:53: error: ‘SKB_GSO_UDP’ undeclared (first use in this function)
     if (RT_UNLIKELY( skb_shinfo(pSkb)->gso_type & ~(SKB_GSO_UDP | SKB_GSO_DODGY | SKB_GSO_TCPV6 | SKB_GSO_TCPV4) ))
                                                     ^
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/include/iprt/cdefs.h:1612:53: note: in definition of macro ‘RT_UNLIKELY’
 #  define RT_UNLIKELY(expr)     __builtin_expect(!!(expr), 0)
                                                     ^
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c: In function ‘vboxNetFltLinuxForwardToIntNet’:
/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.c:1405:47: error: ‘SKB_GSO_UDP’ undeclared (first use in this function)
         if (   (skb_shinfo(pBuf)->gso_type & (SKB_GSO_UDP | SKB_GSO_TCPV6 | SKB_GSO_TCPV4))
                                               ^
make[4]: *** [/usr/src/linux.git/scripts/Makefile.build:314: /var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt/linux/VBoxNetFlt-linux.o] Error 1
make[3]: *** [/usr/src/linux.git/Makefile:1503: _module_/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt] Error 2
make[3]: Leaving directory '/usr/src/linux.git'
make[2]: *** [Makefile:146: sub-make] Error 2
make[2]: Leaving directory '/usr/src/linux.git'
make[1]: *** [Makefile:211: vboxnetflt] Error 2
make[1]: Leaving directory '/var/tmp/portage/app-emulation/virtualbox-modules-5.1.30/work/vboxnetflt'
make: *** [Makefile:44: all] Error 1
 * ERROR: app-emulation/virtualbox-modules-5.1.30::gentoo failed (compile phase):
 *   emake failed
Comment 1 Fabio Rossi 2017-11-04 09:19:19 UTC
Please see here for a patch https://gist.github.com/herbmillerjr/039c129e9c25b047b906e19ad1f23a59
Comment 2 Conrad Kostecki gentoo-dev 2017-11-13 22:41:19 UTC
(In reply to Fabio Rossi from comment #1)
> Please see here for a patch
> https://gist.github.com/herbmillerjr/039c129e9c25b047b906e19ad1f23a59

Thanks! Did worked for me. I was able to compiles virtualbox-modules with 4.14.
Comment 3 Aleksandr K. 2017-11-14 12:01:00 UTC
Thank you, with kernel 4.14.0 and this patch can compile virtualbox-modules.

W/o patch - was compilation error.
Comment 4 Silvio 2017-11-18 17:57:17 UTC
When it will be included in the main stream?
Comment 5 Ivan Iraci 2017-11-20 14:39:46 UTC
Same problem here.
Comment 6 Juergen Rose 2017-11-23 09:05:02 UTC
The same error happens with 4.13.12-gentoo, if  /usr/src/linux is a link to linux-4.14.0.
Comment 7 Juergen Rose 2017-11-23 09:12:40 UTC
(In reply to Fabio Rossi from comment #1)
> Please see here for a patch
> https://gist.github.com/herbmillerjr/039c129e9c25b047b906e19ad1f23a59

The patch seems to work.
Comment 8 Silvio 2017-11-23 10:21:09 UTC
(In reply to Juergen Rose from comment #6)
> The same error happens with 4.13.12-gentoo, if  /usr/src/linux is a link to
> linux-4.14.0.

Juergen, if the link is to 4.14.0 it is creating module for that kernel! 
It is wrong to say that happens with other kernel.
Comment 9 Herb Miller Jr. 2017-11-23 23:13:48 UTC
You're going to need this one too now.
https://gist.github.com/herbmillerjr/e62ef784603464cb945038debe9a088d
Comment 10 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-11-24 20:05:48 UTC
*** Bug 638692 has been marked as a duplicate of this bug. ***
Comment 11 Mattia Rossi 2017-11-25 16:00:23 UTC
Created attachment 506588 [details]
ebuild with patches for virtualbox-modules-5.1.30

The above mentioned patches for 5.1.28 and 5.1.30 both work with kernel 4.14.2.

I've attached my ebuild.
Comment 12 Chris Faulkner 2017-11-26 22:22:31 UTC
I have tried the patch, the ebuild, nothing will get me past the -modules part

 * Applying virtualbox-modules-5.1.30-timer-setup.patch ...
patch: **** malformed patch at line 35: }
Comment 14 Guilherme Amadio gentoo-dev 2017-11-27 14:08:18 UTC
I applied the udp patch to 5.1.30 and it at least compiled for me with gentoo-sources-4.14.2.
Comment 15 Guilherme Amadio gentoo-dev 2017-11-27 14:18:16 UTC
(In reply to Oleksandr Trotsenko from comment #13)
> The 2 patches together worked for me:
> *
> https://gist.githubusercontent.com/herbmillerjr/
> 039c129e9c25b047b906e19ad1f23a59/raw/
> 3b8ebadec915522f25d265b4952cb071140cd992/virtualbox-modules-5.1.28-udp.patch
> *
> https://gist.githubusercontent.com/herbmillerjr/
> e62ef784603464cb945038debe9a088d/raw/
> bc6514c9a1adecb0e99775e64f2486b3073acdfb/virtualbox-modules-5.1.30-timer-
> setup.patch
> 
> Kernel: linux-4.14.2-gentoo
> Virtualbox package: app-emulation/virtualbox-modules-5.1.30
> 
> Cheers!

Could someone please comment on why the second patch above is necessary?
I used only the first patch on 5.1.30.
Comment 16 Larry the Git Cow gentoo-dev 2017-11-27 23:00:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=148d258205d9dac8c75d6b5ae041e6a96de5b075

commit 148d258205d9dac8c75d6b5ae041e6a96de5b075
Author:     Guilherme Amadio <amadio@gentoo.org>
AuthorDate: 2017-11-27 14:02:30 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2017-11-27 23:00:01 +0000

    app-emulation/virtualbox-modules: support linux 4.14.x, fix bug #636484
    
    SKB_GSO_UDP has been removed in linux by commit
    d9d30adf56777c402c0027c0e6ae21f17cc0a365.
    
    Reported-by: Fabio Rossi <rossi.f@inwind.it>
    Suggested-by: Herb Miller Jr. <herb@hlmjr.com>
    
    Closes: https://bugs.gentoo.org/636484
    
    Package-Manager: Portage-2.3.16, Repoman-2.3.6

 app-emulation/virtualbox-modules/Manifest          |  2 +-
 .../files/virtualbox-modules-5.1.30-udp.patch      | 35 ++++++++++++++++++++++
 .../virtualbox-modules-5.1.30.ebuild               |  4 +++
 3 files changed, 40 insertions(+), 1 deletion(-)
Comment 17 Herb Miller Jr. 2017-11-29 17:27:10 UTC
(In reply to Guilherme Amadio from comment #15)
> (In reply to Oleksandr Trotsenko from comment #13)
> > The 2 patches together worked for me:
> > *
> > https://gist.githubusercontent.com/herbmillerjr/
> > 039c129e9c25b047b906e19ad1f23a59/raw/
> > 3b8ebadec915522f25d265b4952cb071140cd992/virtualbox-modules-5.1.28-udp.patch
> > *
> > https://gist.githubusercontent.com/herbmillerjr/
> > e62ef784603464cb945038debe9a088d/raw/
> > bc6514c9a1adecb0e99775e64f2486b3073acdfb/virtualbox-modules-5.1.30-timer-
> > setup.patch
> > 
> > Kernel: linux-4.14.2-gentoo
> > Virtualbox package: app-emulation/virtualbox-modules-5.1.30
> > 
> > Cheers!
> 
> Could someone please comment on why the second patch above is necessary?
> I used only the first patch on 5.1.30.

It's not. That was my mistake because I keep forgetting I'm ahead of everyone else's system. The second one won't be necessary until kernel 4.15.