Bug 635036 – kde-frameworks/kdelibs4support-5.39.0 with openssl 1.1.0f error: Expected ';' at end of member declaration

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Mark Wright 2017-10-22 00:24:05 UTC]

Created attachment 499598 [details, diff]
kdelibs4support-5.39-openssl-1.1_p1.patch

kde-frameworks/kdelibs4support-5.39.0 build fails with dev-libs/openssl-1.1.0f:

Building CXX object src/CMakeFiles/KF5KDELibs4Support.dir/kssl/ksslcertchain.cpp.o
cd /var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build/src && /usr/bin/x86_64-pc-linux-gnu-g++ -DKCOREADDONS_LIB -DKDELIBS4SUPPORT_DEPRECATED="" -DKDELIBS4SUPPORT_DEPRECATED_EXPORT=KDELIBS4SUPPORT_EXPORT -DKDELIBS4SUPPORT_DEPRECATED_NO_EXPORT=KDELIBS4SUPPORT_NO_EXPORT -DKF5KDELibs4Support_EXPORTS -DKGUIADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_PRINTSUPPORT_LIB -DQT_SVG_LIB -DQT_TESTCASE_BUILDDIR=\"/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build\" -DQT_TESTLIB_LIB -DQT_USE_FAST_OPERATOR_PLUS -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"kdelibs4support\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build/src -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build/src/KF5KDELibs4Support_autogen/include -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build/src/../../.. -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kdecore -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kdeui -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kio -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build/src/kssl -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kparts -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/solid -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0_build/src/.. -I/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0 -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtDBus -isystem /usr/include/qt5/QtPrintSupport -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5 -isystem /usr/include/KF5/KCrash -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KConfigWidgets -isystem /usr/include/KF5/KCodecs -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/qt5/QtXml -isystem /usr/include/KF5/KAuth -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KIOFileWidgets -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KBookmarks -isystem /usr/include/KF5/KItemViews -isystem /usr/include/KF5/KXmlGui -isystem /usr/include/KF5/Solid -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5/KNotifications -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KGuiAddons -isystem /usr/include/KF5/KUnitConversion -isystem /usr/include/KF5/KTextWidgets -isystem /usr/include/KF5/SonnetUi -isystem /usr/include/KF5/KParts -isystem /usr/include/KF5/KGlobalAccel -isystem /usr/include/qt5/QtSvg -isystem /usr/include/qt5/QtTest -isystem /usr/include/qt5/QtX11Extras   -DQT_NO_DEBUG -DNDEBUG -O2 -march=native -ggdb -fvar-tracking-assignments -fvar-tracking -pipe -fno-delete-null-pointer-checks -flifetime-dse=1 -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -pedantic -Wsuggest-override -fvisibility=hidden -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++11 -o CMakeFiles/KF5KDELibs4Support.dir/kssl/ksslcertchain.cpp.o -c /var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/ksslcertchain.cpp
In file included from /var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/ksslx509v3.cpp:25:0:
/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/kopenssl.h:503:11: error: expected ‘;’ at end of member declaration
     char *OPENSSL_sk_pop(STACK *s);
           ^~~~~~~~~~~~~~
/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/kopenssl.h:503:32: error: expected ‘)’ before ‘*’ token
     char *OPENSSL_sk_pop(STACK *s);
                                ^
/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/kopenssl.h:45:15: error: ‘_STACK’ has not been declared
 #define STACK _STACK
               ^
/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/kopenssl.h:508:26: note: in expansion of macro ‘STACK’
     void OPENSSL_sk_free(STACK *s);
                          ^~~~~
/var/tmp/portage/kde-frameworks/kdelibs4support-5.39.0/work/kdelibs4support-5.39.0/src/kssl/kopenssl.h:45:15: error: ‘_STACK’ has not been declared
 #define STACK _STACK
               ^

I found the kdelibs4support-5.39-openssl-1.1_p1.patch patch here:
https://phabricator.kde.org/file/data/b62bffl57iddkyjypx42/PHID-FILE-2onif2i5wkdkx7m2am4i/D6665.diff

[Comment 1 Mark Wright 2017-10-22 00:26:04 UTC]

Created attachment 499600 [details, diff]
kdelibs4support-5.39-openssl-1.1_p2.patch

The second patch comes from this suggestion:

http://pkgsrc-users.netbsd.narkive.com/nTdaOFE4/openssl-breakage-apache2-kdelibs3-mutt-devel
...
Christos Zoulas 8 years ago
PermalinkRaw Message
  Post by Thomas Klausner
    Post by Thor Lancelot Simon
    The STACK errors are just annoying. It's one of those pseudo-openssl-
    internal parts of the API (like OPENSSL_malloc()/OPENSSL_free()) that
    is documented in the manual pages for other parts of the API and can't
    be avoided if you want to do certain things that are allegedly supported;
    yet since it's not directly documented itself I guess they feel free to
    change it and break people's application code.

  Do you know what STACK should be replaced with?

try typedef void *STACK;

christos
...

[Comment 2 Andreas Sturmlechner 2017-10-22 12:07:39 UTC]

Was the second patch posted upstream yet? It would be good to have this asap in master to get enough testing for 5.40.0.

[Comment 3 Andreas Sturmlechner 2018-06-24 19:52:30 UTC]

5.47.0 built fine for me.