Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 634228 - dev-util/cmake: can virtx be removed from tests?
Summary: dev-util/cmake: can virtx be removed from tests?
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-14 10:09 UTC by Rolf Eike Beer
Modified: 2017-10-19 15:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer 2017-10-14 10:09:50 UTC
I don't see any reason for the virtx in CMake tests. I have machines that run the nightly test suite every day, which don't have any X server (a T5120 doesn't even have a monitor plug). When I remove the virtx I can run the testsuite through ebuild also without problems. I don't think there really is any test that requires X, and if it does the virtx usage should probably depend on the "qt5" use flag.

Reproducible: Always
Comment 1 Michael Palimaka (kensington) gentoo-dev 2017-10-19 10:36:47 UTC
Thanks!
Comment 2 Larry the Git Cow gentoo-dev 2017-10-19 10:36:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b5d2bedf7dee3fd132ea3346bca0cc519d5c368

commit 7b5d2bedf7dee3fd132ea3346bca0cc519d5c368
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2017-10-19 10:36:33 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2017-10-19 10:36:47 +0000

    dev-util/cmake: virtualx is not required for tests
    
    Closes: https://bugs.gentoo.org/634228
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 dev-util/cmake/cmake-3.9.4.ebuild | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Comment 3 Andreas Sturmlechner gentoo-dev 2017-10-19 15:46:32 UTC
commit 4c5a71f593ee14dee9af88eac235615a7c3d2ad3
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Thu Oct 19 15:36:17 2017 +0200

    Revert "dev-util/cmake: virtualx is not required for tests"
    
    This reverts commit 7b5d2bedf7dee3fd132ea3346bca0cc519d5c368.
    virtualx is still required for at least 11 tests.