Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633714 - dev-util/ninja-1.7.2 needs a GetLoadAverage implementation for uclibc-ng
Summary: dev-util/ninja-1.7.2 needs a GetLoadAverage implementation for uclibc-ng
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on: 634052
Blocks: uclibc-porting
  Show dependency tree
 
Reported: 2017-10-07 18:18 UTC by René Rhéaume
Modified: 2017-10-11 21:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ninja-uclibc.patch (ninja-uclibc.patch,732 bytes, patch)
2017-10-07 18:18 UTC, René Rhéaume
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René Rhéaume 2017-10-07 18:18:21 UTC
Created attachment 498054 [details, diff]
ninja-uclibc.patch

dev-util/ninja-1.7.2 does not compile as is on uclibc-ng, because the default GetLoadAverage method expects a a getloadavg function from a libc, but uclibc-ng does not provide it. The following patch implements the method using the sysinfo system call (Linux-specific but uclibc-ng is Linux-specific)

Also added a fix to build on older uclibc-ng releases, based on traditional C libraries layout. It should not interfere with the musl-inspired "put everything in libc.so.0 and make symlinks for traditional library names" approach.
Comment 1 Mike Gilbert gentoo-dev 2017-10-11 21:19:59 UTC
This is already fixed in >=dev-util/ninja-1.8.0.

https://github.com/ninja-build/ninja/commit/76abf78aac8c56606fb52ea874873d790b9044da