games-misc/fortune-mod-all should probably only include games-misc/fortune-mod-sp-fortunes when the 'offensive' USE flag is set.
Besides the taste of the quotes, I even suggest to treeclean this: Southpark jokes/quotes are copyrighted and likely upstream had to take it down. https://en.wikiquote.org/wiki/Wikiquote:Limits_on_quotations We should check, if we need a RESTRICT="mirror" for most fortune lists. SRC_URI and HOMEPAGE are down already. $ GENTOO_MIRRORS="" ebuild fortune-mod-sp-fortunes-0.2.ebuild fetch Appending /usr/local/overlays/gentoo to PORTDIR_OVERLAY... >>> Downloading 'http://eelco.is.a.rootboy.net/fortunecookies/SP-0.2.tar.gz' --2017-10-14 20:45:11-- http://eelco.is.a.rootboy.net/fortunecookies/SP-0.2.tar.gz Resolving eelco.is.a.rootboy.net... failed: Name or service not known. wget: unable to resolve host address ‘eelco.is.a.rootboy.net’ !!! Couldn't download 'SP-0.2.tar.gz'. Aborting.
the package fortune-mod-sp-fortunes is set to LICENSE="GPL-2" which is obviously wrong.
This is similar to the fortune-mod-* packages in bug 450450 where we used LICENSE="fairuse". That may or may not apply here (and it may be questionable for those other packages). The individual quotes are very short, so that each taken for its own presumably falls under fair use. If that still applies to the collection is another question.
Exactly. A single Starwars joke in a scientific thesis with proper attribution would be fine. But here we see a large database alone. Its license is the same as the license of the original source.
fortune-mod-all-3 no longer depends on games-misc/fortune-mod-sp-fortunes. Closing. commit 3396e6f2acb155e5a63e06a34350c83cbf7c90ac Author: Ulrich Müller <ulm@gentoo.org> Date: Tue Feb 4 14:49:16 2020 +0100 games-misc/fortune-mod-all: Don't depend on last-rited modules. Reviewed-by: James Le Cuirot <chewi@gentoo.org> Package-Manager: Portage-2.3.87, Repoman-2.3.20 Signed-off-by: Ulrich Müller <ulm@gentoo.org>
