Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 632128 - sci-physics/root-5.34.36 installs a symlink to ${ED}usr/portage/licenses
Summary: sci-physics/root-5.34.36 installs a symlink to ${ED}usr/portage/licenses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-27 09:15 UTC by Ulrich Müller
Modified: 2018-07-05 11:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2017-09-27 09:15:28 UTC
In src_install:

    dosym "${ED}"usr/portage/licenses/LGPL-2.1 "${DOC_DIR}/LICENSE"

It is not guaranteed that /usr/portage exists on the user's system (and see bug 373349 why using PORTDIR instead would not be a goI'd suggest to restore installation of COPYING in gpredict-1.1-doc.patch and let the package's build system install it from the tarball.od idea either). Besides, the symlink points to ED and its target will be gone after cleanup of the build directory.

I'd suggest to install the LICENSE file from the tarball instead.
Comment 1 Ulrich Müller gentoo-dev 2017-09-27 09:18:08 UTC
(In reply to Ulrich Müller from comment #0)
[Sorry, copy&paste error. Here we go again:]


In src_install:

    dosym "${ED}"usr/portage/licenses/LGPL-2.1 "${DOC_DIR}/LICENSE"

It is not guaranteed that /usr/portage exists on the user's system (and see bug 373349 why using PORTDIR instead would not be a good idea either). Besides, the symlink points to ED and its target will be gone after cleanup of the build directory.

I'd suggest to install the LICENSE file from the tarball instead.
Comment 2 Larry the Git Cow gentoo-dev 2018-07-05 11:15:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f3fff3e43dbf12f9b561b56d8530a21d5c4d4163

commit f3fff3e43dbf12f9b561b56d8530a21d5c4d4163
Author:     Guilherme Amadio <amadio@gentoo.org>
AuthorDate: 2018-07-05 09:27:18 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2018-07-05 11:05:00 +0000

    sci-physics/root: drop old
    
    Closes: https://bugs.gentoo.org/651000
    Closes: https://bugs.gentoo.org/620754
    Closes: https://bugs.gentoo.org/632128
    Closes: https://bugs.gentoo.org/638422
    Closes: https://bugs.gentoo.org/649992
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 sci-physics/root/Manifest                          |   1 -
 .../root/files/root-5.28.00b-glibc212.patch        |  11 -
 sci-physics/root/files/root-5.32.00-cfitsio.patch  |  13 -
 sci-physics/root/files/root-5.32.00-chklib64.patch |  24 --
 sci-physics/root/files/root-5.32.00-dotfont.patch  |  58 ---
 .../root/files/root-5.34.05-nobyte-compile.patch   | 137 -------
 sci-physics/root/files/root-5.34.13-unuran.patch   |  40 --
 sci-physics/root/files/root-5.34.26-ldflags.patch  |  19 -
 sci-physics/root/metadata.xml                      |   3 -
 sci-physics/root/root-5.34.36.ebuild               | 441 ---------------------
 10 files changed, 747 deletions(-)