Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 631382 - media-libs/openexr-2.2.0 - openexr-2.2.0-fix-build-system.patch breaks build system: In file included from backend/povray.cpp:102:0: /usr/include/OpenEXR/OpenEXRConfig.h:83:40: error: too many decimal points in number
Summary: media-libs/openexr-2.2.0 - openexr-2.2.0-fix-build-system.patch breaks build ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-09-19 07:24 UTC by Honza Macháček
Modified: 2017-09-28 12:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Diff to correct openexr-2.2.0-fix-build-system.patch (openexr-2.2.0-fix-build-system.patch.diff,386 bytes, patch)
2017-09-19 07:24 UTC, Honza Macháček 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Honza Macháček 2017-09-19 07:24:49 UTC 
Created attachment 495320 [details, diff]
Diff to correct openexr-2.2.0-fix-build-system.patch

openexr-2.2.0-fix-build-system.patch incorrectly removes quotes from the definitions of the macros OPENEXR_VERSION_STRING and OPENEXR_PACKAGE_STRING in the installed header file OpenEXRConfig.h. That in turn breaks building of packages that use media-libs/openexr — seen with media-gfx/povray:

In file included from backend/povray.cpp:102:0:
/usr/include/OpenEXR/OpenEXRConfig.h:83:40: error: too many decimal points in number
 #define OPENEXR_PACKAGE_STRING OpenEXR 2.2.0                                        ^
/usr/include/OpenEXR/OpenEXRConfig.h:83:40: note: in definition of macro ‘OPENEXR_PACKAGE_STRING’
 #define OPENEXR_PACKAGE_STRING OpenEXR 2.2.0
                                        ^~~~~
backend/povray.cpp: In function ‘void {anonymous}::BuildInitInfo(POVMSObjectPtr)’:
/usr/include/OpenEXR/OpenEXRConfig.h:83:32: error: ‘OpenEXR’ was not declared in this scope
 #define OPENEXR_PACKAGE_STRING OpenEXR 2.2.0
                                ^
/usr/include/OpenEXR/OpenEXRConfig.h:83:32: note: in definition of macro ‘OPENEXR_PACKAGE_STRING’
 #define OPENEXR_PACKAGE_STRING OpenEXR 2.2.0
                                ^~~~~~~
Comment 1 Larry the Git Cow gentoo-dev 2017-09-28 12:50:18 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd4ad81b5d8ba426b3d2d75b27f9993119f73e30

commit dd4ad81b5d8ba426b3d2d75b27f9993119f73e30
Author:     Jonathan Scruggs <j.scruggs@gmail.com>
AuthorDate: 2017-09-23 13:04:39 +0000
Commit:     Alexis Ballier <aballier@gentoo.org>
CommitDate: 2017-09-28 12:45:07 +0000

    media-libs/openexr: Revision bump to 2.2.0-r2
    
    * Added patch to fix a typo in the C bindings
    * Added patch to install the missing header files
    * Added patch to fix security issues:
      CVE-2017-9110, CVE-2017-9111, CVE-2017-9112, CVE-2017-9113,
      CVE-2017-9114, CVE-2017-9115, CVE-2017-9116
    * Fixed build system patch
    * Added tabs in the metadata.xml file
    
    Closes: https://bugs.gentoo.org/616996
    Closes: https://bugs.gentoo.org/631382
    Closes: https://bugs.gentoo.org/620324

 ....2.0-CVE-2017-9110-to-9116-security-fixes.patch | 98 ++++++++++++++++++++++
 .../openexr-2.2.0-Fix-typo-in-C-bindings.patch     | 26 ++++++
 ...penexr-2.2.0-Install-missing-header-files.patch | 60 +++++++++++++
 .../files/openexr-2.2.0-fix-build-system.patch     |  4 +-
 media-libs/openexr/metadata.xml                    |  9 +-
 media-libs/openexr/openexr-2.2.0-r2.ebuild         | 64 ++++++++++++++
 6 files changed, 256 insertions(+), 5 deletions(-)