630634 – dev-lang/crystal-0.23.1 doesn't merge with LLVM 5.x

Bug 630634 - dev-lang/crystal-0.23.1 doesn't merge with LLVM 5.x

Summary: dev-lang/crystal-0.23.1 doesn't merge with LLVM 5.x

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Lixiao Chen

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	systemwide-clang
	Show dependency tree

Reported:	2017-09-11 07:01 UTC by Renich Bon Ciric
Modified:	2017-09-16 16:46 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (build.log,80.54 KB, text/x-log) 2017-09-11 07:01 UTC, Renich Bon Ciric	Details
LLVM patch (llvm5.patch,34.18 KB, patch) 2017-09-15 23:59 UTC, Renich Bon Ciric	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Renich Bon Ciric 2017-09-11 07:01:06 UTC

Created attachment 493816 [details]
Build log

Fixed here: https://github.com/crystal-lang/crystal/pull/4821

Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev

2017-09-15 21:01:58 UTC

I got a bit lost in the list of merges and did not try hard to check which
patches should be backported. Options are:
- someone can attach needed patches to this bugzilla (or send a pull request!)
- we wait for next upstream release and pick it up

Comment 2 Renich Bon Ciric 2017-09-15 23:59:20 UTC

Created attachment 494726 [details, diff]
LLVM patch

This one works.

Comment 3 Larry the Git Cow gentoo-dev

2017-09-16 10:54:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5770fdf734d8d6d4bf95f6778adf0d024efb705

commit a5770fdf734d8d6d4bf95f6778adf0d024efb705
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2017-09-16 10:54:30 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2017-09-16 10:54:30 +0000

    dev-lang/crystal: add llvm-5 support, bug #630634
    
    Thanks to Renich Bon Ciric who found the problem
    and found out the patch!
    
    Reported-by: Renich Bon Ciric
    Closes: https://bugs.gentoo.org/630634
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 dev-lang/crystal/crystal-0.23.1.ebuild             |   1 +
 dev-lang/crystal/files/crystal-0.23.1-llvm-5.patch | 837 +++++++++++++++++++++
 2 files changed, 838 insertions(+)

Comment 4 Renich Bon Ciric 2017-09-16 16:46:12 UTC

Thanks, guys! Next release promises to overcome this hurdle.