Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 630482 - media-gfx/inkscape-0.92.1-r1: fail to compile with poppler-0.58.0 (fix)
Summary: media-gfx/inkscape-0.92.1-r1: fail to compile with poppler-0.58.0 (fix)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jonas Stein
URL:
Whiteboard:
Keywords: PATCH
Depends on: 643836
Blocks: 627536 poppler-0.58.0
  Show dependency tree
 
Reported: 2017-09-09 13:51 UTC by Andrey Volkov
Modified: 2018-04-02 12:55 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add poppler-0.58.0 support to configure.ac (configure-poppler-0.58.0.patch,607 bytes, patch)
2017-09-09 13:59 UTC, Andrey Volkov
Details | Diff
inkscape-0.92.2.ebuild (inkscape-0.92.2.ebuild,3.70 KB, text/plain)
2017-10-25 01:20 UTC, maurerpe
Details
inkscape-0.92.2-poppler.patch (inkscape-0.92.2-poppler.patch,43.11 KB, patch)
2017-10-25 01:24 UTC, maurerpe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Volkov 2017-09-09 13:51:55 UTC
poppler-0.58.0 has a new object API
David Tardon commited a fix to master branch upstream
https://gitlab.com/inkscape/inkscape/commit/9418824967eb4c53371ef8588243fed4cab496e0.patch

Reproducible: Always




extension/internal/pdfinput/pdf-parser.cpp: In member function 'void PdfParser::parse(Object*, GBool)':
extension/internal/pdfinput/pdf-parser.cpp:420:24: error: invalid conversion from 'Object*' to 'int' [-fpermissive]
       obj->arrayGet(i, &obj2);
                        ^~~~~
In file included from /usr/include/poppler/GfxState.h:42:0,
                 from /usr/include/poppler/Gfx.h:41,
                 from extension/internal/pdfinput/pdf-parser.cpp:35:
/usr/include/poppler/Object.h:331:15: note:   initializing argument 2 of 'Object Object::arrayGet(int, int)'
 inline Object Object::arrayGet(int i, int recursion = 0)
               ^~~~~~
Comment 1 Andrey Volkov 2017-09-09 13:59:22 UTC
Created attachment 493520 [details, diff]
Add poppler-0.58.0 support to configure.ac

Add configure-poppler-0.58.0.patch to support upstream fix with inkscape-0.92
Comment 2 maurerpe 2017-10-25 01:20:41 UTC
Created attachment 500004 [details]
inkscape-0.92.2.ebuild

Ebuild that works with any version of poppler.  Tested with app-text/poppler-0.60.1.  Also, bumped to latest 0.92.2.
Comment 3 maurerpe 2017-10-25 01:24:10 UTC
Created attachment 500006 [details, diff]
inkscape-0.92.2-poppler.patch

This is the patch required by the build.  I got the patch from:
https://gitlab.com/inkscape/inkscape/merge_requests/76

https://gitlab.com/inkscape/inkscape/commit/59a7e9551fbe8fae9ff755eae2fa09f31f020f91

https://gitlab.com/inkscape/inkscape/commit/93ccf03162cd2e46d962822d5507865f3451168c

It is basically the concatenation of the two patches referenced by Andrey Volkov.
Comment 4 Jonas Stein gentoo-dev 2017-11-22 07:12:54 UTC
Thank you for the patch.
Comment 5 Larry the Git Cow gentoo-dev 2017-11-22 09:19:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13c2821ca5f72ad8014a07e51289e4e0c7593323

commit 13c2821ca5f72ad8014a07e51289e4e0c7593323
Author:     Jonas Stein <jstein@gentoo.org>
AuthorDate: 2017-11-22 09:18:18 +0000
Commit:     Jonas Stein <jstein@gentoo.org>
CommitDate: 2017-11-22 09:18:32 +0000

    media-gfx/inkscape: Version bump 0.92.2 and ebuild fixes
    
    Version bump to inkscape-0.92.2
    Closes: https://bugs.gentoo.org/627536
    
    Introduced >20kB patch for poppler-0.58.0 for this ebuild
    Bug: https://bugs.gentoo.org/630482
    
    Fixed invalid dependency on app-text/texlive in this ebuild
    Bug: https://bugs.gentoo.org/625906
    
    Also migrated from the obsolete 'fdo-mime' eclass to 'xdg-utils'
    
    Removed eutils which was not needed here anymore since the EPAI=6 bump
    
    Package-Manager: Portage-2.3.15, Repoman-2.3.5

 media-gfx/inkscape/Manifest               |   2 +
 media-gfx/inkscape/inkscape-0.92.2.ebuild | 177 ++++++++++++++++++++++++++++++
 2 files changed, 179 insertions(+)}
Comment 6 Andreas Sturmlechner gentoo-dev 2018-01-07 16:58:17 UTC
So, can this fixed version of inkscape be stabilised?