Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629860 - sys-kernel/gentoo-sources-4.13.0 - /usr/src/linux-4.13.0-gentoo/drivers/video/console/fbcondecor.c:173:8: error: implicit declaration of function ‘strlen_user’
Summary: sys-kernel/gentoo-sources-4.13.0 - /usr/src/linux-4.13.0-gentoo/drivers/video...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard: gentoo-sources-4.13.1
Keywords: InVCS
: 629970 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-09-04 08:41 UTC by Dennis Schridde
Modified: 2017-09-10 16:43 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
4.13 fbcondecor patch (4200_fbcondecor.patch,59.91 KB, patch)
2017-09-04 23:13 UTC, Mike Pagano
Details | Diff
environment (gentoo-sources-4.13.0-environment,159.17 KB, text/plain)
2017-09-05 00:16 UTC, juneau_
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2017-09-04 08:41:14 UTC
/usr/src/linux-4.13.0-gentoo/drivers/video/console/fbcondecor.c: In function ‘fbcon_decor_ioctl_dosetcfg’:                                                                            
/usr/src/linux-4.13.0-gentoo/drivers/video/console/fbcondecor.c:173:8: error: implicit declaration of function ‘strlen_user’ [-Werror=implicit-function-declaration]                  
  len = strlen_user(cfg->theme);                                                           
        ^~~~~~~~~~~                                                                        
cc1: some warnings being treated as errors                                                 
make[5]: *** [/usr/src/linux-4.13.0-gentoo/scripts/Makefile.build:302: drivers/video/console/fbcondecor.o] Error 1                                                                    
make[4]: *** [/usr/src/linux-4.13.0-gentoo/scripts/Makefile.build:561: drivers/video/console] Error 2                                                                                 
make[4]: *** Waiting for unfinished jobs....


# emerge --info gentoo-sources
Portage 2.3.8 (python 2.7.13-final-42, default/linux/amd64/13.0/desktop/plasma/systemd, gcc-6.4.0, glibc-2.25-r4, 4.12.8-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.12.8-gentoo-x86_64-AMD_A10-7800_Radeon_R7,_12_Compute_Cores_4C+8G-with-gentoo-2.4.1
KiB Mem:    14352852 total,   6953516 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Mon, 04 Sep 2017 08:15:01 +0000
Head commit of repository gentoo: 0cb5d0d9b16827c44c75c4ca4d57ead442596e04
sh bash 4.4_p12
ld GNU ld (Gentoo 2.28.1 p1.0) 2.28.1
ccache version 3.3.4 [disabled]
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.2::gentoo
dev-lang/python:          2.7.13-r100::sage-on-gentoo, 3.4.6::gentoo, 3.5.3::gentoo, 3.6.1-r1::gentoo
dev-util/ccache:          3.3.4-r1::gentoo
dev-util/cmake:           3.9.1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r1::gentoo
sys-apps/sandbox:         2.10-r4::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.13.4-r1::gentoo, 1.15.1-r1::gentoo
sys-devel/binutils:       2.28.1::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo, 6.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r4::gentoo
sys-devel/make:           4.2.1-r1::gentoo
sys-kernel/linux-headers: 4.11::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r4::gentoo
Repositories:

gentoo
    location: /var/cache/portage/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.de.gentoo.org/gentoo-portage
    priority: -1000

atom
    location: /var/lib/layman/atom
    sync-type: laymansync
    sync-uri: https://github.com/elprans/atom-overlay.git
    masters: gentoo
    priority: 50

flatpak-overlay
    location: /var/lib/layman/flatpak-overlay
    sync-type: laymansync
    sync-uri: git://github.com/fosero/flatpak-overlay.git
    masters: gentoo
    priority: 50

kde
    location: /var/lib/layman/kde
    sync-type: laymansync
    sync-uri: git://anongit.gentoo.org/proj/kde.git
    masters: gentoo
    priority: 50

sage-on-gentoo
    location: /var/lib/layman/sage-on-gentoo
    sync-type: laymansync
    sync-uri: git://github.com/cschwan/sage-on-gentoo.git
    masters: gentoo science
    priority: 50

science
    location: /var/lib/layman/science
    sync-type: laymansync
    sync-uri: git://anongit.gentoo.org/proj/sci.git
    masters: gentoo
    priority: 50

steam-overlay
    location: /var/lib/layman/steam-overlay
    sync-type: laymansync
    sync-uri: https://github.com/anyc/steam-overlay.git
    masters: gentoo
    priority: 50

local
    location: /var/cache/portage/local
    masters: gentoo
    priority: 100

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-pipe -O2 -march=bdver3"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.1/ext-active/ /etc/php/cgi-php7.1/ext-active/ /etc/php/cli-php7.1/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-pipe -O2 -march=bdver3"
DISTDIR="/var/cache/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --nospinner --verbose-conflicts"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildsyspkg cgroup compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.spline.inf.fu-berlin.de/mirrors/gentoo/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://distfiles.gentoo.org"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j3"
PKGDIR="/var/cache/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac aacplus aacs acl acpi activities alsa amd64 appindicator appstream archive audit avahi bash-completion bdplus berkdb bluetooth bluray branding bs2b bzip2 cairo caps cdda cddb cdio cdr celt chromaprint cjk clang cli colord colorio conntrack cracklib crypt cups cxx d3d9 dbus declarative dirac djvu dri dts dvb dvd dvdr egl emboss encode epub exif fam fax fbcon ffmpeg fftw firefox fish-completion fits flac fontconfig fortran fribidi gdbm geoclue geolocation gif git glamor gles gmp google googledrive gpm gstreamer gtk gtk3 harfbuzz ibus iconv icu idn imlib inotify introspection ipv6 jemalloc jpeg jpeg2k kde kipi kwallet ladspa latex lcms ldap libidn2 libinput libnotify libproxy libsecret libsoxr lua_target_lua5-2 lv2 lz4 lzma lzo mad mercurial metis mjpeg mng mobi modemmanager modplug modules mp3 mp4 mpeg mplayer mtp multilib mysql ncurses netlink networkmanager nls nptl office ogg openal opencl opencv openexr opengl openh264 openmax openmp opus pam pango pcap pch pcre pcre2 pdf phonon plasma png policykit postscript ppds prison pulseaudio python qml qt3support qt4 qt5 raw readline rtmp samba scanner schroedinger sctp sdl seccomp semantic-desktop session sparse speech speex spell ssl startup-notification svg systemd tbb tcpd teamd telepathy tga theora threads tiff timezone truetype tslib udev udisks unicode unwind upnp upnp-av upower usb v4l v4l2 vaapi vdpau vorbis vpx vulkan wavpack wayland webp widgets x264 x265 xattr xcb xcomposite xinerama xkb xml xmp xrandr xscreensaver xv xvid xwayland xz zeroconf zlib" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_EXPERIMENTAL_FEATURES="stage" CALLIGRA_FEATURES="words sheets karbon plan" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx f16c fma3 fma4 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 xop" ELIBC="glibc" ENLIGHTENMENT_MODULES="*" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="joystick libinput" KERNEL="linux" L10N="de en en-GB ar fa tr ja ko zh zh-CN zh-TW" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de en en_GB ar fa tr" LIRC_DEVICES="devinput" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4 python3_5 pypy pypy3" RUBY_TARGETS="ruby22" STEAMGAMES="dirt_rally dont_starve portal source_engine te120 trine2 witcher2" USERLAND="GNU" VIDEO_CARDS="amdgpu" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

sys-kernel/gentoo-sources-4.13.0::gentoo was built with the following:
USE="-build -experimental -symlink" ABI_X86="(64)"
Comment 1 Mads 2017-09-04 12:58:31 UTC
Set CONFIG_FB_CON_DECOR to n to make this compile.
Comment 2 François Valenduc 2017-09-04 14:08:01 UTC
I can confirm this, strlen_user has been removed with commit 82985258390e85289940d3663344197344e071f2 in kernel 4.13
Comment 3 François Valenduc 2017-09-04 14:10:38 UTC
replacing  len = strlen_user(cfg->theme)
 by len = strnlen_user(cfg->theme, MAX_ARG_STRLEN) in fbcon_decor_ioctl_dosetcfg in fbcondecor.c solves the compile error and fbcondecor seems to work correctly. You then need to include linux/binfmts.h for the definition of MAX_ARG_STRLEN
Comment 4 mercuriete 2017-09-04 21:36:44 UTC
i can confirm this

it happen to me as well

  CC      drivers/video/console/fbcondecor.o
drivers/video/console/fbcondecor.c: En la función ‘fbcon_decor_ioctl_dosetcfg’:
drivers/video/console/fbcondecor.c:173:8: error: declaración implícita de la función ‘strlen_user’ [-Werror=implicit-function-declaration]
  len = strlen_user(cfg->theme);
        ^
cc1: algunos avisos se tratan como errores
make[3]: *** [scripts/Makefile.build:303: drivers/video/console/fbcondecor.o] Error 1
make[2]: *** [scripts/Makefile.build:561: drivers/video/console] Error 2
make[1]: *** [scripts/Makefile.build:561: drivers/video] Error 2
make: *** [Makefile:1019: drivers] Error 2
Comment 5 Mike Pagano gentoo-dev 2017-09-04 23:13:37 UTC
Created attachment 492396 [details, diff]
4.13 fbcondecor patch
Comment 6 Mike Pagano gentoo-dev 2017-09-04 23:14:57 UTC
(In reply to François Valenduc from comment #3)
> replacing  len = strlen_user(cfg->theme)
>  by len = strnlen_user(cfg->theme, MAX_ARG_STRLEN) in
> fbcon_decor_ioctl_dosetcfg in fbcondecor.c solves the compile error and
> fbcondecor seems to work correctly. You then need to include linux/binfmts.h
> for the definition of MAX_ARG_STRLEN

Thanks Francois.  Can you please test the patch I attached and let me know if it works?
Comment 7 juneau_ 2017-09-05 00:02:18 UTC
(In reply to Mike Pagano from comment #6)
> (In reply to François Valenduc from comment #3)
> > replacing  len = strlen_user(cfg->theme)
> >  by len = strnlen_user(cfg->theme, MAX_ARG_STRLEN) in
> > fbcon_decor_ioctl_dosetcfg in fbcondecor.c solves the compile error and
> > fbcondecor seems to work correctly. You then need to include linux/binfmts.h
> > for the definition of MAX_ARG_STRLEN
> 
> Thanks Francois.  Can you please test the patch I attached and let me know
> if it works?

Didn't work for me:
Unavailable repository 'haskell' referenced by masters entry in '/var/lib/layman/graaff/metadata/layout.conf'
 * linux-4.13.tar.xz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                                               [ ok ]
 * genpatches-4.13-1.base.tar.xz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                                   [ ok ]
 * genpatches-4.13-1.extras.tar.xz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                                 [ ok ]
 * checking ebuild checksums ;-) ...                                                                                                                    [ ok ]
 * checking miscfile checksums ;-) ...                                                                                                                  [ ok ]
>>> Preparing to unpack ...
>>> Unpacking source...
>>> Unpacking linux-4.13.tar.xz to /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work
>>> Unpacking genpatches-4.13-1.base.tar.xz to /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/patches
>>> Unpacking genpatches-4.13-1.extras.tar.xz to /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/patches
 * Excluding Patch #5000_enable-additional-cpu-optimizations-for-gcc.patch ...                                                                          [ ok ]
 * Applying 1500_XATTR_USER_PREFIX.patch (-p1) ...                                                                                                      [ ok ]
 * Applying 1510_fs-enable-link-security-restrictions-by-default.patch (-p1) ...                                                                        [ ok ]
 * Applying 2300_enable-poweroff-on-Mac-Pro-11.patch (-p1) ...                                                                                          [ ok ]
 * Applying 2600_enable-key-swapping-for-apple-mac.patch (-p1) ...                                                                                      [ ok ]
 * Applying 2900_dev-root-proc-mount-fix.patch (-p1) ...                                                                                                [ ok ]
 * Applying 4200_fbcondecor.patch (-p1) ...                                                                                                             [ ok ]
 * Applying 4400_alpha-sysctl-uac.patch (-p1) ...                                                                                                       [ ok ]
 * Applying 4567_distro-Gentoo-Kconfig.patch (-p1) ...                                                                                                  [ ok ]
>>> Source unpacked in /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work
>>> Preparing source in /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/linux-4.13.0-gentoo ...
 * Applying 4200_fbcondecor.patch ...
1 out of 1 hunk FAILED -- saving rejects to file Documentation/fb/00-INDEX.rej
1 out of 1 hunk FAILED -- saving rejects to file Documentation/fb/fbcondecor.txt.rej
2 out of 2 hunks FAILED -- saving rejects to file drivers/Makefile.rej
1 out of 1 hunk FAILED -- saving rejects to file drivers/video/console/Makefile.rej
2 out of 3 hunks FAILED -- saving rejects to file drivers/video/console/bitblit.c.rej
1 out of 1 hunk FAILED -- saving rejects to file drivers/video/console/cfbcondecor.c.rej
20 out of 23 hunks FAILED -- saving rejects to file drivers/video/console/fbcon.c.rej
1 out of 1 hunk FAILED -- saving rejects to file drivers/video/console/fbcondecor.c.rej
1 out of 1 hunk FAILED -- saving rejects to file drivers/video/console/fbcondecor.h.rej
1 out of 1 hunk FAILED -- saving rejects to file drivers/video/fbdev/Kconfig.rej
1 out of 2 hunks FAILED -- saving rejects to file drivers/video/fbdev/core/fbcmap.c.rej
1 out of 1 hunk FAILED -- saving rejects to file drivers/video/fbdev/core/fbmem.c.rej
1 out of 1 hunk FAILED -- saving rejects to file include/linux/console_decor.h.rej
2 out of 2 hunks FAILED -- saving rejects to file include/linux/console_struct.h.rej
1 out of 1 hunk FAILED -- saving rejects to file include/linux/console_decor.h.rej
2 out of 2 hunks FAILED -- saving rejects to file include/linux/console_struct.h.rej
1 out of 2 hunks FAILED -- saving rejects to file include/linux/fb.h.rej                                                                                [ !! ]
 * ERROR: sys-kernel/gentoo-sources-4.13.0::gentoo failed (prepare phase):
 *   patch -p1  failed with /etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch
 *
 * Call stack:
 *               ebuild.sh, line  115:  Called src_prepare
 *             environment, line 3819:  Called kernel-2_src_prepare
 *             environment, line 2143:  Called eapply_user
 *             environment, line 1077:  Called eapply '/etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch'
 *             environment, line 1047:  Called _eapply_patch '/etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch'
 *             environment, line  985:  Called __helpers_die 'patch -p1  failed with /etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch'
 *   isolated-functions.sh, line  117:  Called die
 * The specific snippet of code:
 *              die "$@"
 *
 * If you need support, post the output of `emerge --info '=sys-kernel/gentoo-sources-4.13.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-kernel/gentoo-sources-4.13.0::gentoo'`.
 * The complete build log is located at '/var/log/portage/sys-kernel:gentoo-sources-4.13.0:20170904-235505.log'.
 * For convenience, a symlink to the build log is located at '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/linux-4.13.0-gentoo'
 * S: '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/linux-4.13.0-gentoo'
Comment 8 juneau_ 2017-09-05 00:16:42 UTC
Created attachment 492398 [details]
environment
Comment 9 juneau_ 2017-09-05 00:39:53 UTC
(In reply to juneau_ from comment #8)
> Created attachment 492398 [details]
> environment
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     scripts/mod/devicetable-offsets.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CHK     kernel/config_data.h
  CC      drivers/video/console/fbcondecor.o
drivers/video/console/fbcondecor.c: In function ‘fbcon_decor_ioctl_dosetcfg’:
drivers/video/console/fbcondecor.c:173:8: error: implicit declaration of function ‘strlen_user’ [-Werror=implicit-function-declaration]
  len = strlen_user(cfg->theme);
        ^~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:302: drivers/video/console/fbcondecor.o] Error 1
make[2]: *** [scripts/Makefile.build:561: drivers/video/console] Error 2
make[1]: *** [scripts/Makefile.build:561: drivers/video] Error 2
make: *** [Makefile:1019: drivers] Error 2
Comment 10 Mike Gilbert gentoo-dev 2017-09-05 15:23:01 UTC
*** Bug 629970 has been marked as a duplicate of this bug. ***
Comment 11 Mike Pagano gentoo-dev 2017-09-05 20:02:43 UTC
(In reply to juneau_ from comment #7)
> (In reply to Mike Pagano from comment #6)
> > (In reply to François Valenduc from comment #3)
> > > replacing  len = strlen_user(cfg->theme)
> > >  by len = strnlen_user(cfg->theme, MAX_ARG_STRLEN) in
> > > fbcon_decor_ioctl_dosetcfg in fbcondecor.c solves the compile error and
> > > fbcondecor seems to work correctly. You then need to include linux/binfmts.h
> > > for the definition of MAX_ARG_STRLEN
> > 
> > Thanks Francois.  Can you please test the patch I attached and let me know
> > if it works?
> 
> Didn't work for me:
> Unavailable repository 'haskell' referenced by masters entry in
> '/var/lib/layman/graaff/metadata/layout.conf'
>  * linux-4.13.tar.xz SHA256 SHA512 WHIRLPOOL size ;-) ...                   
> [ ok ]
>  * genpatches-4.13-1.base.tar.xz SHA256 SHA512 WHIRLPOOL size ;-) ...       
> [ ok ]
>  * genpatches-4.13-1.extras.tar.xz SHA256 SHA512 WHIRLPOOL size ;-) ...     
> [ ok ]
>  * checking ebuild checksums ;-) ...                                        
> [ ok ]
>  * checking miscfile checksums ;-) ...                                      
> [ ok ]
> >>> Preparing to unpack ...
> >>> Unpacking source...
> >>> Unpacking linux-4.13.tar.xz to /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work
> >>> Unpacking genpatches-4.13-1.base.tar.xz to /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/patches
> >>> Unpacking genpatches-4.13-1.extras.tar.xz to /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/patches
>  * Excluding Patch #5000_enable-additional-cpu-optimizations-for-gcc.patch
> ...                                                                         
> [ ok ]
>  * Applying 1500_XATTR_USER_PREFIX.patch (-p1) ...                          
> [ ok ]
>  * Applying 1510_fs-enable-link-security-restrictions-by-default.patch (-p1)
> ...                                                                        [
> ok ]
>  * Applying 2300_enable-poweroff-on-Mac-Pro-11.patch (-p1) ...              
> [ ok ]
>  * Applying 2600_enable-key-swapping-for-apple-mac.patch (-p1) ...          
> [ ok ]
>  * Applying 2900_dev-root-proc-mount-fix.patch (-p1) ...                    
> [ ok ]
>  * Applying 4200_fbcondecor.patch (-p1) ...                                 
> [ ok ]
>  * Applying 4400_alpha-sysctl-uac.patch (-p1) ...                           
> [ ok ]
>  * Applying 4567_distro-Gentoo-Kconfig.patch (-p1) ...                      
> [ ok ]
> >>> Source unpacked in /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work
> >>> Preparing source in /var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/linux-4.13.0-gentoo ...
>  * Applying 4200_fbcondecor.patch ...
> 1 out of 1 hunk FAILED -- saving rejects to file
> Documentation/fb/00-INDEX.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> Documentation/fb/fbcondecor.txt.rej
> 2 out of 2 hunks FAILED -- saving rejects to file drivers/Makefile.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> drivers/video/console/Makefile.rej
> 2 out of 3 hunks FAILED -- saving rejects to file
> drivers/video/console/bitblit.c.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> drivers/video/console/cfbcondecor.c.rej
> 20 out of 23 hunks FAILED -- saving rejects to file
> drivers/video/console/fbcon.c.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> drivers/video/console/fbcondecor.c.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> drivers/video/console/fbcondecor.h.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> drivers/video/fbdev/Kconfig.rej
> 1 out of 2 hunks FAILED -- saving rejects to file
> drivers/video/fbdev/core/fbcmap.c.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> drivers/video/fbdev/core/fbmem.c.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> include/linux/console_decor.h.rej
> 2 out of 2 hunks FAILED -- saving rejects to file
> include/linux/console_struct.h.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> include/linux/console_decor.h.rej
> 2 out of 2 hunks FAILED -- saving rejects to file
> include/linux/console_struct.h.rej
> 1 out of 2 hunks FAILED -- saving rejects to file include/linux/fb.h.rej    
> [ !! ]
>  * ERROR: sys-kernel/gentoo-sources-4.13.0::gentoo failed (prepare phase):
>  *   patch -p1  failed with
> /etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch
>  *
>  * Call stack:
>  *               ebuild.sh, line  115:  Called src_prepare
>  *             environment, line 3819:  Called kernel-2_src_prepare
>  *             environment, line 2143:  Called eapply_user
>  *             environment, line 1077:  Called eapply
> '/etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch'
>  *             environment, line 1047:  Called _eapply_patch
> '/etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch'
>  *             environment, line  985:  Called __helpers_die 'patch -p1 
> failed with
> /etc/portage/patches/sys-kernel/gentoo-sources-4.13.0/4200_fbcondecor.patch'
>  *   isolated-functions.sh, line  117:  Called die
>  * The specific snippet of code:
>  *              die "$@"
>  *
>  * If you need support, post the output of `emerge --info
> '=sys-kernel/gentoo-sources-4.13.0::gentoo'`,
>  * the complete build log and the output of `emerge -pqv
> '=sys-kernel/gentoo-sources-4.13.0::gentoo'`.
>  * The complete build log is located at
> '/var/log/portage/sys-kernel:gentoo-sources-4.13.0:20170904-235505.log'.
>  * For convenience, a symlink to the build log is located at
> '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/temp/build.log'.
>  * The ebuild environment file is located at
> '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/temp/environment'.
>  * Working directory:
> '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/linux-4.13.0-gentoo'
>  * S:
> '/var/tmp/portage/sys-kernel/gentoo-sources-4.13.0/work/linux-4.13.0-gentoo'

Looks like you are applying it twice.  Do you need the manual steps detailed out?
Comment 12 juneau_ 2017-09-05 21:18:23 UTC
(In reply to Mike Pagano from comment #11)
> Looks like you are applying it twice.  Do you need the manual steps detailed out?

According to https://wiki.gentoo.org/wiki//etc/portage/patches#Example
cd $(portageq get_repo_path / gentoo)/sys-kernel/gentoo-sources
EPYTHON=python2.7 ebuild gentoo-sources-4.13.0.ebuild clean prepare
Am I missed something?
Comment 13 Mike Pagano gentoo-dev 2017-09-05 22:25:33 UTC
You're applying it twice...

* Applying 4200_fbcondecor.patch (-p1) ...                                                                                                             [ ok ]

...

 * Applying 4200_fbcondecor.patch ...
1 out of 1 hunk FAILED -- saving rejects to file Documentation/fb/00-INDEX.rej


Can could install vanilla and apply the genpatches against it but you need to put the new 4200 in there.
Comment 14 Dennis Schridde 2017-09-06 06:38:52 UTC
(In reply to juneau_ from comment #9)
(In reply to Mike Pagano from comment #13)

What Mike means: The patch from attachment #492396 [details, diff] *replaces* the patch in the ebuild / genpatches.  Hence it cannot be applied via /etc/portage/patches/.  Since genpatches are applied during src_unpack instead of src_prepare (as it seems from the build.log you posted), before eapply_user, you also cannot patch the extracted patch.  You will have to replace the ebuild and genpatches tarball in its entirety.
Comment 15 Mike Pagano gentoo-dev 2017-09-06 14:48:28 UTC
(In reply to Dennis Schridde from comment #14)
> (In reply to juneau_ from comment #9)
> (In reply to Mike Pagano from comment #13)
> 
> What Mike means: The patch from attachment #492396 [details, diff] [details, diff]
> *replaces* the patch in the ebuild / genpatches.  Hence it cannot be applied
> via /etc/portage/patches/.  Since genpatches are applied during src_unpack
> instead of src_prepare (as it seems from the build.log you posted), before
> eapply_user, you also cannot patch the extracted patch.  You will have to
> replace the ebuild and genpatches tarball in its entirety.

Thanks, yes, this is what I mean.


You can do this if you like.

emerge =sys-kernel/vanilla-sources-4.13.0
mkdir /tmp/patches
cd /tmp/patches
cp /usr/portage/distfiles/genpatches-4.13-1* .
tar -xvf genpatches-4.13-1.base.tar.xz 
tar -xvf genpatches-4.13-1.extras.tar.xz
<replace 4200_fbcondecor.patch with the one from this bug!!>
tar -xvf genpatches-4.13-1.experimental.tar.xz
go to /usr/src/linux-4.13.0
for i in /tmp/patches/*.patch; do patch -p1 < $i; done

use your .config and make/install/boot
Comment 16 juneau_ 2017-09-06 23:42:10 UTC
(In reply to Dennis Schridde from comment #14)
(In reply to Mike Pagano from comment #15)
Thanks for your time, now it's works like a charm.
Comment 17 Mike Pagano gentoo-dev 2017-09-07 00:20:50 UTC
(In reply to juneau_ from comment #16)
> (In reply to Dennis Schridde from comment #14)
> (In reply to Mike Pagano from comment #15)
> Thanks for your time, now it's works like a charm.

No, thank-you for taking the time to post the code change and to test it out.
I'll commit it and it will be in gentoo-sources-4.13.1.

Mike
Comment 18 Mike Pagano gentoo-dev 2017-09-10 14:34:29 UTC
commit 464ad301fb4faa91f984fb3003df87287126d702 (HEAD -> master, origin/master, origin/HEAD)
Author: Mike Pagano <mpagano@gentoo.org>
Date:   Sun Sep 10 10:33:39 2017 -0400

    sys-kernel/gentoo-sources: Linux patch 4.13.1. Fix for fbcondecor patch thanks to François Valenduc. See bug #629860
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.1
Comment 19 Mark I Manning IV 2017-09-10 16:43:38 UTC
just want to send out a HUGE tyvm to everyone involved in tracking down and fixing this bug.