Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629754 - dev-python/pexpect-4.2.1 (possibly others) fails tests due to unset PS1
Summary: dev-python/pexpect-4.2.1 (possibly others) fails tests due to unset PS1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL: https://github.com/pexpect/pexpect/co...
Whiteboard:
Keywords:
: 637262 646706 733752 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-09-03 09:24 UTC by Tobias Klausmann (RETIRED)
Modified: 2021-10-02 14:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Klausmann (RETIRED) gentoo-dev 2017-09-03 09:24:57 UTC
>> Test phase: dev-python/pexpect-4.2.1
 * python2_7: running distutils-r1_run_phase python_test
============================== test session starts ===============================
platform linux2 -- Python 2.7.12, pytest-3.0.3, py-1.4.30, pluggy-0.4.0
rootdir: /var/tmp/portage/dev-python/pexpect-4.2.1/work/pexpect-4.2.1, inifile: setup.cfg
collected 203 items

tests/test_FSM.py .
tests/test_ansi.py .........
tests/test_async.py sssss
tests/test_command_list_split.py .
tests/test_constructor.py ..
tests/test_ctrl_chars.py .....
tests/test_delay.py ..
tests/test_destructor.py .
tests/test_dotall.py ..
tests/test_env.py ....
tests/test_expect.py ..............................
tests/test_filedescriptor.py .....
tests/test_interact.py ...
tests/test_isalive.py .........
tests/test_log.py ....
tests/test_misc.py ...........................
tests/test_missing_command.py .
tests/test_performance.py .
tests/test_pickling.py .
tests/test_popen_spawn.py .........
tests/test_pxssh.py ....
tests/test_replwrap.py .F.......
tests/test_repr.py ...
tests/test_run.py .................
tests/test_screen.py ...........
tests/test_socket.py ...........
tests/test_timeout_pattern.py .....
tests/test_unicode.py ...........
tests/test_which.py .......
tests/test_winsize.py ...

==================================== FAILURES ====================================
_________________________ REPLWrapTestCase.test_bash_env _________________________

self = <tests.test_replwrap.REPLWrapTestCase testMethod=test_bash_env>

    def test_bash_env(self):
        """env, which displays PS1=..., should not mess up finding the prompt.
            """
        bash = replwrap.bash()
        res = bash.run_command("env")
>       self.assertIn('PS1', res)
E       AssertionError: 'PS1' not found in u'LC_PAPER=en_US.utf8\r\nPVR=4.2.1\r\nP
[... a pile of ENV vars that indeed do not have PS1 ...]


# emerge --info
Portage 2.3.6 (python 3.4.5-final-0, default/linux/alpha/13.0, gcc-5.4.0, glibc-2.23-r4, 4.11.9 alpha)
=================================================================
System uname: Linux-4.11.9-alpha-EV68AL-with-gentoo-2.3
KiB Mem:     8301504 total,   1762288 free
KiB Swap:     977912 total,    965608 free
Timestamp of repository gentoo: Sat, 02 Sep 2017 15:24:32 +0000
sh bash 4.3_p48-r1
ld GNU ld (Gentoo 2.28 p1.2) 2.28
app-shells/bash:          4.3_p48-r1::gentoo
dev-lang/perl:            5.24.1-r2::gentoo
dev-lang/python:          2.7.12::gentoo, 3.4.5::gentoo
dev-util/cmake:           3.7.2::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.26.3::gentoo
sys-apps/sandbox:         2.10-r3::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.15-r2::gentoo
sys-devel/binutils:       2.28-r2::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r4::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync5.de.gentoo.org/gentoo-portage
    priority: -1000

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="alpha"
ACCEPT_LICENSE="* -@EULA"
CBUILD="alpha-unknown-linux-gnu"
CFLAGS="-mieee -pipe -O2 -mcpu=ev67"
CHOST="alpha-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.0/ext-active/ /etc/php/cgi-php7.0/ext-active/ /etc/php/cli-php7.0/ext-active/ /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-mieee -pipe -O2 -mcpu=ev67"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LC_ALL="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl alpha bash-completion berkdb bzip2 cli cracklib crypt cxx dri fortran ftp gdbm iconv ipv6 mmap modules ncurses nls nptl nptlonly offensive pam pcre python readline recode session sharedmem sockets ssl tcpd unicode vim vim-pager xattr zlib" ALSA_CARDS="ali5451 als4000 bt87x ca0106 cmipci emu10k1 ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 maestro3 trident usb-audio via82xx ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby22" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Mike Gilbert gentoo-dev 2017-11-06 23:03:09 UTC
I cannot reproduce this; I am unblocking the stable request.
Comment 2 Tobias Klausmann (RETIRED) gentoo-dev 2017-11-09 08:26:35 UTC
I just tried this again with a completely pristine chroot and it still fails the same way.

Running them by hand (cd $WORKDIR; py.test tests/) works fine with Python 3.4.5 and Python 2.7.12. I am pretty sure this is ultimately a defect in the sandbox or another part of Portage's compile/test setup.
Comment 3 Mike Gilbert gentoo-dev 2017-11-12 18:49:18 UTC
*** Bug 637262 has been marked as a duplicate of this bug. ***
Comment 4 Renata Nagtalon 2020-04-01 09:43:54 UTC
The reason for this is that on some systems bashrc does not export the variable PS1. (PS1 is a bash variable but it is not per se an environment variable and thus is not listed by `env` unless explicitly exported).

This can be fixed by exporting PS1 prior to running the test suite or by applying the upstream patch [0] which does itself prior to invoking `env`.

[0] https://github.com/pexpect/pexpect/commit/51c0b09f92f140eda10b62d234710f65ad56dee2
Comment 5 Toralf Förster gentoo-dev 2020-04-01 10:18:25 UTC
*** Bug 646706 has been marked as a duplicate of this bug. ***
Comment 6 Matt Turner gentoo-dev 2020-04-01 17:46:32 UTC
Thanks for the info, that's great!
Comment 7 Agostino Sarubbo gentoo-dev 2020-07-24 07:43:04 UTC
*** Bug 733752 has been marked as a duplicate of this bug. ***
Comment 8 Matt Turner gentoo-dev 2020-12-25 04:02:39 UTC
python@: This is fixed upstream. You may wish to cherry-pick the patch since it's not in a release yet.
Comment 9 Larry the Git Cow gentoo-dev 2021-10-02 14:19:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6665137997d6d28883a233ea9a13f7d56e5c7b12

commit 6665137997d6d28883a233ea9a13f7d56e5c7b12
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2021-10-02 14:17:06 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2021-10-02 14:19:06 +0000

    dev-python/pexpect: fix PS1, cleanup ebuild
    
    Closes: https://bugs.gentoo.org/629754
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 .../pexpect/files/pexpect-4.8.0-fix-PS1.patch       | 16 ++++++++++++++++
 ...pect-4.8.0-r1.ebuild => pexpect-4.8.0-r2.ebuild} | 21 ++++-----------------
 2 files changed, 20 insertions(+), 17 deletions(-)