Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629716 - x11-libs/gdk-pixbuf-2.36.9 - viewnior cannot display tiff images
Summary: x11-libs/gdk-pixbuf-2.36.9 - viewnior cannot display tiff images
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-03 00:16 UTC by Andreas Proteus
Modified: 2017-11-02 18:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Emerge Info (emerge.info.txt,6.58 KB, text/plain)
2017-09-03 00:16 UTC, Andreas Proteus
Details
Patch to restore tiff loading (io-tiff.patch,2.57 KB, patch)
2017-09-04 00:54 UTC, Andreas Proteus
Details | Diff
Sample tiff image (test-image.tar.gz,230.22 KB, application/gzip)
2017-09-04 03:06 UTC, Andreas Proteus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Proteus 2017-09-03 00:16:07 UTC
Created attachment 491990 [details]
Emerge Info

Steps to reproduce.

1. emerge =x11-libs/gdk-2.36.9

2. emerge viewnior 

3. Open a tiff image with viewnior and observe the error message:
   "couldn't recognise the image file format"

4. emerge =x11-libs/gdk-pixbuf-2.36.6

5. Now viewnior can display said tiff images.
Comment 1 Andreas Proteus 2017-09-03 00:19:10 UTC
Typo correction:

1. emerge =x11-libs/gdk-pixbuf-2.36.9
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2017-09-03 13:22:55 UTC
There seem to have been changes in tiff loading between 2.36.6 and 2.36.7. Could you please report this issue upstream and attach a sample tiff file if possible ?
Comment 3 Andreas Proteus 2017-09-04 00:54:47 UTC
Created attachment 492222 [details, diff]
Patch to restore tiff loading

I had a look upstream but I cannot see how to file a bug report in there. 
Anyway, Viewnior fails to load *any* tiff image. Can you please report this upstream? I can supply a typical tiff image here.

The attached patch for io-tiff.c (which I derived by diffing the working 2.36.6 and the failing 2.3.9) restores proper functionality.
Comment 4 Andreas Proteus 2017-09-04 03:06:32 UTC
Created attachment 492224 [details]
Sample tiff image

Here is a test tiff image which viewnior fails to load.

Also please note tha the patch I uploaded in my previous comment does not solve the problem.  Plese delete it
Comment 5 Arfrever Frehtes Taifersar Arahesis 2017-09-13 22:31:45 UTC
Probably this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=786342

gdk-pixbuf-2.36.10 was released 2 days ago.
Fix (https://git.gnome.org/browse/gdk-pixbuf/commit/?id=66537d1ecf7e857a0a443c1ebf72baf6f19dd3e4) for above bug was committed after this release, so please backport it.
Comment 6 Andreas Proteus 2017-09-14 11:36:13 UTC
I applied the patch from upstream but this did not fix the problem.
Please note that now there is no working version of gdk-pixbuf in portage. Last version (gdk-pixbuf-2.36.6) that could load tiff files  has been removed.
Comment 7 Arfrever Frehtes Taifersar Arahesis 2017-09-14 20:31:16 UTC
(In reply to Andreas Proteus from comment #6)
> I applied the patch from upstream but this did not fix the problem.

Have you added GNOME2_EAUTORECONF="yes" at the top of ebuild (before 'inherit ... gnome2')?
Comment 8 Larry the Git Cow gentoo-dev 2017-09-15 06:43:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17cd70a3a834bbaca8d7618eeb901f0c6f870578

commit 17cd70a3a834bbaca8d7618eeb901f0c6f870578
Author:     Gilles Dartiguelongue <eva@gentoo.org>
AuthorDate: 2017-09-15 06:40:41 +0000
Commit:     Gilles Dartiguelongue <eva@gentoo.org>
CommitDate: 2017-09-15 06:42:48 +0000

    x11-libs/gdk-pixbuf: fix TIFF loading support, bug #629716
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=629716
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 .../gdk-pixbuf/files/2.36.10-fix-tiff-loader.patch |  66 +++++++++++
 x11-libs/gdk-pixbuf/gdk-pixbuf-2.36.10-r1.ebuild   | 124 +++++++++++++++++++++
 2 files changed, 190 insertions(+)
Comment 9 tt_1 2017-09-23 07:10:34 UTC
Please either backport the fix to either gdk-pixbuf-2.36.9 or stabilize 2.36.10 instead.